Received: by 2002:ab2:3c46:0:b0:1f5:f2ab:c469 with SMTP id x6csp221421lqf; Fri, 26 Apr 2024 05:05:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXxp7nQBjckAythH8wcjIGofwb6VUInGNEpQofazC3fZOOL7N2mXgG1HoXFfAnGGlauTolNejI/fZFJDN0wnc8grOy8awmQoXkdNMqxJQ== X-Google-Smtp-Source: AGHT+IGaGgcTWA6Quz/IKVaPBJ0wiNZtBxeaNLiPQ6Lmo9Z8B9+W8u6zVfV7dHV72SpkLmabIvFU X-Received: by 2002:a17:903:40c3:b0:1e1:1791:3681 with SMTP id t3-20020a17090340c300b001e117913681mr2980261pld.61.1714133146972; Fri, 26 Apr 2024 05:05:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714133146; cv=pass; d=google.com; s=arc-20160816; b=tjsMHcvFXDp5Wsde1DY5UERwh0+X/U0PsDiw8qpBgaiBQ7Bvaf3z/ENyfCotISFNbd LWFrj582SoRoGiXEHtWyhRyaieqRnWlNl6Fb1ywVFA6KSgTb+h93v3T/8qCzQZ1rApQy hPeYWifqDX5iTVKHpesHGi8TFiKsu7Q9voo9snuimMmjjpsgW+3gLmg98GXN0rTuMEpC 9S4WMJMiP7QVEXTZrWXYmSjja4s3POtYCnX/jp6nFIIC5U9zWe0Fya5xAluyixBEt4oM iY9iM8BIUPglPPBStusfoIxgOzQT7QfILRCCcE/ySH/H3hPxq/nUPmkTpVWzo0991mjC pobg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=r1E79nEG2G0/aOYL7SjrP43Oau3fXMrL0uYYhXjNjkE=; fh=15nWBlLnuijF+d35rjTkr9fxHvwdofgwpI6VBbDa7WA=; b=Un9iKlmMyjzhEpCiaNKLYsIPi2BKRl5ssWUxkaqpBrM1AAU0f/JFgW+LJDrYNtU6UU 5qu05G1XxwbdCz+WeQK3kKen9EKxijFU15uyVjbihp02/SC2ZEeezPl2odioJEfHEKxX juoAXccATaAbFbO3/3lzc+hGbppMc7fxbOUr4y/4B9gFezSAgkBEde0vXgwkuea5XTiT 1RrgX/jPUKwFT3gDR5PUahLuK87oCM732Et1j2owP42MKWbNQLy22HHafH5HUWAVR9/n FDp3eC0AxrdYHerityum40ayt40B92pqFXwffYEK2dwoxsM3VwBz6nP4xsOns58Qz6ST FKZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTIOmvUH; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-159965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159965-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b18-20020a170903229200b001eb1722aaa3si835227plh.373.2024.04.26.05.05.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 05:05:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-159965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTIOmvUH; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-159965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-159965-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 958D6284302 for ; Fri, 26 Apr 2024 12:05:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64098145B1C; Fri, 26 Apr 2024 12:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iTIOmvUH" Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27BDD145B09 for ; Fri, 26 Apr 2024 12:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714133117; cv=none; b=ISCDT8Um7Y8m+4py6sRxSojpt6zteCU/HpqzCahRhBEM/dvSLXMBv+YANUVKolE6kiJgR61Icbq15w60kDhoa/FQkIxCg+RI8lmnFWRRUT7ReD3qLSGBHJ+1Td6uIerWHnrXS87sRYREEUBT2o28N/eGjuUOurZF7LJRJmz1Qkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714133117; c=relaxed/simple; bh=r1E79nEG2G0/aOYL7SjrP43Oau3fXMrL0uYYhXjNjkE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hxCkNDYpK8JjiDopSf/2S1GaLJbQqPjO37I963ZEmwv5fPAlcX0AWWW82R4iQa79C5Fle+6zrhnD6eoNm8RidOVU8P39teuK95sLvyJQPl8jSuFwitvERhd/Mi/VybuB1qzElAMXA+7s2PfFC1FO+GscaPS8mEAjzoPWu+8Mbx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iTIOmvUH; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5aa20adda1dso1336950eaf.1 for ; Fri, 26 Apr 2024 05:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714133115; x=1714737915; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r1E79nEG2G0/aOYL7SjrP43Oau3fXMrL0uYYhXjNjkE=; b=iTIOmvUHJwGmk0Z4Y67dF+vraktLEezx8e1tGLUDNgYP1TzGcnBrghKndnoXerwpyV lYhC4ewd6o/Yw/rlOgyrhuNHA53bGaHFoAw/QMB7jISgEqyYcBNeFyfdfKcwLttIM+q4 EUZ/3YSvOWVJ0pVaahVWWvu8qJ32zxlJ4jJDKRFenMvJtuHWCv5/1/kejdjSkaQGvR40 aR//dOCvs5pKfCMqDykmYoge7BPUtln0IdK7kPvz/a/CjqsltP0UE/1yorAwsQ+TNoKD oyKQnKFbTygXJxsEPtsONfMPatglVsfsiTUtkERUhxFrhhUcr8aYAk3YTZ2ivdIFH2QZ iRLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714133115; x=1714737915; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r1E79nEG2G0/aOYL7SjrP43Oau3fXMrL0uYYhXjNjkE=; b=kUU41uBNupjfQWvZkDahWLrhfvbnP3xUrbmGq0Gx+gwI+WwstP791Iw8PmRDk9oso4 AtjiC6Jrb390mPSeOrN8BbqeCwVhCaoVcGZAUZ5NVHTjkLgQY4ldc+d5jEnCN5368G6i qhuJ52fEbBeCNAJO9xeBydWw0dgbljluaXCQecbf1S7DfrIX1UTU4EDa+h+DebEzET9Y M+foEoQYFD4j8T9To6/8iBqszUgNCcUtELlTGc7h834l1Hmda2XXPplExtzt/aOPu/Ma cHVnRNkgYZ5bPs4t2ti6Va2HBw905D8L/96iylLYtPZqLnhMj7Nw1flPMQeKSlfMUc74 w2hQ== X-Forwarded-Encrypted: i=1; AJvYcCV1denwCcguE8lwZf/1idKDNltZSyNo0kHqYmK91SgNlZ1SkkG89mSMlvsosYIRbH2Xlp7yg8azkYnezJCQecjUmdwCap8HTKej7o5r X-Gm-Message-State: AOJu0YxNytk4sievjADXN8utNPa3LaNNboS3UmME0XvawUk9INAdjRQ9 9/4fkm/vTCfYKPu4/h9wiS1xw57xjqZMVAmTgcgrBzq7nEdxpDNpMZMojlPRajakiBT4g+bfgmt mM6/OWVQWZr7vu7JIL+GUCtghx8YAmPCw5yBQdQ== X-Received: by 2002:a4a:abc5:0:b0:5aa:4d23:9114 with SMTP id o5-20020a4aabc5000000b005aa4d239114mr3138536oon.3.1714133115172; Fri, 26 Apr 2024 05:05:15 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240426092444.825735-1-slark_xiao@163.com> In-Reply-To: <20240426092444.825735-1-slark_xiao@163.com> From: Loic Poulain Date: Fri, 26 Apr 2024 14:04:39 +0200 Message-ID: Subject: Re: [PATCH net v2] net: wwan: Fix missing net device name for error message print To: Slark Xiao Cc: ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hariprasad Kelam Content-Type: text/plain; charset="UTF-8" Hello, On Fri, 26 Apr 2024 at 11:25, Slark Xiao wrote: > > In my local, I got an error print in dmesg like below: > "sequence number glitch prev=487 curr=0" > After checking, it belongs to mhi_wwan_mbim.c. Refer to the usage > of this net_err_ratelimited() API in other files, I think we > should add net device name print before message context. > > Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver") This is more a cosmetic change than a bugfix, you should target net-next IMO. Also as said in another feedback, the commit message does not match the change, since you're not printing the device name.