Received-SPF: pass (google.com: domain of linux-kernel+bounces-160131-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <12d5ddcb-1a26-499c-86df-2919994e247a@amd.com>
Date: Fri, 26 Apr 2024 09:13:17 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 6/6] cpufreq: amd-pstate-ut: support new cpb boost
 control interface
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1714112854.git.perry.yuan@amd.com>
 <e4077298495eae7fbeacaa8a7630e677583dd729.1714112854.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <e4077298495eae7fbeacaa8a7630e677583dd729.1714112854.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MWMyZiszTUpDejhXdm9TM1A0ZDJRS2hHY0pnbkNWekRmbFJMZlRsaXN2ei9n?=
 =?utf-8?B?bENmbTgzYlk0MnB1TnQ2VWxxSHRQVUlLelNTQ3ZJK1BvMWNVbVJTUWt2eG1u?=
 =?utf-8?B?MXBUTHR5TXpqbWNuN01DalRzMkYyTkEzSW1GSjBRQ2lobEp6enZNZ2VSUXJQ?=
 =?utf-8?B?bER5NmsxRC95aThKTUdBZ0NjZEVEc2tKUmh3ZjI1bVlFcHM0YmM3ZmhrTUlk?=
 =?utf-8?B?Zm9hSjZHeVZUaDRQTWZ2OUxKZ0RuV2VGdUFiZkRPWmJOMDZidnF3Q2JXaWxt?=
 =?utf-8?B?QnZSREZwTCtsVUp0cHhsb0tvZUlKK1ZKbEdGSzN5bVFneEpWc3ZjZHJDQUln?=
 =?utf-8?B?UjhsTHVIaFdiMUdXMFhCNG5mck1TUVlOaDRpNkdKaWswUVdNUkd4YXJSS1dq?=
 =?utf-8?B?VCsrNVpwbUYrNWVGWUtaMWVXK1UySzcvck9XUm5NK3VCMi8zYjdFdlNvcy9E?=
 =?utf-8?B?VFFVSjQzMjV6SkREc05tZ2pHd1pEci8vOTF2cmliWGp5RlpOZHZXVWEyWktF?=
 =?utf-8?B?ZDlOdUpYeERkVUJXSG5oWFB5RjB1RzZseWhkdkFwaGY0TmZtNUZDemFkN1gz?=
 =?utf-8?B?ZkQ4NWQ3SS8yNGREUVQzRjRPYUE3amVZdmZ3ZUdCbDZ1S3kyYVE2L2xTemda?=
 =?utf-8?B?UUNabk5xai9XQmJQOEhkNDBLNi8wNnh1RjlZM1h4eXN3VTdHSkRlVUtDcUND?=
 =?utf-8?B?elc4R2NxY2ZmeXNGV2RHVytnaDdQckd3Wm9yN2FFdzMrcDNFM1ZqU1IvZWZK?=
 =?utf-8?B?cmlvVkhGWlR4RHlrZWVCREdQZHNQa0hrdHlyVzM2MjJUdWNEKzU5MHlLbjJN?=
 =?utf-8?B?TC9lSnVSMHVzVTA0OTF5REZGbVEvb2RDSW5zdmE3biszYzhaNFU3VkRqZDdo?=
 =?utf-8?B?RjNsUHFkZlBLdzVJbXFxOUlDQUNzNmZWWGdvT0dlemVGNllLL3RRdVpTVmZU?=
 =?utf-8?B?NWlQRFg2a0syM0lpY1JqV1Azc0hMUEtvakFodzNlSFVYK0pYdDBIRitzNVZh?=
 =?utf-8?B?Q3RUTzRHQllBL0ZuZ3NYTU0yanlmVTE3M0NoanpmSHBPamxxcmEzUFl6S1VI?=
 =?utf-8?B?NDlZZG1lQmY5eUxxdUFGK3pDeTZzV1lkNHpNVyt4NnJFMzdUcGdDNklOQ3k3?=
 =?utf-8?B?dHU5WGhOZG5rd1NDaU5HcTNBaFRlTXNIWjhyWkJ1VWtUQmIvdFJiSUxNU3I3?=
 =?utf-8?B?cmNuL2M1WjlHd3c5UGpFSXRhVjVMeGY5UnUvVzMwN0tseE5ldjJlOTBLMGp3?=
 =?utf-8?B?VXhraXp0RHR2aW9rdHZ0ckhCY0hHa2VKdU9FUEJjb1lzZWFmbnJ1MnBOY1Ji?=
 =?utf-8?B?OGtIcUNUVS9HdFVmSlBwd3Rtby96Sm5LcnJFMVJVdjRLajJuY29KZXFFb0x0?=
 =?utf-8?B?aUZ5T3BpNjhDNGxzSjV1WUp2bERrcGE0WXdTa3lObytRdk5sZHhUVVZBdXZu?=
 =?utf-8?B?VmEvRitiY2JjSXhoSFQ2UjRyanhjTVBEY0RVMWxxN1A3eDE4VG9RRTN0ditX?=
 =?utf-8?B?QzlnbWtwQ0xnMERkZk84MUpJZElIWSt6eXJaWEZKaXB2NEM4cG0rMGwwbjVN?=
 =?utf-8?B?SmFGUWZUNFpBTlNMK1pCMzN3NGhSZk1LV1RNUVNiNkVFdkVGU2d3ZVUreUF0?=
 =?utf-8?B?STNXeVhCK0xPMFlvRm5iWVRaVDY1Z0xoRjV5NFFNam9BNS9GN0J2S0dIL091?=
 =?utf-8?B?RmFqNjdMUUFxZGFCN0pINi9MbWwyUks4SW83WHhCamZBN1pjZGJLM3VnTU8z?=
 =?utf-8?B?RlVOTTlRVko4WkJmQUtPS05oemJQYm5TdXlhdENwdzg5clk4OWoyRmZ1TC81?=
 =?utf-8?B?dmV5TWZFeGtJYWV1U2ZKZDlVYnNSOGxBUFJ2eWhkVUtVcE9Fd3l2R0dEdW81?=
 =?utf-8?B?cWtoMzdFSklDRkJMNWdFSkljdFJEYmxySkk4Y0JEVGsrNDBHeEE1K0JtK09B?=
 =?utf-8?B?VllhMW1mRHZ2dnNmbDlQUXFyYzFnNzZ0RHUvR292ZUt5b2Zzb21VbVNNSmMy?=
 =?utf-8?B?akUwQmdlaDhPRy83d0NyazFEdEdCWGVkd1UzMUh4MmVDcGJhVGx1RFVEcmhs?=
 =?utf-8?B?eUtNT3gwdi8zNDJUdE9kNTNnZ1E5NDEvRmVtV3k4VC8wZ1N5REptQ0l1U0xI?=
 =?utf-8?Q?RXfu4ugbrEYXxMVC3A6+TQkSF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db57e4de-a5fa-4d98-1b15-08dc65fb06a1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 14:13:20.4408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /jOtBXB2u5hi3+pwa2nK8j7kM0GLA1FR/AJKJBvjVgbRWwkQGhyfh1jchMp1MIaH5z3AuGKn8HzNZ63DFZLYTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7667

On 4/26/2024 01:34, Perry Yuan wrote:
> As the new CPB boost control is enabled, pstate unit test needs to remove
> legacy `boost_supported` check and start to use new CPB boost control
> interface `amd_pstate_global_params.cpb_boost`.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Acked-by: Huang Rui <ray.huang@amd.com>
> ---
>   drivers/cpufreq/amd-pstate-ut.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index f04ae67dda37..b3601b0e6dd3 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -226,7 +226,7 @@ static void amd_pstate_ut_check_freq(u32 index)
>   			goto skip_test;
>   		}
>   
> -		if (cpudata->boost_supported) {
> +		if (amd_pstate_global_params.cpb_boost) {

In order to keep unit tests working across a bisect and with how small 
this patch is I think it's better to fold this into patch 3.

>   			if ((policy->max == cpudata->max_freq) ||
>   					(policy->max == cpudata->nominal_freq))
>   				amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS;