Received-SPF: pass (google.com: domain of linux-kernel+bounces-160167-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 26 Apr 2024 17:34:44 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: lumingyindetect@126.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	ilpo.jarvinen@linux.intel.com, gregkh@linuxfoundation.org,
	jirislaby@kernel.org,
	LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
Subject: Re: [PATCH] "drivers:Fixed memory leak in
 /linux/drivers/tty/serial/8250/8250_lpss.c file.
Message-ID: <Ziu7hC25v2Xi50VG@smile.fi.intel.com>
References: <20240426021939.1083521-1-lumingyindetect@126.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426021939.1083521-1-lumingyindetect@126.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 26, 2024 at 03:19:39AM +0100, lumingyindetect@126.com wrote:
> From: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
> 
> In the lpss8250_probe function in the file
> /linux/drivers/tty/serial/8250/8250_lpss.c, there were certain return paths
> where pci_free_irq_vectors was not called to release memory related to pdev,
> leading to a memory leak. This commit fixes that issue."

This patch does not fix anything. The driver uses pcim_enable_device()
which changes how this all behaves.

NAK.

-- 
With Best Regards,
Andy Shevchenko