Received-SPF: pass (google.com: domain of linux-kernel+bounces-160178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Apr 2024 17:44:14 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: lumingyindetect@126.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	ilpo.jarvinen@linux.intel.com, gregkh@linuxfoundation.org,
	jirislaby@kernel.or
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Message-ID: <Ziu9viefEtkQmHbz@smile.fi.intel.com>
References: <20240426133959.1294012-1-lumingyindetect@126.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426133959.1294012-1-lumingyindetect@126.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 26, 2024 at 02:39:59PM +0100, lumingyindetect@126.com wrote:
> From: LuMingYin <lumingyindetect@126.com>
> 
> The return statements at line 347 and line 351 in the lpss8250_probe()
> function result in a memory leak of the variable pdev.  Add a label named
> free_irq_vectors in the lpss8250_probe() function to release the memory area
> pointed to by pdev.  Modify the two return statements mentioned above to jump
> to the label "free_irq_vectors" instead.

> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67 ("serial: 8250_lpss: fix memory in lpss8250_probe()")

Same as for the previous version, NAK.

This patch does NOT fix anything. Please, read the code and try to understand
how it works.

-- 
With Best Regards,
Andy Shevchenko