Received-SPF: pass (google.com: domain of linux-kernel+bounces-160185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Apr 2024 17:45:49 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: lumingyindetect@126.com, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
	gregkh@linuxfoundation.org, jirislaby@kernel.org,
	LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Message-ID: <Ziu-HUUE43xsjnia@smile.fi.intel.com>
References: <20240426114716.1275085-1-lumingyindetect@126.com>
 <87d376e4-84f1-48c3-8c5d-955f706f3bfb@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d376e4-84f1-48c3-8c5d-955f706f3bfb@moroto.mountain>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 26, 2024 at 04:53:18PM +0300, Dan Carpenter wrote:

> > Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
> 
> This is the wrong hash and the format is wrong.  It should be:
> 
> Fixes: 254cc7743e84 ("serial: 8250_lpss: Switch over to MSI interrupts")

Since you are here, just pay attention that this does NOT fix anything
as it uses pcim_enable_device(). I hope smatch won't stumble over this
and produce false positives.

-- 
With Best Regards,
Andy Shevchenko