Received-SPF: pass (google.com: domain of linux-kernel+bounces-160197-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b618c170-78dd-78fb-0123-c6aa8d9125c9@amd.com>
Date: Fri, 26 Apr 2024 09:56:31 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v2 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 Babu Moger <babu.moger@amd.com>
Cc: fenghua.yu@intel.com, Reinette Chatre <reinette.chatre@intel.com>,
 shuah@kernel.org, LKML <linux-kernel@vger.kernel.org>,
 linux-kselftest@vger.kernel.org,
 =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= <maciej.wieczor-retman@intel.com>,
 peternewman@google.com, eranian@google.com
References: <cover.1708637563.git.babu.moger@amd.com>
 <cover.1714073751.git.babu.moger@amd.com>
 <e3bf1fbbe3ab2d9c2dc1d9669a791de140dea248.1714073751.git.babu.moger@amd.com>
 <911547f7-e952-f771-867a-57c1de738c39@linux.intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <911547f7-e952-f771-867a-57c1de738c39@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T1J1TC9yc1FGYkFaeTRtRmpoN2pLczdjQ1d1Yjl6cWlRWU1mYVdMRllGYUNU?=
 =?utf-8?B?NkRublpJOTVSaHFRc3ZVZDlFNVd4RzQ2am5PSElYeStsM0hQN20rcm5ad0pT?=
 =?utf-8?B?V3lVZjMwVm44Qm1OMGxjMFlycmRKVkN4eGEyaUQxY2I3T3BWanlNcnA5RlJt?=
 =?utf-8?B?T0NHeEpVZm5kdzZLRUQvU1A2MXg4ZStvUnNsZWpJYTZNcnFPUHFDRXliTTRO?=
 =?utf-8?B?YlV6VTd6Z3gwQUpwaDNSQnBBOTBBRExxbUlzbzRZT28wdDRwejI2M0tmSGto?=
 =?utf-8?B?WjhUTGVZR2lLbzVaQTAxTDZzU3MzSDBRZk9id0dSY2hDUWh0MFNpbjV0WFFX?=
 =?utf-8?B?ZGRtc3FrV1F6Yms0ZThVOVE4VzRTYmN6NGhBQ1FTblJJKzU4eEZDREJUd3pR?=
 =?utf-8?B?U2JiaDZJa1pQeWc5TUhGbUdFMklPVmxCcjBlaHNINFZkVkViS084ZHJCeVlo?=
 =?utf-8?B?TW5DcTc0UW9xUklpcjRzaGV6S3hhemREUE1VemFyU0kybU5pRnlyMXNXRVdX?=
 =?utf-8?B?dVYrNXFjUkQ2cWtLK0tTN1ZXanFHdkNMNDhlcG9ZSno2MUVoZUluUG1tOHJp?=
 =?utf-8?B?ejY0VWFHalFNUW02eE5lblVUZDlqSzZaSFhqRFp0czZyYloyRjNlY0lKcVRZ?=
 =?utf-8?B?MjdScmNsNXNUdWZ3bHV4Q1pjSzgxMjh0K3h0WU9NMmRwMFNRM2xQOEJUWktV?=
 =?utf-8?B?ZkYyS1lJTU5Ic29XRkpWcWM5aFNDekwxcW9uQ202cFpkc0h5cGJqWFZKME81?=
 =?utf-8?B?cEFXZE5KOWl1Um9ZS0NnMjkzc2NjNmJ0NmdVMTVHOE4zM1RldnVtQ2srcG5h?=
 =?utf-8?B?azVTVG9KenRvVmFuTXZDTlR4RnRQNC80eVZjMnBobnhtd0lqMG1veW1Rb2E5?=
 =?utf-8?B?YVN1TU5Say93bFQ2OS9ia2ZhOWVwNkprdW9XNmlWY3UvK2RIaDJCcHNDZHox?=
 =?utf-8?B?VldTVjNBMmdjQmd5QWw1bXd2RXhZNk9NMUhpaG94ZFZocXExN3QwRzA0ak1G?=
 =?utf-8?B?dFU1VzI0NzJJTGVxck5LSlMyeGdWMFIrNUNONkZZelpIaXNWU1l1eGg0ZER5?=
 =?utf-8?B?YnRSQk01ZlIxS29QL1JVNW5HQ2JxWHVVSWw0eHJkYWFEV250R3htYzFHUEp6?=
 =?utf-8?B?aFBFd09PNk40OTRiSzBIdEQyRDBXdnBwblFoZGJoZXBQTjgxbGZqRkliSXpq?=
 =?utf-8?B?NVI2Z25nYktTOCtoZ2l3WGFZaHA4b0lYbFphaFhlVEhWTXFqYVVyN1I5ZTFa?=
 =?utf-8?B?N05tcTNGUEJZQytqZHFING5hTlZidVlwdVFpdGtNaVJFbEZCbVg3cHFVcWh4?=
 =?utf-8?B?UCtCcGF2SVJGUDZBVFNKTHZ6RjY5cXdQcWc0T2hQVlMxVGVVRm5OWWNzdEhu?=
 =?utf-8?B?cnRLdkF3dzFnUk1WcGI4R1NGM1VGWnczeFFaR1YyYnUrenYvd2VBSmxzQmlB?=
 =?utf-8?B?bjZmYVk0MkUydnFicVFKellhMlhydFBFa254Q3BsNWgwUHZkcGhxM1REbG5j?=
 =?utf-8?B?MU4xMFJTRGthL3RFclMyVzFieUVWVkNKWlp0NlRWWndHLzdXREJmUlRvYTlS?=
 =?utf-8?B?VWQ2QkNrd0tTTnZMTFFFU0hzS3BtSHNhRnNHblhuRGhOWHVQVTVjTDIvOHEx?=
 =?utf-8?B?RDE3eUNzMGVkY0lkcUlSMjF4Vm5YNWFVS0hHY0JKQ3dKVjdOcUVpY2lqUWZU?=
 =?utf-8?B?UnR2Qm5hb1JTckF5OU1PeFlSbk1aR2Z4S2ExcHdrSHMvNStnOWVGb3F1MVhM?=
 =?utf-8?B?V2FwOEpuc3o1d1ZBeTZpZU40L0t1d2QzbzgxK3FTZmdsR25pNkZ3L3VSVWtj?=
 =?utf-8?B?bEFYT1JFYUVrOEtZQlBSazhJdTlFREU2blZPME9tL0U0UmtaRGhYUEtwTTVU?=
 =?utf-8?B?NkhxaDhIQnh1Yzg2bWZVSnpWb2kwdUwxTlJjbHlsUHBjTCt5ZDBHL2tLSzZG?=
 =?utf-8?B?RTYvYWo5UG9VWEc1S20rMlBjWUJCcGdwamRJd25DdmdpU1JsZEc3TStRTHhy?=
 =?utf-8?B?cXRXMG03TXg3ckFKajJHa21yeDdvdndlcmZtZUdLbDlPTU5YTVR5TW93Z0Ry?=
 =?utf-8?B?UC83L1Z3bCtoSXVBeUZSeCs4ZXhIOTJxajUxQS9sRVhPd0EyVzVsVHczMzcv?=
 =?utf-8?Q?MtsXovktWDsgbMpv9jIUOn9uK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2ddab7-0e66-4e6f-441c-08dc660111f9
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 14:56:36.3827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HYdrE9Froasmx5rIyag1GIGRBktE9woGBTtB2PaudI28mMYyAmJnCYkTGJyyBwF9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8710

Hi Ilpo,

On 4/26/2024 2:06 AM, Ilpo Järvinen wrote:
> On Thu, 25 Apr 2024, Babu Moger wrote:
>
>> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
>> available on the system. Tests will be skipped otherwise.
>>
>> Update noncont_cat_run_test to check for vendor. AMD supports
>> non contiguous CBM masks but does not report it via CPUID.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>   tools/testing/selftests/resctrl/cat_test.c | 2 +-
>>   tools/testing/selftests/resctrl/mba_test.c | 1 -
>>   tools/testing/selftests/resctrl/mbm_test.c | 1 -
>>   3 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>> index 4cb991be8e31..b682eaf65bfd 100644
>> --- a/tools/testing/selftests/resctrl/cat_test.c
>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>> @@ -314,7 +314,7 @@ static int noncont_cat_run_test(const struct resctrl_test *test,
>>   	else
>>   		return -EINVAL;
>>   
>> -	if (sparse_masks != ((ecx >> 3) & 1)) {
>> +	if ((get_vendor() == ARCH_INTEL) && sparse_masks != ((ecx >> 3) & 1)) {
> This looks independent change to me which should be put into own patch.

Sure. Will do.

Thanks

Babu