Received-SPF: pass (google.com: domain of linux-kernel+bounces-160196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5d515e4e-5db8-4840-a200-a67e7df8043b@amd.com>
Date: Fri, 26 Apr 2024 09:56:25 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] x86/sev: Add callback to apply RMP table fixups
 for kexec.
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: thomas.lendacky@amd.com, michael.roth@amd.com, x86@kernel.org,
 linux-kernel@vger.kernel.org
References: <cover.1713212104.git.ashish.kalra@amd.com>
 <96b2949cf225501d686b47070c7bbad341e160a3.1713212104.git.ashish.kalra@amd.com>
 <20240420130533.GNZiO9nShSxjxB-FQn@fat_crate.local>
 <ed4cb373-e626-4b79-b692-df5ea2ca8899@amd.com>
 <20240426125803.GDZiuk2-YonyodvSbi@fat_crate.local>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <20240426125803.GDZiuk2-YonyodvSbi@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U0hPaEgzOHlmVjgyK1VnSkE3dG5LSmZ6SDR1bDNuRUNmNjRoTGZxWkVpZTA3?=
 =?utf-8?B?cTJ4SFRtOGZQd1I1SVpWV1hheVVSQ1pZcEk2ZmdDZzhZNlRQeTIwTzVlUmky?=
 =?utf-8?B?ZzJ2THp5YWxxWVRWWi9pT1ZLYmZWL0FoNmFjTmNWZFBYOVVTQlJFZG5GU0RT?=
 =?utf-8?B?cno0ZDhBbklkQW9qZlFWR1JRSytHZHMrRjJ0QjlUclp6MFQyVWdwbUlQdGVk?=
 =?utf-8?B?ZmFhTmRaUFc2Q0lXMHl0VnJFc1M4c0tMcEwrbE5uaTFIbjVwMTBNUW5YaFJ1?=
 =?utf-8?B?dlY4OTE4Mk5nQlpmMnN0Nk85ZnhvTmtuWVc3OG5MU2pYdkZ6WGUzQTY5U2lU?=
 =?utf-8?B?d1RFUzQ2cXRNSzhRMnZJU1llcWt0ZUJoay8wRC91MTRqQ2xuYXNyRFpSVjZu?=
 =?utf-8?B?ZENwWUNIV3JXTXdyazBveDJFZkt3ODNhbktiOHc2d3pIVWRrYnJmRlVwR1dC?=
 =?utf-8?B?Vmw3SXZ5TzI3QTRHVk81KzU2aG93d2QydG1OdnVqR2llOTJyMEgxbFI5eDNK?=
 =?utf-8?B?YnRRb3BtZW9hVzRtb3g4ZDRYWG9RMWJnSGJGOVNvek56aENjRGFYTnFsZTBD?=
 =?utf-8?B?d0J0a04yWkxqcTdmWnFDRmowZnpndVQ2a2w0WHFzd2dZcWNvMlJNREk2aG4y?=
 =?utf-8?B?elJIL290cDBLa0kySENkQVMwQ0lpc2lDODlwTkg3Sk9zYXNlQjkwU0VYYWxX?=
 =?utf-8?B?Uy8wYWZmKzhBTXdsdnliRzVob3FRMFYwejNDdVZIdXd5YnptZXF0RmUybEJm?=
 =?utf-8?B?YWhWK3JtTWw1V1ZIRXVhZEVleFhkdjhzMG5OVUFJb3pzbG44Q0lrOHNpMGNk?=
 =?utf-8?B?dVpEWExIVndjT3hzVWNEVkhlbWhFTEZYVWRsb3RUMzNINVdZTjl2R0xGZ2VZ?=
 =?utf-8?B?aTdWSWRwemI1d1dQREpzaW54ejBjcHJyQjZaT3dQS21KYjUrcUtySFhERHRP?=
 =?utf-8?B?L2lHWFhWd0huc1JJLzJTUm5USDJZbmFmZW40RzhKV2VIemk2N0FyUi91dUxv?=
 =?utf-8?B?aEZ4OElvNTA5UUdZYW44dDQyNXRYeTVVQ3JFWmd4NEg0Uk5nQnYwcTkxeW5S?=
 =?utf-8?B?THRwcHIrT3FUQmJZYXdPZ3ZHOVVWUElXR3lCSitpdzAyVmhLdFI3WkNxTlhF?=
 =?utf-8?B?TlBkM1BIYWEycHZMSlNxcDhYZ2VHLzA1WjNwRUZXYnI5TXBCTlJ2d1NMSTdL?=
 =?utf-8?B?RnVxQS9NRVdRZXpWQXRyZTlmZHUyeldIN3dqLzZ4T3UrQUpmSHBGVkovZi9j?=
 =?utf-8?B?YTh4a3kzSnMyVVlwS3g3NVY2Y3dwMGpHWEZ1TUxwM3dpN2M5TXpFRnBKNmdC?=
 =?utf-8?B?M0thNWhtdU9mSG81Wnk0M1lBKzZxTWxjNDB4TG9qNzJvSHhZazRFenIwNUla?=
 =?utf-8?B?TkNVbnlTNE5ka3RERkhzTGtOWlB2NGloRTQrZGJHNTQ3S2cveDB3UWxmSHpT?=
 =?utf-8?B?SE0yWEMydDYwQjlEVWYyZm81VSsxOSttQThlMENGMGJGS0xJUHF0VnpOK0Fv?=
 =?utf-8?B?bHUwNHFSZlA5d0k3TXl0dUl4dWJJQlQ5RWdpbU96YzBjN2NMZ2R1TzVKSzBX?=
 =?utf-8?B?aVlCaDNPYW5rVUhnYi9scUlHcXFFbWNoTVdpQ2FqMUhVV204QUdKT0ZKeDVt?=
 =?utf-8?B?VWhuWGJURlcwcmh2VWJkMXlvbEdUNWFGd0tTUkl2WEg0ZmZycEl1d3ZLbEVV?=
 =?utf-8?B?QzR3RmZLQmE0SG5lVzFjZE83dVF0N0U1eVV1MXVZM3pDU1FKOTJycE9zell1?=
 =?utf-8?B?U0o3TlB6Qzd1RWRSTzFrMGc3eHlCK0F6eWQ5Qmx4QjRlWUdkTko4emprZ2VO?=
 =?utf-8?B?NlYrNkpkZEVaYkxHMnQ2RXVVWDBZeWtwK2ZTZCtuak9Pa2JORVRIRUhZV3Zt?=
 =?utf-8?B?N0dQWURVMVB0azRmSUVORU4yOXUwRVBOVjFBMk9yNDFaeW9ldTZhOGRzcG5U?=
 =?utf-8?B?bEZhZVREV1VSUW1OYWlpUzQreS8vNmlybDZmQjBJZGdzdW5EMDhSODRLbDhR?=
 =?utf-8?B?bCtTQzFaQUZObWlJcU9HZzI1cks0azhibzFmWEgzUy9DdVZWWmlqdjVhYXhT?=
 =?utf-8?B?eTJxVFRaV1dKMjFSTEREN3pCK2lXeW1nVVY3a2kwclJtM2NlZGVMSVNxaFZZ?=
 =?utf-8?Q?Bw4pf+0W1li/UmmHsO9AjA7fR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4e5f42d-a517-4b91-44c6-08dc66010cb3
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 14:56:27.4864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cv/oa1A36snAiwRqnrn1O5DxrBn4UPGpA3VVZSkOW+Qx98HrsgZOSe+yHfZXENsxvLiuRbHb8NHLSCamG7XvnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4473

On 4/26/2024 7:58 AM, Borislav Petkov wrote:

> On Wed, Apr 24, 2024 at 06:48:08PM -0500, Kalra, Ashish wrote:
>> This callback needs to be invoked as part of setup_arch() as it needs e820
>> table to be setup in e820__memory_setup() before the callback is invoked and
>> snp_init() is called from sme_enable() in kernel/head_64.S (startup_64),
>> which is much before start_kernel() -> setup_arch() is invoked.
> So?
>
> snp_init() still runs before e820__memory_setup(). So what's stopping
> you?

As i have already explained above, snp_init() runs before 
e820__memory_setup() so we can't invoke this callback in snp_init() as 
e820 tables have still not been setup. Again to summarize, the e820 
tables are setup in e820__memory_setup() which runs after snp_init().

Additionally, RMP table also get probed after snp_init(). So this 
callback cannot be invoked in snp_init().

I have added this comment to v3 of this patch series which i posted 
yesterday, so please look at those.

Thanks, Ashish