Received: by 2002:ab2:1c04:0:b0:1f7:53ba:1ebe with SMTP id f4csp38891lqg; Fri, 26 Apr 2024 08:12:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVoQI5eqQ2zdm1ESgrD9xy+wOCJ64gf5Fq8K1ahfcjHVpw7cPhTWcsyH8/Rl/eA+2+F4NFknSc4on2Olq34PWTzmWUS6m+WhJpaQ+5hXA== X-Google-Smtp-Source: AGHT+IEIbCcr03i8e+4WhcSiaXZ2VfmNQ13c4vDql3MUIh0Q7xykMzU8U5iPMylBjl4SGQFHG4SY X-Received: by 2002:ac8:5fc4:0:b0:436:8b5a:398a with SMTP id k4-20020ac85fc4000000b004368b5a398amr3682011qta.12.1714144354193; Fri, 26 Apr 2024 08:12:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714144354; cv=pass; d=google.com; s=arc-20160816; b=BSYALY4LMfb14YeyzBOlckT99pXxaP43w0HMIIG+ynoRl+NwAU768lKDf1iKuoj7Ru CswC5TOfCUoRQfvRyLpeau/d9t950GVBZLwnR/lPPk2VOmX+zoxg9cmS1agl/zh4XDx3 ZiEgxsiPWY6QFt4bYhsaB86LToogZE8lHg421JIWQ1FLB3NDZ/FBj2cZA0/pQnD4Ximy 5wYLiq0+/YiDU84SxAgVUR1UghKQPCvPMKrlxhNN2GTzT6VsOcivUFCV9fpqXQdTtdKk SDzzYRkirf2fIovgIt69QWPoVjZIsk7+RE5sEooFLrLGHrvtQqDm7VAYXBJmpDyhz2tN qhuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=XQj/Ylfb4d6YBPhBaIsZnSkNdqe2sNrsfE8wIOzq64w=; fh=cRawPwqSvjYJRXGWKEVd1ElXmDSD8xlaUASQ6xV2o04=; b=khwA7Dpmg5Y0BfvkEn6otQNEvxg+d4lDsDczk2+kGfCVKU40Bgjw2JLhcdGYC0jIGt u69feCIL+FXbiD2o0QMWMRtcb3v9oeU62SYkXYD91dtvgUCTZbedA4+vsjVdlxnEXxe/ G4dq6lpCfDyBO2GQSncIWKSCtAKH6ZnzHI9q71eAjLlwpCYdWNj/ReOVGrzrzYG/58wJ KyvFePcSsqbqDlGofxqZhVGCjKkDtJeGQCRry/Z6nmL9XZN+UXvaMhx3D9H/yJUun8ED rF99r+p3X6I8BBHURD8UgKhmqc4HfimM28iwV6ZZsBI7jDoL8BZ6NZFHDe4vlUcdC+RL aCoQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=sCM1FXj8; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-160229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160229-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id r7-20020a05622a034700b00439f17c1d97si9264004qtw.734.2024.04.26.08.12.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 08:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=sCM1FXj8; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-160229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160229-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 90DFC1C21C0B for ; Fri, 26 Apr 2024 15:12:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1D5D215AAD2; Fri, 26 Apr 2024 15:09:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="sCM1FXj8" Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11309149019; Fri, 26 Apr 2024 15:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714144193; cv=none; b=NzeWoY066ktc1TXGuaasji2US8Ig6Fhk6gCBaa7JMtOmvRpfJHvHDUiPMwj5DQPrvpAEdWw2PFFVvfgRpS6S4PBYIIbAG++rCnh2fVYC6R8KTf3P3HErL09yqX/RslCSe8xqi4oNPPGa3OmZAVhOr2s0uiOSz2TFV6KlX1yuj5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714144193; c=relaxed/simple; bh=7iwWC5ZXQovuAiAHz/mYCZpJqUDhrimhennWjXiI63I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WVYFxScJCgG1X97LIffU7JGvU8L440eLBU4rMIza++HaBCAdChfB9HriKpT7ifC+SIHyMAuMiY7Z1AcGy1nLqTzyl2JGWBPn2zvhH2uuefrsqk63nBwSmTHF+vzI5hiWJZASVUaCc7cUrNnFe+AF7w25T05BMnWQ7pGY1hu6uiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=sCM1FXj8; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43QDp3wQ000596; Fri, 26 Apr 2024 15:09:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=XQj/Ylfb4d6YBPhBaIsZnSkNdqe2sNrsfE8wIOzq64w=; b=sCM1FXj8xNtQFbAO2YQ9CvtF/vZPcH3UNASfAScc9zjWuvKSW2zksWdA9oZ8yWOPj5SX omt4Aj6CZ/oqfcR4YYVapOC8LdiUajKe7e/cP1w+GCyE0qTxCblyGViJyTFzDYT6RJDv BNilwSEjqrYa0x5mdfSSSmDzYRm1HvMH/L4eWcIrZvk5rkS2Y9Djuh2EkSaerN/4FXjw WY1MQxykhi9vz5xwENLjjZX0L4CtRnF/EPjERVN1blJkNoBUNXCxPURhdjpvasJcw712 M2CjQGNqUj1Gm6oyLjexbiMMQGMZh6t4h2skF1VUB9+UGd93JeG0slBRWmUonLjGN9CG Eg== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xrdad07q9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2024 15:09:39 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43QCrdga023042; Fri, 26 Apr 2024 15:09:37 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xms1pgcph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2024 15:09:37 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43QF9Zmv1835548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Apr 2024 15:09:37 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1F48D58061; Fri, 26 Apr 2024 15:09:35 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CD9E95805F; Fri, 26 Apr 2024 15:09:34 +0000 (GMT) Received: from [9.61.156.17] (unknown [9.61.156.17]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Apr 2024 15:09:34 +0000 (GMT) Message-ID: <47c8fd94-6137-4d84-99a9-e8ff86c6dc31@linux.ibm.com> Date: Fri, 26 Apr 2024 10:09:34 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/14] dt-bindings: fsi: Document the IBM SBEFIFO engine To: Krzysztof Kozlowski , linux-aspeed@lists.ozlabs.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org, lakshmiy@us.ibm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au References: <20240425213701.655540-1-eajames@linux.ibm.com> <20240425213701.655540-6-eajames@linux.ibm.com> <5fb62fcf-36a8-4efa-9387-d0af8fcafb18@kernel.org> Content-Language: en-US From: Eddie James In-Reply-To: <5fb62fcf-36a8-4efa-9387-d0af8fcafb18@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BJC-K6KR8dZCpa4l5BU-e4YHq2kWKUgP X-Proofpoint-ORIG-GUID: BJC-K6KR8dZCpa4l5BU-e4YHq2kWKUgP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-26_12,2024-04-26_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404260102 On 4/26/24 01:20, Krzysztof Kozlowski wrote: > On 25/04/2024 23:36, Eddie James wrote: >> The SBEFIFO engine provides an interface to the POWER processor >> Self Boot Engine (SBE). >> >> Signed-off-by: Eddie James >> Acked-by: Conor Dooley >> Reviewed-by: Andrew Jeffery >> --- > >> +description: >> + The SBEFIFO is an FSI CFAM engine that provides an interface to the >> + POWER processor Self Boot Engine (SBE). This node will always be a child >> + of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM >> + nodes. >> + >> +properties: >> + compatible: >> + enum: >> + - ibm,p9-sbefifo >> + - ibm,odyssey-sbefifo >> + >> + reg: >> + items: >> + - description: FSI slave address >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> +patternProperties: >> + "^occ(@.*)?": > Why unit address is optional? In this case, it's because we use the reg property (reflecting the unit address) to indicate the processor index of the occ node. However I think I should drop the unit address here, it's meaningless, there is no addressing for the OCC from the SBEFIFO. > > > > Best regards, > Krzysztof >