Received-SPF: pass (google.com: domain of linux-kernel+bounces-160259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Apr 2024 17:07:29 +0200
From: Christian Heusel <christian@heusel.eu>
To: lumingyindetect <lumingyindetect@126.com>
Cc: Markus Elfring <Markus.Elfring@web.de>, linux-serial@vger.kernel.org, 
	kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Message-ID: <xoqjkheigkwozgpckrdpyrfwzw33gjs564plbhbujzfdqwhcti@bsvrni5a624e>
References: <20240426114716.1275085-1-lumingyindetect@126.com>
 <42c5d1f0-d16a-483b-8bb1-4c5768aa3a8c@web.de>
 <4e6966e0.a07e.18f1a7f7863.Coremail.lumingyindetect@126.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qlpmab66ws2khlm3"
Content-Disposition: inline
In-Reply-To: <4e6966e0.a07e.18f1a7f7863.Coremail.lumingyindetect@126.com>
UI-OutboundReport: notjunk:1;M01:P0:h0eGSJvPrfo=;l9RT6DJoa/wuUZb+AfO1LhYfqsG
 8zK2nxNUJ7iTDdqdNlgO739LoW+B6kaMm9721WjnhF+TNhOYkVhppWGyCEgplLJyzc+vC/woY
 FjFdmjC7Ju9+sbKh+88Rx69Ec+BH6v0U2PXcEMMY8NxsEgHE+JEiqczKYCjyEyPPn0Tx5YMp9
 fgIlrIS+4wbFSEDawzCG1uur08+ofjTUSSt6bBCtEpqWVgCYeX5dpa/JMBdEU1AiCB2nNzdX5
 qouexPsDVbL+jLlF+SUoYGSj63Sg0GxbxguUOgI4wMnvArS1vrUApopNOgvJJiKe0WPPbtcdA
 DI+II290Levat0yfMCzmCjsdvF+gjFx+lqrkmkSpG1LjcC2rlPhM11z3XJLXr7GSj6r2aTfTR
 Qo1nD7sb7IZ62RqsQ/bIXBlvBXNugps7XQhRdTY/RJ1BSXsy7mLLlAvqFWvM3iNoVvf9iuiB8
 lfqVvlYDD0j7YoeQJ8YnUn+oh4l7/Z8UTlAJXfbWjyjabQBz+rpGOO0BYSK5majISxwxjQDQD
 JBHwfSdtuEYcjRAG2Af8kwvWRy0ubseGYVQ/uo/c6tgLY8ZYNb0b3fTDHyJIDwRF3IS/OXech
 NkuY7OyVKXEmsAKnn0H9Aoeo2ty3Qn/zDdQbskUorb/JMedb3a87oRe7shB2LVwOr8qhcchyx
 80SMKAqW8NOtCc2hNuJYIHq8b6/PjtTOLwMSSDqL9h4iCZwLmapP3N9CdbOZAW2yDlDUzryMO
 rtMEx6tWk1Fnya9EtYfGR5+lFBSAZWJsRDw8gCfoNy20aZQILHSkHY=


--qlpmab66ws2khlm3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On 24/04/26 09:01PM, lumingyindetect wrote:
> Dear Markus,
>
> Thank you for your patient guidance and advice! This is my first time submitting a patch, and I haven't fully understood the meaning of "add a commit subject for this tag" yet. Could you please provide some examples or guidance on how to add it? I appreciate your help!
>
> Best regards,
> LuMingYin

Hey LuMingYin,

just for your information that while he means well the advice from
Markus is not always shared by other maintainers and their inablility to
adapt to such feedback got them banned for a while on lkml. See i.e.
https://lore.kernel.org/all/2024042547-shimmy-guileless-c7f2@gregkh/
for an instance where greg is sending a relevant reply to one of their
requested changes / feedback to patches.

So just evaluate for yourself whether the feedback makes sense and just
go along of the official documentation[0] and feedback you get from the
relevant subsystem maintainers.

Cheers,
chris

[0]: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

--qlpmab66ws2khlm3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb3ea3iR6a4oPcswTwEfU8yi1JYUFAmYrwzAACgkQwEfU8yi1
JYVbMxAAvKybMp/z4Oapf3lItgsKsaqCqtaaeTpi3qPqwtX8ZUkbpJh2QxJ5dUph
YPJ+7HSMRtEY9S19Qt8d5GnTG2L/wXEPk5bMVIrizs/5tXfT5Gp05wfbKUKHZUqF
3m5n2Y1O9deSaFAKngJxwtM9qdRfRlF7Oef5+pX9IpooxNf1hgSwq9xlNryv0yhF
8wxT9e3e/4EdQcPeJl6S/lUr6KDH32+sotVipPEUevqNitr8h0MsP+H5CLj3B2Cr
9OxmbMTmuhla2dEzJuTFRJdrc424LaKml3qMARpGrsuLH8NbIQBGWmm2CeaCpQd3
5qYnlrsf/IFR2t2+dCc9TVbYdOHYFazcc6NVclNI5Eaifnsh1gGiDTxNGK7kChKU
1g6USkDOTicC9mLO/+hHDkoI4NzgulriDLHuZJF0mBzBlMXQm4H65TZ4ubIO0Vva
YFAKuGJ/D46gPuWGIKxSykZKMLOgn0hoIsvY3FPriUXTWEzsh0aQQafzZlO0aPHW
uk/Nz0yw4Ot5krRNltpAed4kuQd/24tQNrkEIwbkivzLIfd4MkFUD3q7DN2Bzkru
7mXcE6hUNDN+LSGd4mctl4xQe++mKbUw9N8OM9hliry8G7nS+pIpCZIvXlcoFEIO
yPRtXTgFGYZ32ctg/baGBtGgXxbC4qgo5j31wVZUFZuQuto692M=
=iecE
-----END PGP SIGNATURE-----

--qlpmab66ws2khlm3--