Received-SPF: pass (google.com: domain of linux-kernel+bounces-160261-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <24e7644e-f9ff-4a4b-8883-33b2f69b36cf@linux.ibm.com>
Date: Fri, 26 Apr 2024 10:13:52 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 08/14] dt-bindings: fsi: ast2600-fsi-master: Switch to
 yaml format
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsi@lists.ozlabs.org, linux-spi@vger.kernel.org,
        linux-i2c@vger.kernel.org, lakshmiy@us.ibm.com, robh@kernel.org,
        krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
        andrew@codeconstruct.com.au
References: <20240425213701.655540-1-eajames@linux.ibm.com>
 <20240425213701.655540-9-eajames@linux.ibm.com>
 <5822e000-01d3-442c-bb52-04fab87cb3da@kernel.org>
Content-Language: en-US
From: Eddie James <eajames@linux.ibm.com>
In-Reply-To: <5822e000-01d3-442c-bb52-04fab87cb3da@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0


On 4/26/24 01:25, Krzysztof Kozlowski wrote:
> On 25/04/2024 23:36, Eddie James wrote:
>> Switch to yaml for the AST2600 FSI master documentation.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>>   .../fsi/aspeed,ast2600-fsi-master.yaml        | 72 +++++++++++++++++++
>>   .../bindings/fsi/fsi-master-aspeed.txt        | 36 ----------
>>   2 files changed, 72 insertions(+), 36 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
>>
>> diff --git a/Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml b/Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml
>> new file mode 100644
>> index 000000000000..f053e3e1d259
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml
>> @@ -0,0 +1,72 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Aspeed FSI master
>> +
>> +maintainers:
>> +  - Eddie James <eajames@linux.ibm.com>
>> +
>> +description:
>> +  The AST2600 and later contain two identical FSI masters. They share a
>> +  clock and have a separate interrupt line and output pins.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - "aspeed,ast2600-fsi-master"
>> +      - "aspeed,ast2700-fsi-master"
> This wasn't tested. No quotes. Do you see any other example like this?


Strangely this passes make dt_binding_check for me... And Rob's bot 
didn't seem to catch it either. Just an oversight, I'll fix it.


>
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  cfam-reset-gpios:
>> +    maxItems: 1
>> +    description:
>> +      Output GPIO pin for CFAM reset
>> +
>> +  fsi-routing-gpios:
>> +    maxItems: 1
>> +    description:
>> +      Output GPIO pin for setting the FSI mux (internal or cabled)
>> +
>> +  fsi-mux-gpios:
>> +    maxItems: 1
>> +    description:
>> +      Input GPIO pin for detecting the desired FSI mux state
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +allOf:
>> +  - $ref: fsi-controller.yaml#
> This goes after required:


Ack.


>
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - interrupts
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/ast2600-clock.h>
>> +    #include <dt-bindings/gpio/aspeed-gpio.h>
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    fsi-master@1e79b000 {
>> +        compatible = "aspeed,ast2600-fsi-master";
>> +        reg = <0x1e79b000 0x94>;
>> +        interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&pinctrl_fsi1_default>;
>> +        clocks = <&syscon ASPEED_CLK_GATE_FSICLK>;
>> +        fsi-routing-gpios = <&gpio0 ASPEED_GPIO(Q, 7) GPIO_ACTIVE_HIGH>;
>> +        fsi-mux-gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_HIGH>;
>> +        cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
> No children?


Ack, I'll add one.


>
>
> Best regards,
> Krzysztof
>