Received-SPF: pass (google.com: domain of linux-kernel+bounces-160283-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <ZbFd5TZ_pi7q3hso@casper.infradead.org> <94713e86-30a8-4828-959d-bd95800149e4@rasmusvillemoes.dk>
In-Reply-To: <94713e86-30a8-4828-959d-bd95800149e4@rasmusvillemoes.dk>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 26 Apr 2024 17:27:08 +0200
Message-ID: <CAMuHMdUp3fOkAttk2FKJTh5svaiMwgu4JZ8utPeHghU4TQLE-w@mail.gmail.com>
Subject: Re: [RFC] Printing numbers in SI units
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Matthew Wilcox <willy@infradead.org>, Petr Mladek <pmladek@suse.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, 
	Sergey Senozhatsky <senozhatsky@chromium.org>, Randy Dunlap <rdunlap@infradead.org>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Rasmus,

On Wed, Jan 24, 2024 at 11:43=E2=80=AFPM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
> On 24/01/2024 19.58, Matthew Wilcox wrote:
> > I was looking at hugetlbfs and it has several snippets of code like
> > this:
> >
> >         string_get_size(huge_page_size(h), 1, STRING_UNITS_2, buf, 32);
> >         pr_warn("HugeTLB: allocating %u of page size %s failed node%d. =
 Only allocated %lu hugepages.\n",
> >                 h->max_huge_pages_node[nid], buf, nid, i);
> >
> > That's not terribly ergonomic, so I wondered if I could do better.
> > Unfortunately, I decided to do it using the SPECIAL flag which GCC
> > warns about.  But I've written the code now, so I'm sending it out in
> > case anybody has a better idea for how to incorporate it.
>
> Well, something that gcc will warn about with Wformat isn't gonna fly,
> obviously. But my man page also mentions ' as a possible flag for d
> conversions:
>
>        '      For decimal conversion (i, d, u, f, F, g, G) the output is
> to be grouped with thousands'
>               grouping characters if the locale information indicates any=
.

> Obviously, our printf wouldn't implement that, [...]

Why not? ;-)

Old Gmail-white-space-damaged patch below, which I wrote when I got
fed up with meticulously counting zeros in GHz-range clock
frequencies...

Author: Geert Uytterhoeven <geert+renesas@glider.be>
Date:   Thu Aug 11 13:52:46 2016 +0200

    lib/vsprintf.c: Add support for thousands' grouping

    Use an underscore as the grouping character.

    TODO:
      - Documentation
      - Self test
      - Do we want to use this in /sys/kernel/debug/clk/clk_summary ?
        RFC patch, compatibility was already broken by commit
        e55a839a7a1c561b ("clk: add clock protection mechanism to clk
        core")

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    ---
    Originally I wanted to use grouping by 4 for octal and hexadecimal
    numbers.  Unfortunately gcc prints a warning when using the grouping
    character with octal and hexadecimal numbers:

        warning: ''' flag used with '%x' gnu_printf format [-Wformat=3D]
        warning: ''' flag used with '%o' gnu_printf format [-Wformat=3D]

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index f4a8bfacb70befbc..51e516cf4cc68156 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -414,6 +414,9 @@ int num_to_str(char *buf, int size, unsigned long
long num, unsigned int width)
 #define ZEROPAD        16              /* pad with zero, must be 16
=3D=3D '0' - ' ' */
 #define SMALL  32              /* use lowercase in hex (must be 32 =3D=3D =
0x20) */
 #define SPECIAL        64              /* prefix hex with "0x", octal
with "0" */
+#define GROUP  128             /* thousands' grouping */
+// warning: ''' flag used with '%x' gnu_printf format [-Wformat=3D]
+// warning: ''' flag used with '%o' gnu_printf format [-Wformat=3D]

 static_assert(SIGN =3D=3D 1);
 static_assert(ZEROPAD =3D=3D ('0' - ' '));
@@ -462,7 +465,7 @@ char *number(char *buf, char *end, unsigned long long n=
um,
        char sign;
        char locase;
        int need_pfx =3D ((spec.flags & SPECIAL) && spec.base !=3D 10);
-       int i;
+       int i, j;
        bool is_zero =3D num =3D=3D 0LL;
        int field_width =3D spec.field_width;
        int precision =3D spec.precision;
@@ -511,6 +514,11 @@ char *number(char *buf, char *end, unsigned long long =
num,
                i =3D put_dec(tmp, num) - tmp;
        }

+       /* take into account grouping characters */
+       j =3D i;
+       if (spec.flags & GROUP)
+               i +=3D (j - 1) / 3;
+
        /* printing 100 using %2d gives "100", not "00" */
        if (i > precision)
                precision =3D i;
@@ -559,10 +567,16 @@ char *number(char *buf, char *end, unsigned long long=
 num,
                ++buf;
        }
        /* actual digits of result */
-       while (--i >=3D 0) {
+       while (--j >=3D 0) {
                if (buf < end)
-                       *buf =3D tmp[i];
+                       *buf =3D tmp[j];
                ++buf;
+               if ((spec.flags & GROUP) && j && !(j % 3)) {
+                       if (buf < end)
+                               // FIXME '\''
+                               *buf =3D '_';
+                       ++buf;
+               }
        }
        /* trailing space padding */
        while (--field_width >=3D 0) {
@@ -2567,6 +2581,7 @@ int format_decode(const char *fmt, struct
printf_spec *spec)
                case ' ': spec->flags |=3D SPACE;   break;
                case '#': spec->flags |=3D SPECIAL; break;
                case '0': spec->flags |=3D ZEROPAD; break;
+               case '\'': spec->flags |=3D GROUP;  break;
                default:  found =3D false;
                }

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds