Received-SPF: pass (google.com: domain of linux-kernel+bounces-160335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Samuel Holland <samuel@sholland.org>, linux-leds@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
 linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>
Subject:
 Re: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify
 the code
Date: Fri, 26 Apr 2024 17:55:22 +0200
Message-ID: <8403927.NyiUUSuA9g@jernej-laptop>
In-Reply-To: <ZivMCljzog7z_SgZ@smile.fi.intel.com>
References:
 <20240426152515.872917-1-andriy.shevchenko@linux.intel.com>
 <3557566.iIbC2pHGDl@jernej-laptop> <ZivMCljzog7z_SgZ@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Dne petek, 26. april 2024 ob 17:45:14 GMT +2 je Andy Shevchenko napisal(a):
> On Fri, Apr 26, 2024 at 05:37:42PM +0200, Jernej =C5=A0krabec wrote:
> > Dne petek, 26. april 2024 ob 17:25:15 GMT +2 je Andy Shevchenko napisal=
(a):
>=20
> ...
>=20
> > > +		return dev_err_probe(dev, i, "Bad pixel format '%s'\n", format);
> >=20
> > I know that old code used dev_err_probe() without reason, but could you=
 change
> > it to ordinary dev_err()?
>=20
> First of all, it's out of scope of _this_ patch.
>=20
> > dev_err_probe() is useful only when return code could be -EPROBE_DEFER.
>=20
> This is simply not true. We are trying to have a uniform output in ->prob=
e()
> and even documentation for dev_err_probe() was changed long time ago to
> encourage using it for non deferred probe cases.
>=20
> > This is clearly not the case here.
>=20
> Is it a problem?

Sorry, I missed added note for non -EPROBE_DEFER cases.

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej