Received-SPF: pass (google.com: domain of linux-kernel+bounces-160389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Apr 2024 17:36:51 +0100
From: Conor Dooley <conor@kernel.org>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
Cc: linux-kernel@vger.kernel.org, jic23@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh@kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH 1/7] dt-bindings: iio: imu: Add ADIS16501 compatibles
Message-ID: <20240426-chemo-ensnare-9246b013bd6e@spud>
References: <20240426135339.185602-1-ramona.bolboaca13@gmail.com>
 <20240426135339.185602-2-ramona.bolboaca13@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="8EakgkyhqOY7eHK0"
Content-Disposition: inline
In-Reply-To: <20240426135339.185602-2-ramona.bolboaca13@gmail.com>


--8EakgkyhqOY7eHK0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 04:53:33PM +0300, Ramona Gradinariu wrote:
> Add ADIS16501 compatible. Similarly to other ADIS1650X devices,
> ADIS16501 supports sync-mode values [0,2].

To avoid me having to check the driver patch, you should point out what
makes this device different from the existing drivers and therefore
justify not having a fallback compatible.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>=20
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml=
 b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> index 9b7ad609f7db..db52e7063116 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> @@ -30,6 +30,7 @@ properties:
>        - adi,adis16467-2
>        - adi,adis16467-3
>        - adi,adis16500
> +      - adi,adis16501
>        - adi,adis16505-1
>        - adi,adis16505-2
>        - adi,adis16505-3
> @@ -90,6 +91,7 @@ allOf:
>            contains:
>              enum:
>                - adi,adis16500
> +              - adi,adis16501
>                - adi,adis16505-1
>                - adi,adis16505-2
>                - adi,adis16505-3
> --=20
> 2.34.1
>

--8EakgkyhqOY7eHK0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZivYIgAKCRB4tDGHoIJi
0gbhAP9Ow4Olsjl4OA8MQjIEcoPxjHZum2CxoDhfP4mJfs/b2QEAg9fdL8bgnNPa
opBNQaaVGT60lupc8+vpfUdB3SWOAwc=
=OQ6q
-----END PGP SIGNATURE-----

--8EakgkyhqOY7eHK0--