Received-SPF: pass (google.com: domain of linux-kernel+bounces-160392-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 26 Apr 2024 17:38:13 +0100
From: Conor Dooley <conor@kernel.org>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
Cc: linux-kernel@vger.kernel.org, jic23@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh@kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH 6/7] dt-bindings: iio: imu: Add ADIS1657X family devices
 compatibles
Message-ID: <20240426-museum-sanitary-b3dd62191b99@spud>
References: <20240426135339.185602-1-ramona.bolboaca13@gmail.com>
 <20240426135339.185602-7-ramona.bolboaca13@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="rnxiZPdD0LG8bJTm"
Content-Disposition: inline
In-Reply-To: <20240426135339.185602-7-ramona.bolboaca13@gmail.com>


--rnxiZPdD0LG8bJTm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 04:53:38PM +0300, Ramona Gradinariu wrote:
> Add ADIS1657X family devices compatibles and specify the according
> maximum SPI baudrate.
> Similarly to other ADIS1650X devices, ADIS1657X supports sync-mode
> values [0,2].
>=20
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---
>  .../bindings/iio/imu/adi,adis16475.yaml       | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml=
 b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> index db52e7063116..9d185f7bfdcb 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> @@ -37,6 +37,12 @@ properties:
>        - adi,adis16507-1
>        - adi,adis16507-2
>        - adi,adis16507-3
> +      - adi,adis16575-2
> +      - adi,adis16575-3
> +      - adi,adis16576-2
> +      - adi,adis16576-3
> +      - adi,adis16577-2
> +      - adi,adis16577-3

I'm not checking all of the structs for these ones against eachother,
please explain why fallback compatible are not suitable.

Thanks,
Conor.

> =20
>    reg:
>      maxItems: 1
> @@ -98,6 +104,12 @@ allOf:
>                - adi,adis16507-1
>                - adi,adis16507-2
>                - adi,adis16507-3
> +              - adi,adis16575-2
> +              - adi,adis16575-3
> +              - adi,adis16576-2
> +              - adi,adis16576-3
> +              - adi,adis16577-2
> +              - adi,adis16577-3
> =20
>      then:
>        properties:
> @@ -114,6 +126,23 @@ allOf:
>        dependencies:
>          adi,sync-mode: [ clocks ]
> =20
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adis16575-2
> +              - adi,adis16575-3
> +              - adi,adis16576-2
> +              - adi,adis16576-3
> +              - adi,adis16577-2
> +              - adi,adis16577-3
> +
> +    then:
> +      properties:
> +        spi-max-frequency:
> +          maximum: 15000000
> +
>  unevaluatedProperties: false
> =20
>  examples:
> --=20
> 2.34.1
>=20

--rnxiZPdD0LG8bJTm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZivYdQAKCRB4tDGHoIJi
0p4yAPwPb/81Q1NSAN/X2c3n9FKJGnGEQJzfDTgBp192eJfvYQD7B3LGSK50dfTT
tvUIg3/Cly+rUJ28rhowym1FqAlkUwQ=
=FWbY
-----END PGP SIGNATURE-----

--rnxiZPdD0LG8bJTm--