Received-SPF: pass (google.com: domain of linux-kernel+bounces-160409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 26 Apr 2024 19:50:41 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	Konstantin Taranov <kotaranov@microsoft.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Long Li <longli@microsoft.com>,
	Ajay Sharma <sharmaajay@microsoft.com>
Subject: Re: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error
Message-ID: <ZivbYdt2HxDpMxC5@smile.fi.intel.com>
References: <20240423204258.3669706-1-andriy.shevchenko@linux.intel.com>
 <20240426163719.GA334984@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426163719.GA334984@nvidia.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 26, 2024 at 01:37:19PM -0300, Jason Gunthorpe wrote:
> On Tue, Apr 23, 2024 at 11:42:58PM +0300, Andy Shevchenko wrote:
> > The compilation with CONFIG_WERROR=y is broken:
> > 
> > .../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > 	if (!upper_ndev) {
> > 	    ^~~~~~~~~~~
> > 
> > Fix this by assigning the ret to -ENODEV in respective condition.
> > 
> > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/infiniband/hw/mana/device.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> This was fixed in

Hmm... The below patch had been sent _after_ mine. What's wrong with mine patch?

> commit f88320b698ad099a2f742adfb9f87177bfffe0c5
> Author: Konstantin Taranov <kotaranov@microsoft.com>
> Date:   Tue Apr 23 07:15:51 2024 -0700
> 
>     RDMA/mana_ib: Fix missing ret value

-- 
With Best Regards,
Andy Shevchenko