Received-SPF: pass (google.com: domain of linux-kernel+bounces-160436-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 26 Apr 2024 20:00:42 +0300
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Konstantin Taranov <kotaranov@linux.microsoft.com>,
	kotaranov@microsoft.com, sharmaajay@microsoft.com,
	longli@microsoft.com, leon@kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: fix missing ret value
Message-ID: <ZivduvnNzGnoAXAs@smile.fi.intel.com>
References: <1713881751-21621-1-git-send-email-kotaranov@linux.microsoft.com>
 <20240423150315.GA891022@nvidia.com>
 <Zivb7qs4gSywzVsL@smile.fi.intel.com>
 <20240426165815.GA2876951@dev-arch.thelio-3990X>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426165815.GA2876951@dev-arch.thelio-3990X>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 26, 2024 at 09:58:15AM -0700, Nathan Chancellor wrote:
> On Fri, Apr 26, 2024 at 07:53:02PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 23, 2024 at 12:03:15PM -0300, Jason Gunthorpe wrote:
> > > On Tue, Apr 23, 2024 at 07:15:51AM -0700, Konstantin Taranov wrote:
> > > > From: Konstantin Taranov <kotaranov@microsoft.com>
> > > > 
> > > > Set ret to -ENODEV when netdev_master_upper_dev_get_rcu
> > > > returns NULL.
> > > > 
> > > > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > > > Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> > > > ---
> > > >  drivers/infiniband/hw/mana/device.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > 
> > > Applied to for-next, thanks
> > 
> > So, what's wrong with my patch that had been sent _before_ this one?
> 
> Was it?
> 
> This patch:
> 
>   $ date -d 'Tue, 23 Apr 2024 07:15:51 -0700' -u
>   Tue Apr 23 02:15:51 PM UTC 2024
> 
> Your patch: https://lore.kernel.org/20240423204258.3669706-1-andriy.shevchenko@linux.intel.com/
> 
>   $ date -d 'Tue, 23 Apr 2024 23:42:58 +0300' -u
>   Tue Apr 23 08:42:58 PM UTC 2024
> 
> Seems like this one beat yours by six hours?

Repeating myself from another thread:

"""
Oh, my... Sorry, I missed PM, it was mine sent after that one!
I guess time for weekend.
"""

Sorry for the noise and have a nice weekend!

-- 
With Best Regards,
Andy Shevchenko