Received-SPF: pass (google.com: domain of linux-kernel+bounces-160437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 26 Apr 2024 18:01:18 +0100
From: Conor Dooley <conor@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-i2c@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Subject: Re: [PATCH v3 2/2] hwmon: pmbus: adm1275: add adm1281 support
Message-ID: <20240426-emoticon-exemplary-a79b0dfad5ce@spud>
References: <20240425070948.25788-1-jose.sanbuenaventura@analog.com>
 <20240425070948.25788-3-jose.sanbuenaventura@analog.com>
 <1a2e6020-77d8-4299-87b0-e2b16dfb3f86@roeck-us.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9/RvDkW+gaTrqeL4"
Content-Disposition: inline
In-Reply-To: <1a2e6020-77d8-4299-87b0-e2b16dfb3f86@roeck-us.net>


--9/RvDkW+gaTrqeL4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 25, 2024 at 10:52:03AM -0700, Guenter Roeck wrote:
> On 4/25/24 00:09, Jose Ramon San Buenaventura wrote:
> > Adding support for adm1281 which is similar to adm1275
> >=20
> > Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog=
=2Ecom>
>=20
> Patch is fine, but we'll need to wait for Conor's feedback
> regarding the compatible fallback before I can apply it.

Oh, I didn't realise you were waiting for me. I had deleted the thread
=66rom my queue given I had already acked the patch.

I'm not really a fan of the warn when IDs don't match thing though,
seems a bit unhelpful, unless you've running into scenarios where the
firmware tells you there's a device present but actually there's some
other incompatible one.

--9/RvDkW+gaTrqeL4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZivd3gAKCRB4tDGHoIJi
0uOHAQDF/BG9lN3nyIl9W0/P2KzprBUXsidylhLqT8n+BzFF8AEA8vJTMALLy6Z/
86Tq3mLatq8NbadfKD2NiXTyTe0pDwU=
=1cJT
-----END PGP SIGNATURE-----

--9/RvDkW+gaTrqeL4--