Received: by 2002:ab2:1c04:0:b0:1f7:53ba:1ebe with SMTP id f4csp112900lqg; Fri, 26 Apr 2024 10:07:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUy7eqjWMVBeJ5pZQksRjNwTeyDCtLB04i8LcamQkBH77V9n9V/iw2AQHQcdF7dNX9G1NNWqZebD7UMY+ahfdfydWKSwuTRinGYEhBSsA== X-Google-Smtp-Source: AGHT+IEujMUMIk9b9cQSMAADWC+wv1fJNHmriPWAi2dzvUkUpO8x2xVa6mRRM4aQvGPXkPXLXgID X-Received: by 2002:a05:6512:3aa:b0:518:f8a6:9f3c with SMTP id v10-20020a05651203aa00b00518f8a69f3cmr2039821lfp.58.1714151246865; Fri, 26 Apr 2024 10:07:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714151246; cv=pass; d=google.com; s=arc-20160816; b=o+TbTArgYman54fxcB2emURp7polCP0Ai6V9CytQxHU3LwYQ1zZCGv0n+qziS3ppIE VNoB92ciYZa52SdwqIdWDHk3Zx9YVzyYnXmrubjhylTOEuBWWavjDM1dzV9vbHBA2jVl 6Mc9GARuOWIsHXKuePczDkMHGHDF/TSeUkLcT7BUQQoiCfvO4wYvgJeKttWBx4pG7Snj VNAaqTSl5h10WNXHKBSjn/xqUrSCwLnEhMJJ+Vzv+eMfTJLAnqrLGncgBt3vRqvEw1c5 6PYYZ5xz4QHdqesTCDdnJStC2+u3I2ftx72mUmQT64ZB0i+S8syxp7gyeRqoMsqNqX2U pW8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=CqVzl+Ig/V/VbNISnYJ7WYTL4D5PMvZ8JXFwI44NV+k=; fh=m0/nD9YvhypOI99cGwdLUv53lHSg2xdeQHRhlHsYxsM=; b=GCWFZjR6l7GmRDFlBBykkAZtXTYNx1ip/YnkG01S/0j+F/841R9eAgNF/V7gr8XAUt ZdYvhJp07voh3YdXEQP6ZHf/Km7aqlqtxumTLL2yrvgu+nePfiNQH6bT604YJf7Mx7Xu ZapV5cBRmaB1bb2InJjZ2lPcu3e8BLPUOPC98eJBUWhdigl9057v7OoStL75SSOEvwoU EUWErzkIg/80PcR1TJtVpVRBmsGGDqAVJD+omVcJlHTzEILXFHQAzJ886FmcYAVHaM9M +Z7uVwy4nsHvftnufLSiRXIqd5KcLTx/fj9YucEAUekHakHx2Pe9tc0XYWpwYKucAN44 nbGQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lHRm1Gg1; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-160447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160447-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m4-20020a509984000000b00571d32787b4si10168374edb.213.2024.04.26.10.07.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 10:07:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lHRm1Gg1; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-160447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160447-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E01A51F212A9 for ; Fri, 26 Apr 2024 17:07:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26C5415ECF1; Fri, 26 Apr 2024 17:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lHRm1Gg1" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A5615B57B; Fri, 26 Apr 2024 17:06:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714151220; cv=none; b=cdXzDBdzW5XHOPIoMzMm3sGovdVHSH2CdeR5ET+c/hN9/YUHFLjE8CEOJVVgbtVg8UBxXwRmAjxbuF3hcyTUxFDQlWQNTBDHeDvULphVgwDyUphHhWeveWNXKdj6n+G0E3rbo1udN5GveCGzL2NfVi2n6ze9seni/q6RHj6fRDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714151220; c=relaxed/simple; bh=FZ+j+p6hRx9M1MSAAujq4y2aF4Gs0UKvJ2UzLkCl2GY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X6G3jeYO345omiDOsJMe421/4XMGYgRDQtDPQnH28tTrRBy8JrCZBhatym4pHtsUqaGnwh5XP8cUoDoaiPWsg4Ivpt9mJ3UgKXfz99ikDHjs8v8uPM/FE3q5s8nN6ncJZDL0pu+CrISdb82gdfCVPaviNM1meN33mKs5ZPvadbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lHRm1Gg1; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714151218; x=1745687218; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FZ+j+p6hRx9M1MSAAujq4y2aF4Gs0UKvJ2UzLkCl2GY=; b=lHRm1Gg1MbArX8zey/fKLH2KSxlSPy6cqNxicULdjFIk8rLqXj5ZYLVm XLbA0+uFfl5Ic2eANmTvSf227ti+QMMaCFdJ+bIlzRL0KtBSLD7aKsIrW KQ1JIIXknD8K1nPUDJ9JXf+Ecp6uXMnzlmQ7vAzBqwmswdedc9XM0P4AH s9p8VQdvAXXDlxrSNajvFlheiQWmz2tqNa2ECaHVJzqsJDWgwgmh950Se NHkPpSJncI6N0pQWFTtvcpShHuDdaWxr+IcBNh6bS+bF5RJlzNjtDbf4K kitRQjCUHA6y9km9AX/8FwglnA58s/B9PexSt7DL0I6QCHq41MZqCG2XX g==; X-CSE-ConnectionGUID: MeMhENLaSG6vKb6DLETqzw== X-CSE-MsgGUID: wBj23quGS+iYkE1TZhOz6g== X-IronPort-AV: E=McAfee;i="6600,9927,11056"; a="21043099" X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="21043099" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 10:06:58 -0700 X-CSE-ConnectionGUID: HQwBPN+eQa+NLVSMFQy0Gw== X-CSE-MsgGUID: kgAjj70BTACdtQ+LdSlSoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="25355194" Received: from bbaran1x-mobl.amr.corp.intel.com (HELO [10.209.80.70]) ([10.209.80.70]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 10:06:58 -0700 Message-ID: <30415ed3-a05a-454d-9077-c8674617f291@intel.com> Date: Fri, 26 Apr 2024 10:06:56 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/1] x86/sgx: Explicitly give up the CPU in EDMM's ioctl() to avoid softlockup To: Bojun Zhu , linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, jarkko@kernel.org, dave.hansen@linux.intel.com Cc: reinette.chatre@intel.com, =?UTF-8?B?5YiY5Y+MKOi9qeWxuSk=?= References: <20240426141823.112366-1-zhubojun.zbj@antgroup.com> <20240426141823.112366-2-zhubojun.zbj@antgroup.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240426141823.112366-2-zhubojun.zbj@antgroup.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/26/24 07:18, Bojun Zhu wrote: > for (c = 0 ; c < modp->length; c += PAGE_SIZE) { > + if (sgx_check_signal_and_resched()) { > + if (!c) > + ret = -ERESTARTSYS; > + > + goto out; > + } This construct is rather fugly. Let's not perpetuate it, please. Why not do: int ret = -ERESTARTSYS; ... for (c = 0 ; c < modp->length; c += PAGE_SIZE) { if (sgx_check_signal_and_resched()) goto out; Then, voila, when c==0 on the first run through the loop, you'll get a ret=-ERESTARTSYS. But honestly, it seems kinda silly to annotate all these loops with explicit cond_resched()s. I'd much rather do this once and, for instance, just wrap the enclave locks: - mutex_lock(&encl->lock); + sgx_lock_enclave(encl); and then have the lock function do the rescheds. I assume that mutex_lock() isn't doing this generically for performance reasons. But we don't care in SGX land and can just resched to our heart's content.