Received-SPF: pass (google.com: domain of linux-kernel+bounces-160431-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 26 Apr 2024 13:58:08 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	Konstantin Taranov <kotaranov@microsoft.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Long Li <longli@microsoft.com>,
	Ajay Sharma <sharmaajay@microsoft.com>
Subject: Re: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error
Message-ID: <20240426165808.GA941030@nvidia.com>
References: <20240423204258.3669706-1-andriy.shevchenko@linux.intel.com>
 <20240426163719.GA334984@nvidia.com>
 <ZivbYdt2HxDpMxC5@smile.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZivbYdt2HxDpMxC5@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2vPOHyhMKQDO1VtalKtmrZqeohm1OXjQ1/3oYLNF6YWZYHcIL/1gmWSIXBlw?=
 =?us-ascii?Q?78kPlhFZNCye160pwolJT9Y18C83p8lHwYGTsY52uULms1pAH+zfj81r65zK?=
 =?us-ascii?Q?0k1w0hRTyDbArktffpetHeO5wKxiEecX/DjUaIn63gTCPUfeIdPmS49zaoSm?=
 =?us-ascii?Q?V77Gp6nHh706IdB85H4tOzSZjGFhcjKzI9Sf/Gw5CETt/t2Si0PcT+UR7W9I?=
 =?us-ascii?Q?4SojPo6889zLf5f5oB2Kr0pSezHGbCqseYKXuvlu+muDynsifVfSoXdmmcW2?=
 =?us-ascii?Q?q11Ar9M1ECrWUFjiIN/wgoWtkMK3EKwiv7rVNwOzbBJswJpnOsd/OXMvwgfr?=
 =?us-ascii?Q?Ujrt8+OZ3STc0x5qdtn1+Vwfa/qGYPGmTFrLG6XACMHRa8hCq5fTtLSDUJfG?=
 =?us-ascii?Q?qzY0MRHusEgQ7j2dozpCF73sWPuSq6kyJ0J5FCJOLEQpDRdb7eYEQeL/+2K4?=
 =?us-ascii?Q?U1At3zdnCsElp3rZUucRQmflnMauzu8xvHXTTCfaK12dqX98hmh1ajAuWB+/?=
 =?us-ascii?Q?RDvDgik9KJNVZd9dX9Ha4Jr4DNWpMyJ/snZvy+Nw24mbK7GZunZ9RLiAUxSw?=
 =?us-ascii?Q?bbPpPGqv0OraZgXVbn2CNL4rpnxWMgiBscqb+wqPIcMD42yJlxwwJY4vVBgR?=
 =?us-ascii?Q?bWZ4aa8rBIxnxwdtmALWs+wSGGycNKLY6G3vUZsRbHIvwzzAQCEjWgPKpSEE?=
 =?us-ascii?Q?m/rszsXgDqlp8w8pw5B9CPfZLQPHp6j1vjqvgF42hCtYAoygbSyc8Jky8qrq?=
 =?us-ascii?Q?BrWxz6mz3OpHNJT3Ldj/SMogReB5eb2gSxzx66kwnNp/h+K78x53sbZDSjS9?=
 =?us-ascii?Q?z+HuNmjrEYwtps0CxIQ10HaKSN6ymNcEn91dNSPkxv2o+0SQzYds6Sgio2eE?=
 =?us-ascii?Q?agmvRDRPR4UJuZwmjGTK8Bn6O9qzmYwOjdflxUAfNgYSjknkto/XNU8mnepE?=
 =?us-ascii?Q?omnSejQnXqQgW/8UtJ+CSLTjNyzocJlrz9dPDgeZq7hAQ3BEh2dB0rHNV0Lq?=
 =?us-ascii?Q?V4m5OSRVvwLUmlKQnAil/PZBMOxzULylt5cQtUNCZofZYwM5iICMCqiWzEHN?=
 =?us-ascii?Q?EjVcuOBmr2vtZkimhKttrSTgv/pwPtdPrQKPgqconSooiFB7hCSIwwiVIsWE?=
 =?us-ascii?Q?U11oHhlc4HbmYtGSiL51mLIi+0MtDkJMRfbcDWjVyT4FB5KI2cO2HxVZdeUK?=
 =?us-ascii?Q?Q1gcaBhwfuSL2amzrH8BMlnRLKd7ZHnT1KRATO9BAZCtalC1vqfsINeryLPs?=
 =?us-ascii?Q?JINUCZ2Pj2MfgkUL8SqVIGT524IMNnRGuPaw5T4H6i3Kn75VXUxWMih+YtUl?=
 =?us-ascii?Q?KcPsDe2xuAZ8zc8Pwk501TkihRfUxFR6yHyHK5XmgDENrYs+x2iLp4rXcSul?=
 =?us-ascii?Q?mJ9UEIhZrSiuA1+WfuaQ0rGwxDDZhbw4dKMP+fdZZzBlzf6b+XmUqgAlW74y?=
 =?us-ascii?Q?7jqEbFJJnEuXvghM/RpnsD8PMs1WFT+u44VbFAPSFRsl3jsL31yTAi6buFKK?=
 =?us-ascii?Q?Dk2II45Ns4cbKlzzkn5AcBXEO04Xa6JYzkkXHHXk262pMw4s/ds8H3hTWulb?=
 =?us-ascii?Q?fLYgoda/WOmGBNY5Ccw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcd7b3c2-b069-4bc2-fc11-08dc66120d03
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 16:58:09.4713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: my0Tu1nQXZawcq+gl0zhGzl8CQ6JVPIhv/C+06C+0wrj1CJXDjximqrJFn3m30dg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6181

On Fri, Apr 26, 2024 at 07:50:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 26, 2024 at 01:37:19PM -0300, Jason Gunthorpe wrote:
> > On Tue, Apr 23, 2024 at 11:42:58PM +0300, Andy Shevchenko wrote:
> > > The compilation with CONFIG_WERROR=y is broken:
> > > 
> > > .../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > > 	if (!upper_ndev) {
> > > 	    ^~~~~~~~~~~
> > > 
> > > Fix this by assigning the ret to -ENODEV in respective condition.
> > > 
> > > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  drivers/infiniband/hw/mana/device.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > This was fixed in
> 
> Hmm... The below patch had been sent _after_ mine. What's wrong with
> mine patch?

It wasn't

Your's:
Date: Tue, 23 Apr 2024 23:42:58 +0300	[thread overview]

Konstantin's:
Date: Tue, 23 Apr 2024 07:15:51 -0700	[thread overview]

He beat you by 6 hours, which is why I took his, yours didn't exist at
the time I took it.

Jason