Received-SPF: pass (google.com: domain of linux-kernel+bounces-160511-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 26 Apr 2024 10:40:53 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Lukas Wunner <lukas@wunner.de>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>
CC: "Rafael J. Wysocki" <rafael@kernel.org>, <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>, Dan Williams <dan.j.williams@intel.com>
Subject: RE: [PATCH] sysfs: Allow bin_attributes to be added to groups
Message-ID: <662be72549aaf_db82d294c7@dwillia2-xfh.jf.intel.com.notmuch>
References: <e140f6bf8dc99c24cc387f7ac3c7908c8830587f.1714030457.git.lukas@wunner.de>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e140f6bf8dc99c24cc387f7ac3c7908c8830587f.1714030457.git.lukas@wunner.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?wIgJQZB3bUFvwz0ChlUJ8EvcFp3qvVte+faOS+7b+JGyBB2fWEQU2iTh8B?=
 =?iso-8859-1?Q?12aIG8pkTjYgAOEW6pn+2sjbzrWYUHwfAWfNZAEecmMXfZ4+9dldF5EvxY?=
 =?iso-8859-1?Q?Cj9/n6z24XqYfzryVhbmZFsL+NIluTilPlaWZWiHmR65BCKRLI/jHF2NZ4?=
 =?iso-8859-1?Q?+SI5o5obgTPQHLYOplv8iNUN1Y617t+0ETOKLShVYfyrXWYyTC/SAhSwK2?=
 =?iso-8859-1?Q?/o+3bjbrCsSucojIXN2z5Y+qEkJajsNw+UgsRiz0/SVqqnhK4z/+E0vfMj?=
 =?iso-8859-1?Q?gHI3vWTIjtrUDRtyNAtYUi6DXapEgZewTAHpLn42kRcBOwlhB6kYF+ih4Y?=
 =?iso-8859-1?Q?K5ltxlZV9E9kQNkfXMajkE3PSM3D/bxhynDJFa2Uxj7/iQRu4I/vN35tLO?=
 =?iso-8859-1?Q?N1L+Y6URle2SL/5+LC/UG2nnls0Hx7fCsY/pxDofF+izeAFDDBL8hjeOSJ?=
 =?iso-8859-1?Q?p9S34gimfW+xWx5+ggn1L5FTSWADlU2yEl8mPZ1F+i0I3FdsWFneWOm50V?=
 =?iso-8859-1?Q?hT/Sbn4lMV/yGlNWxc0Io1HK3v6dRb7b1DoyawccnumrPXCoh17Cg2X2Y1?=
 =?iso-8859-1?Q?+6+4MZj1XeZE0W7sI3dorzgr/Ea2Nr0GWa/NPvCZKAbQJx+jKIW2Z2wmeo?=
 =?iso-8859-1?Q?3ARzC08Wn6zvDnRBm9CCpymPosiFWGPp50oXAuVh+0T11umM6youjDRsdl?=
 =?iso-8859-1?Q?MBCjchiunRyTpiEUp4FAmkogLvE9KTrkhjfE9cM5efkge8qMifFAlgES7D?=
 =?iso-8859-1?Q?O8oMwCDP4Xd3upT6DkQ/onb4RbxsaJrC7AAvBYSZnyxFpmwbxKSqZo2SHY?=
 =?iso-8859-1?Q?j///9BFKy4McnjQXWHWUjp9z092QplAXlXRithbT5NGV8KV59m0L3pmvWw?=
 =?iso-8859-1?Q?h4BNLTWCKhf+RAokD8L4Q9sqzS196L8YgXiOLORfg0sT2n+rr7mfq35XNn?=
 =?iso-8859-1?Q?f0Wz2+Fe5dtxLbYsBpu32qvY0CZO/frMcO3q4JwL+v9ztrSxsqMNpqvZ9M?=
 =?iso-8859-1?Q?HuKXnGN4AVhLvVbrH/KWCRjtBigqXziZxaZkHIDxspzZGbhVcfrrlbc/j6?=
 =?iso-8859-1?Q?uyEEYDioGeQLHOVHlc4HKVqJbrehBZs7a25AiaqZnDJnYqKqLKCHRJHuj2?=
 =?iso-8859-1?Q?pqvHDoVivrjQBbCW/b4gLZLBOU6I++2gU+xwFfDdfvvnbgbd5e008WcJi3?=
 =?iso-8859-1?Q?mhJbHTJPuITlCFQ+ABqumiYLR00XMqyQZ3DH0sMVS8Z+7z3F4HA+XxlLdO?=
 =?iso-8859-1?Q?Bh9OwxI1Z8rnASJs7eR9ZYosns73NpzjVz28llPpQiJYo8EBhONYzoeomY?=
 =?iso-8859-1?Q?LIpULYd5nJDX6Dadqspj+6G6kQYa58L7U1VGILKx3JDgomE6Jvzbc22azN?=
 =?iso-8859-1?Q?gsVN9jZ0XC8PxIm9yr5vhGmsSJexqdQhGxBhFNCSuhbb3y/xLOwsLcTOT9?=
 =?iso-8859-1?Q?tSGr/1CsnYW1kcEFotOZ+wnT18DvPViSsdVZpnOXszVMYFIu4Gw0He9n8h?=
 =?iso-8859-1?Q?d7IZml6yTI/0xjKTgobpGRqXSxYpqibxJCgjQQkMho/u827ny+rF5QlTb1?=
 =?iso-8859-1?Q?EkfdzpvONSoEtm+THiICYvMEkA3Wq5KCY9HX3ea6YS8OTPmYeUGhLox8p2?=
 =?iso-8859-1?Q?1XVZ+v6l2fJ6djMfUcLHHXGLBKbx1NI5lTuxEyBd4Ra0fqKa48C7ED7w?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba7a0f48-43ae-4216-20d0-08dc661806d7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 17:40:56.0868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sTEZmxhOChJeKrkNtJgwbf+0grDL6przJRzjp16JKLvUybEIeVQ4Up+cs9cGJylXVev8PHYowEfxK0k16UpxMoioKSUQU7FstaWiIMAMcPA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5056
X-OriginatorOrg: intel.com

Lukas Wunner wrote:
> Commit dfa87c824a9a ("sysfs: allow attributes to be added to groups")
> introduced dynamic addition of sysfs attributes to groups.
> 
> Allow the same for bin_attributes, in support of a forthcoming commit
> which adds various bin_attributes every time a PCI device is
> authenticated.
> 
> Addition of bin_attributes to groups differs from regular attributes in
> that different kernfs_ops are selected by sysfs_add_bin_file_mode_ns()
> vis-?-vis sysfs_add_file_mode_ns().
> 
> So call either of those two functions from sysfs_add_file_to_group()
> based on an additional boolean parameter and add two wrapper functions,
> one for bin_attributes and another for regular attributes.
> 
> Removal of bin_attributes from groups does not require a differentiation
> for bin_attributes and can use the same code path as regular attributes.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> ---
> Submitting this ahead of my PCI device authentication v2 patches.
> Not sure if the patch is acceptable without an accompanying user,
> but even if it's not, perhaps someone has early review feedback
> or wants to provide an Acked-by?  Thank you!

On the one hand it makes sense from a symmetry perspective, on the other
hand the expectation and the infrastructure for dynamic sysfs visibilty
has increased since 2007.

That is why I would like to see the use case to understand why a
dynamically added a bin_attribute is needed compared with a statically
defined attribute with dynamic visibility.