Received-SPF: pass (google.com: domain of linux-kernel+bounces-160533-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i1719461a:Fastmail
Date: Fri, 26 Apr 2024 12:05:36 -0600
From: Lyndon Sanche <lsanche@lyndeno.ca>
Subject: Re: [PATCH v2] platform/x86: dell-laptop: Implement platform_profile
To: Ilpo =?iso-8859-1?q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: mario.limonciello@amd.com, pali@kernel.org, W_Armin@gmx.de,
	srinivas.pandruvada@linux.intel.com, Matthew Garrett <mjg59@srcf.ucam.org>,
	Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>, Dell.Client.Kernel@dell.com
Message-Id: <C9AKCS.CKJOJZMUUKSZ1@lyndeno.ca>
In-Reply-To: <e861d645-0908-d68b-87ad-0b8b8999fc06@linux.intel.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
	<20240426020448.10862-1-lsanche@lyndeno.ca>
	<e861d645-0908-d68b-87ad-0b8b8999fc06@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable


On Fri, Apr 26 2024 at 12:23:00 PM +03:00:00, Ilpo J=E4rvinen=20
<ilpo.jarvinen@linux.intel.com> wrote:
> On Thu, 25 Apr 2024, Lyndon Sanche wrote:
>=20
>>  Some Dell laptops support configuration of preset
>>  fan modes through smbios tables.
>>=20
>>  If the platform supports these fan modes, set up
>>  platform_profile to change these modes. If not
>>  supported, skip enabling platform_profile.
>>=20
>>  Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
>>  ---
>=20
> Two things:
> - You're missing patch version history (put it below the --- line)
> - Don't send updates so soon, give people time to comment. When I saw=20
> v1
>   for the first time, you had already posted the next version.
>=20
>>  +void thermal_cleanup(void)
>>  +{
>>  +	platform_profile_remove();
>>  +	kfree(thermal_handler);
>>  +}
>>  +
>>   static struct led_classdev mute_led_cdev =3D {
>>   	.name =3D "platform::mute",
>>   	.max_brightness =3D 1,
>>  @@ -2238,6 +2452,12 @@ static int __init dell_init(void)
>>   		goto fail_rfkill;
>>   	}
>>=20
>>  +	// Do not fail module if thermal modes not supported,
>>  +	// just skip
>>  +	ret =3D thermal_init();
>>  +	if (ret)
>>  +		goto fail_thermal;
>>  +
>>   	if (quirks && quirks->touchpad_led)
>>   		touchpad_led_init(&platform_device->dev);
>>=20
>>  @@ -2317,6 +2537,8 @@ static int __init dell_init(void)
>>   		led_classdev_unregister(&mute_led_cdev);
>>   fail_led:
>>   	dell_cleanup_rfkill();
>>  +fail_thermal:
>>  +	thermal_cleanup();
>>   fail_rfkill:
>>   	platform_device_del(platform_device);
>>   fail_platform_device2:
>>  @@ -2344,6 +2566,7 @@ static void __exit dell_exit(void)
>>   		platform_device_unregister(platform_device);
>>   		platform_driver_unregister(&platform_driver);
>>   	}
>>  +	thermal_cleanup();
>=20
> This is still not right, you'll still platform_profile_remove() even=20
> if
> the init side call failed.
>=20
> --
>  i.
>=20

Thank you for your feedback. I agree with your comments and will add=20
more checking on whether certain cleanup actions are necessary.

Lyndon