Received: by 2002:ab2:1c04:0:b0:1f7:53ba:1ebe with SMTP id f4csp153283lqg; Fri, 26 Apr 2024 11:16:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVh9iUo3jeQgTlX7BY87XQS3LRPZAOQihTk80lvFudK7AteqCQ7etzBjPtbmtu9t7/QB3FZAmzix/SRp5JnC+j9WdzJ/t28ZgO6HNIrAw== X-Google-Smtp-Source: AGHT+IHFFjYItD+lgx0NwxIwmftlvvoxV3r6GYK9lXIHgUBgopS/kbrm96zxdubbT86/n5e1hnAw X-Received: by 2002:ac2:5d31:0:b0:519:e878:9385 with SMTP id i17-20020ac25d31000000b00519e8789385mr2957304lfb.18.1714155374390; Fri, 26 Apr 2024 11:16:14 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t16-20020a17090605d000b00a519e1b3663si10992374ejt.2.2024.04.26.11.16.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 11:16:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=vAneWE1V; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-160556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160556-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1EADD1F23780 for ; Fri, 26 Apr 2024 18:16:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ABD3016E88D; Fri, 26 Apr 2024 18:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vAneWE1V" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB420160787; Fri, 26 Apr 2024 18:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714155322; cv=none; b=abpRVx1RbbHA4OXKjrM8pRvwcgwcg+PwG6ayzAUcGJ0EG0u/ieFKbYwCElx1s3Dk8kPsQrF0TLyIWDpz7i8Zg4uSAuYSB+9fC3OvWRQxMx8HkAvk3fvt/NccJA7fq9FMyeioySufU4TB5oqrLH/wRUpRQXkB3nwKVR+ljVEljlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714155322; c=relaxed/simple; bh=NBx5WI2xYCiixhHhcbYtdw3q11V3t5DrEOf3fzBzeMg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YNFvjx+qY2v9OCVBrDH9AluWDfol9dgQkUeKyhyNC7OfiBJshqxIjQyef3o5+fwP+4BYOQIHZuwh602+7Ej1suL9pX4MH70vN9nsIELBB5QtEbm4nkgrSgngb0n+2vE/qPhcAWplS4kJ2BB6NQ7IUTVbE5YFBt+yOjh5dYxZXHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vAneWE1V; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 882F5C113CD; Fri, 26 Apr 2024 18:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714155322; bh=NBx5WI2xYCiixhHhcbYtdw3q11V3t5DrEOf3fzBzeMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vAneWE1VrIVOKs/7nEtKGA2bRfxvJsvb6VfsGcnzDg9e5gzYQdHqUR+Y+VKr2DyKQ tn8MQvajhs6bc25GvyEUetum7btnsbu/ZvpwixQuhn7VN88NmcuAG2lYSHqaJlkfci A/O1YL6jWLHi/bjS/17O9cW/Ulbik/VBU2q4EVPW+pAnRtPQQF5Sbq623v2cXrsGgH 4i9Wm+hDNoUlqbmXjup/SfQ2OtCZAPcJoyk8FdRs3yyFQB9HUdGi/YK/yMOd+T1FnK mS9E/YZYGu1zFKDvomJjjk318agOt9daawhzjOPdgFbesSy7In8ZSmbDeWCcKhGHDH xE2Bb/KQOzclw== Date: Fri, 26 Apr 2024 19:15:17 +0100 From: Simon Horman To: Jijie Shao Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jiri@resnulli.us, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, chenhao418@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 net 6/7] net: hns3: fix port vlan filter not disabled issue Message-ID: <20240426181517.GB516117@kernel.org> References: <20240426100045.1631295-1-shaojijie@huawei.com> <20240426100045.1631295-7-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240426100045.1631295-7-shaojijie@huawei.com> On Fri, Apr 26, 2024 at 06:00:44PM +0800, Jijie Shao wrote: > From: Yonglong Liu > > According to hardware limitation, for device support modify > VLAN filter state but not support bypass port VLAN filter, > it should always disable the port VLAN filter. but the driver > enables port VLAN filter when initializing, if there is no > VLAN(except VLAN 0) id added, the driver will disable it > in service task. In most time, it works fine. But there is > a time window before the service task shceduled and net device > being registered. So if user adds VLAN at this time, the driver > will not update the VLAN filter state, and the port VLAN filter > remains enabled. > > To fix the problem, if support modify VLAN filter state but not > support bypass port VLAN filter, set the port vlan filter to "off". > > Fixes: 184cd221a863 ("net: hns3: disable port VLAN filter when support function level VLAN filter control") > Fixes: 2ba306627f59 ("net: hns3: add support for modify VLAN filter state") For the record, my reading of this is: 184cd221a863 is a fix for 2ba306627f59. Both were included in v5.14. This patch fixes 184cd221a863 and in turn 2ba306627f59. > Signed-off-by: Yonglong Liu > Signed-off-by: Jijie Shao Reviewed-by: Simon Horman ..