Received: by 2002:ab2:1c04:0:b0:1f7:53ba:1ebe with SMTP id f4csp154462lqg; Fri, 26 Apr 2024 11:18:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU3gdEEo8nogk2KKD02Ii3hZ3LZIQpPQkmoS7qLf0BAD0BAKEs4DoKbvvIUy3usKhev9GVjc+hia2mA6Ggro1ZNPWEDVWMEzOBuhsZySA== X-Google-Smtp-Source: AGHT+IH/qj5kT0bjJBkXQYHBm8gGeOhgRg4rrKaRtNS54G8SiFjJWXJ2DdyvxiiIfl991gQnKqJO X-Received: by 2002:a17:906:3102:b0:a55:aebd:17d5 with SMTP id 2-20020a170906310200b00a55aebd17d5mr2325885ejx.2.1714155500781; Fri, 26 Apr 2024 11:18:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714155500; cv=pass; d=google.com; s=arc-20160816; b=NpEM+bhojxVbAWaOiiJKobs7uIsHgEaIWEcaRzasnSi2Jf1ZL+O63bO9ZSeXP0R5Xk wGmtivliZuHt5h/oJgHlW8/X2SBca4ntaz5U4B/5pbXOdX3vrXiFNoQI8ULiDiteAs0k iiG4Uy3nJpI8aGPxgDALqiPz6PQfleuwLhnrNV3u33K9NJ2HrQ0MZRX/HHz+Pb2FBXPg mIyH6UIz0y9xPHhGH8aLGkyvmtcRa44FFJgYIDXSq7IAN0i4e/i79IDjmoWo76sd0p00 bwttYZ6BpMNwL4JnXPqs71hGMrl+bXhFSQ3/QGAQGm5dFj49snEaBRdQr8BunXMdYnya pvEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=scI06n3r0oxha4J8FtQmpFEaYl4EwJiQYGgGjaGKA/k=; fh=hGVRZCkMh8UxaAX2Rwhsw9G34dp4nkP7sPLCebdVTk8=; b=1FrYP5GFe7ck9zTq5tJjjjdPJY3Q58rrPMv4lNnX2v0XZ2e06v8HWTiSuwc5tVPAll z4DA9r/1ghcT5TFaHMYn3s+v7LBI4DqLe/fG+OZxHoSNoBoxycEoV5o6HNL3NYdlNu5y TiBcT9zycYdm9TmbpWmgLrE0ywC3qsQSRjV38rtoobguUXZJhnrSGsEbpiAQW8CJpc7r H4HBqJIMkWmGTsiDi7KV2VVsj8fseg3s/rxEosexLWWcNlSHuV9OkrkS5KJEZXWf4C63 4ZI/6VzM3P23MRWqfbh9xFK5ODYHs8o2JyMrsA3lluw/xbgExfZ86YIYuM3dDh7q2UI/ jwFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=hTuCAS+Y; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-160559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160559-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p11-20020a170906b20b00b00a55621dad0csi10895268ejz.173.2024.04.26.11.18.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 11:18:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=hTuCAS+Y; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-160559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160559-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 726B91F2489B for ; Fri, 26 Apr 2024 18:18:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55E4616DEDA; Fri, 26 Apr 2024 18:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="hTuCAS+Y" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3862230C; Fri, 26 Apr 2024 18:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714155492; cv=none; b=fxt4YNT4yDJi7+De9o5anB1NP+iEea9hrLpCHfwhrgc63fIW+FKehkZxLJ3vPYqF4NvitBouEW6QAqNJfYKvP8e/IRxfkw8B7DRQ5LzR/tVScMryXbYO7u4o5jH2Y3lLUaTjgDENF+fX94sYAe7L2bQcyepo2LMa5gJvl9/yAhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714155492; c=relaxed/simple; bh=O9XSwSp510W6WOyoXgJ1ualqTyt8QGmV84/lupByN3g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZxdEza9oVYQFWb90III5+k/ZIVCKJjUwILQc26ceFDPCOFBwriMef9LfdTLPWsIW8m23LyGPOd4bU+CrbE2DpBRYaF0LQS3DwDiJ3nGEWt8+fOcldJ5anVb73Y08FY9vtCD2rgLfU19eDJ96rc9H9+wWOQVu0MAH+0GN5Iib0FY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=hTuCAS+Y; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=scI06n3r0oxha4J8FtQmpFEaYl4EwJiQYGgGjaGKA/k=; b=hTuCAS+YH9+3J1v1Ga2yWSCxzh au6G1rD9EPaUKXdsK9GlhcOVjkt0L60gLi9Ui4U4SL/nthYiGr0nYo0yl8meyBRzGRe2G6GNaiaEF vap4duzUFl2pUk9Dj0UCX21lW+utyuFAZMPg0u3GsSzyg3xrSkww0pEAlBgP/P+uz6kc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s0Q95-00E65B-Oi; Fri, 26 Apr 2024 20:18:03 +0200 Date: Fri, 26 Apr 2024 20:18:03 +0200 From: Andrew Lunn To: Josua Mayer Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Herring , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Message-ID: References: <20240414-cn9130-som-v3-0-350a67d44e0a@solid-run.com> <20240414-cn9130-som-v3-4-350a67d44e0a@solid-run.com> <3958052d-fc09-4c4c-a9e3-4923871cff44@solid-run.com> <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com> > >> Colours are similar to RJ45 connectors (yellow, green), > >> and are intended for the same purpose: link, activity. > > For the switch LEDs you used label = "LED10"; Does the silk screen > > have similar numbers for these LEDs? > Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled > individually on the silk screen. > > The SolidWAN SFP leds are dual-colour leds with 3 terminals: > anode to 3.3V, 2x cathode to gpio-controlled transistors. > They are labeled on the silk-screen as "LED9", "LED10". > > Duplicate labels are not great, is there a better way? > old style "LED9:green" e.g. ...? So you have copper LEDs and SFP LEDs, each with the same silk screen label? Maybe put 'copper' and 'sfp' as a prefix into the label? Andrew