Received-SPF: pass (google.com: domain of linux-kernel+bounces-160613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
 "Matthew Wilcox (Oracle)" <willy@infradead.org>,
 Yang Shi <shy828301@gmail.com>, Ryan Roberts <ryan.roberts@arm.com>,
 Barry Song <21cnbao@gmail.com>, Lance Yang <ioworker0@gmail.com>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] mm/rmap: do not add fully unmapped large folio to
 deferred split list
Date: Fri, 26 Apr 2024 15:20:42 -0400
Message-ID: <CB058583-C99A-4897-B3AE-11C56D6E3A59@nvidia.com>
In-Reply-To: <e274ad3b-bbeb-49b0-81bf-24fd33106f05@redhat.com>
References: <20240426190253.541419-1-zi.yan@sent.com>
 <e274ad3b-bbeb-49b0-81bf-24fd33106f05@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_EE57114B-2562-4B4A-9940-991392B220CD_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9qcEQ+OKbvsKNl97xBujVaMer39OX9cyK5EHVm4HCIagwyE3L/hlg1Wh8FBo?=
 =?us-ascii?Q?P+XpR/4hgM45fNTSs0EAbrhuCKCJCoiktiwqi2bXHx+3Ri5OuU22Qiw42dN3?=
 =?us-ascii?Q?aWFTKxJFnvInzcNzCQNAqp7P4xmRnavsy8nEEJKPM9pjJ7EpHKV7bY18WOAl?=
 =?us-ascii?Q?F3+8t1gftrYXDvQ9PElVb7k4Ahb5JGc/t34UN4DAxSQ6OajL9TACeBTEqCyG?=
 =?us-ascii?Q?oB6RECcNmXbvBOR6YxxGphgslOL3hM1K0jIWoqMa7W975yHHLo0/rv+DBtgg?=
 =?us-ascii?Q?eAIJoCyDCZgI/JKJUjfMOWrEC7lEU4EINq3+S96CNlqIqHC5aJf5sRdwDR1b?=
 =?us-ascii?Q?DU7vZCu7O2rrvYUf8Ktim+in2dulBFDatcfKCdy8gnY5BGkN/ARtHa8UqcR+?=
 =?us-ascii?Q?yVe+0T+eCBeyZCfKNcWVZMwLJnfdoM/hlTcuk5s2NY3AuYP77Z1IeOErrjlI?=
 =?us-ascii?Q?iU9yEhrt4oUaiWOkmN7iee+UD0bjkzwLrVaq0KsaU4AstsOGou++ytG8ykNS?=
 =?us-ascii?Q?M4C4qwl3j38oag63yx9Qm1SGksXIwOwISJb04i/WZFepDSdHHCCylHOM7hqt?=
 =?us-ascii?Q?Z+KCioz6oZxjhkoMQL9Z6oZkdmoY419FVZPgBSii7Z8QlXr2gdnApQEAeO5M?=
 =?us-ascii?Q?OBniKdOC6ubYVRQ0wZAupCaDf5QIQOee4EiK1fcbt7GWh7mjlgIXfHyQNgl8?=
 =?us-ascii?Q?osJZYkqZ/ehUg+NlpaF2hd9sB/NDlx7ABXZryR8jHqnoLaqEw7JiaozRCsLm?=
 =?us-ascii?Q?5dO+bnV13nDVQOrbgJY7HVYN2hpI06WhD7TIeAHoFPuYCy6QL/J3uv84LBWR?=
 =?us-ascii?Q?RYrbOtB2ZHe0pqFgBFvQSOSo7IrSnkj058IuTisGI2NLKkAJODuFV5Q29hGs?=
 =?us-ascii?Q?2e7JX53eQkzLqu5xBnwwi9mQP/OLEKc5F9okC2lI4E6HV3/cTYBOaO54i1h/?=
 =?us-ascii?Q?hrAQH/rFEnK2e5aighwtXk7ac6F0Ur0Cn8NPbNetr7EEPGg0Q6ze+aFzJXV5?=
 =?us-ascii?Q?yCF7aZk0Hoe+8wt8jfrjN2taz5YHU23GqhK7x+WdeDcwaIgNhvxTmmfKL+1L?=
 =?us-ascii?Q?sb7AFphK+vzxqaxfCkbtjYBxAE41GCh0PDVXh3HNHaCD0vuNWFR6RODmauTj?=
 =?us-ascii?Q?aN4FYqHrciMknRJ67tGqVC5uKGDnjz+QibH5QJKUjWtsBcA49vpwpNbwKcT0?=
 =?us-ascii?Q?WbX6wd4F7UsMLh0ecaEO8OvZb5drSA91uOQKuidyPEu65h5AtjwfXxQoHyDU?=
 =?us-ascii?Q?iokaE+GVQm8cCJdUOQbrbJRx9kJQVG06RQMhQI1bNOccrukh0FbmumMmsXGB?=
 =?us-ascii?Q?/oQ9lqrLIQrdSWDkRTjV8DNaLbdJ1fXoGmpmZyecA03tIzH87I2fyNtyq0hX?=
 =?us-ascii?Q?/luBjTlVPOuBlKBOz6QznFDXcaAP2Ba2CuZpFUWESi9zyKHrIDUlH4dxmA5d?=
 =?us-ascii?Q?M7Xbs/z5bLP0qAHgb6RWDaTQ8EIvY1BNkjuP8l6JXSv3OMrfdVCHpFuclDpS?=
 =?us-ascii?Q?pTiC3QcTfYUCVxM4U3oVn8vgrAbdwlYXoNPmjZGmdCP1uIpFMW/EXYQLSzcV?=
 =?us-ascii?Q?cGJVzLOmGd4GeoImKhw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aae879f5-6ca6-4847-91f1-08dc6625f854
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 19:20:44.7079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BuqptVtWJFPxOeZgAcKFUVVhYWLwPiXyUc4uQq5ckKJ++V4M36Qr+eOMGQVJp1z3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7565

--=_MailMate_EE57114B-2562-4B4A-9940-991392B220CD_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 26 Apr 2024, at 15:08, David Hildenbrand wrote:

> On 26.04.24 21:02, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> In __folio_remove_rmap(), a large folio is added to deferred split lis=
t
>> if any page in a folio loses its final mapping. But it is possible tha=
t
>> the folio is fully unmapped and adding it to deferred split list is
>> unnecessary.
>>
>> For PMD-mapped THPs, that was not really an issue, because removing th=
e
>> last PMD mapping in the absence of PTE mappings would not have added t=
he
>> folio to the deferred split queue.
>>
>> However, for PTE-mapped THPs, which are now more prominent due to mTHP=
,
>> they are always added to the deferred split queue. One side effect
>> is that the THP_DEFERRED_SPLIT_PAGE stat for a PTE-mapped folio can be=

>> unintentionally increased, making it look like there are many partiall=
y
>> mapped folios -- although the whole folio is fully unmapped stepwise.
>>
>> Core-mm now tries batch-unmapping consecutive PTEs of PTE-mapped THPs
>> where possible starting from commit b06dc281aa99 ("mm/rmap: introduce
>> folio_remove_rmap_[pte|ptes|pmd]()"). When it happens, a whole PTE-map=
ped
>> folio is unmapped in one go and can avoid being added to deferred spli=
t
>> list, reducing the THP_DEFERRED_SPLIT_PAGE noise. But there will still=
 be
>> noise when we cannot batch-unmap a complete PTE-mapped folio in one go=

>> -- or where this type of batching is not implemented yet, e.g., migrat=
ion.
>>
>> To avoid the unnecessary addition, folio->_nr_pages_mapped is checked
>> to tell if the whole folio is unmapped. If the folio is already on
>> deferred split list, it will be skipped, too.
>>
>> Note: commit 98046944a159 ("mm: huge_memory: add the missing
>> folio_test_pmd_mappable() for THP split statistics") tried to exclude
>> mTHP deferred split stats from THP_DEFERRED_SPLIT_PAGE, but it does no=
t
>> fix the above issue. A fully unmapped PTE-mapped order-9 THP was still=

>> added to deferred split list and counted as THP_DEFERRED_SPLIT_PAGE,
>> since nr is 512 (non zero), level is RMAP_LEVEL_PTE, and inside
>> deferred_split_folio() the order-9 folio is folio_test_pmd_mappable().=

>>
>> Suggested-by: David Hildenbrand <david@redhat.com>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>   mm/rmap.c | 12 +++++++++---
>>   1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/rmap.c b/mm/rmap.c
>> index 2608c40dffad..a9bd64ebdd9a 100644
>> --- a/mm/rmap.c
>> +++ b/mm/rmap.c
>> @@ -1495,6 +1495,7 @@ static __always_inline void __folio_remove_rmap(=
struct folio *folio,
>>   {
>>   	atomic_t *mapped =3D &folio->_nr_pages_mapped;
>>   	int last, nr =3D 0, nr_pmdmapped =3D 0;
>> +	bool partially_mapped =3D false;
>>   	enum node_stat_item idx;
>>    	__folio_rmap_sanity_checks(folio, page, nr_pages, level);
>> @@ -1515,6 +1516,8 @@ static __always_inline void __folio_remove_rmap(=
struct folio *folio,
>>   					nr++;
>>   			}
>>   		} while (page++, --nr_pages > 0);
>> +
>> +		partially_mapped =3D !!nr && !!atomic_read(mapped);
>
> Nit: The && should remove the need for both !!.

My impression was that !! is needed to convert from int to bool and I do
find "!!int && !!int" use in the kernel. If this is unnecessary, Andrew
can apply the fixup below. I can send a new version if it is really neede=
d.

diff --git a/mm/rmap.c b/mm/rmap.c
index a9bd64ebdd9a..c1fd5828409b 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1517,7 +1517,7 @@ static __always_inline void __folio_remove_rmap(str=
uct folio *folio,
                        }
                } while (page++, --nr_pages > 0);

-               partially_mapped =3D !!nr && !!atomic_read(mapped);
+               partially_mapped =3D nr && atomic_read(mapped);
                break;
        case RMAP_LEVEL_PMD:
                atomic_dec(&folio->_large_mapcount);

>
> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks.

--
Best Regards,
Yan, Zi

--=_MailMate_EE57114B-2562-4B4A-9940-991392B220CD_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYr/ooPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUDzUQAKT74HoLO9D1m0dcLjfukKG+28CxtXoLNVx+
6bw1Heqji1uE5Q9A9RaUbEMH2032/M5UE/0iOIJTqAuNpq/a7HKLwzpKipcedinG
pM/4Qc4SaulRatXA/+nTgRfrcMnm8gYIBpehh0rV7gLrWmaK13DLEt4t1SCfvZmA
RwzQzYyWhEDGfO5dV4lz66FeASCAAHb990gJ466WP4XYAJN1eHoPZvKzzcyCJUIf
n5tBEDwpmnE5vbodipdve/Ll9e3YitOBpx/QVL1l+K6FELkh7YISu57eJgFeYHJx
6jr8qt25NsZQEqgVhqLSp7inCOFso+1oFSHGK5YWGZ7ft3a/hv6OZPQmsm5qkisX
KoytMf8lzT8Uou2e22Eibym0PHbbkFktKNb13FHDGif6+KXm+AAdr0R6q0zlOnv/
4ELZNLx5Ey1nlJcBEFtcpojVHwwoyMY/xqalhkG0wfm77+uyPAgooNl/3MyJ6Trj
KuLCo9voBmhSnFXHoSHTfEtH9JzgYQJdyEM2FfjBo2A4332y1bWEyXDYqXAjp/Ys
w1MiuBn9UdHV/TD/2GCizVLkdj69GSBaPeykuC+lciFGlJ4s3dYFxnx+i80zpdcA
c+/gmAroNdwCk0jFtRCWmSsaaeSAzbUyv8tAtky8fDChYfW1f8gcB9DJFRrTwkRO
38FNRrjh
=qYAz
-----END PGP SIGNATURE-----

--=_MailMate_EE57114B-2562-4B4A-9940-991392B220CD_=--