Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp16393lqa; Fri, 26 Apr 2024 12:47:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX5mUJvaalu366qlDIdibwVjAGg8a1/CofRaibipTVGgCgi1hPlsKc6nYRbpGDEciMH9icL3t3c/3YDwPzFgEcT7NVNorg13PkcWlLKow== X-Google-Smtp-Source: AGHT+IGir9N26tg9RoVSOfsgCSz2mWECBjqisbXCF6nFP5UurQW7xufyhNytWuHJkOOMKx6xfw7q X-Received: by 2002:a17:906:81d5:b0:a58:871f:8eb0 with SMTP id e21-20020a17090681d500b00a58871f8eb0mr2696390ejx.7.1714160842580; Fri, 26 Apr 2024 12:47:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714160842; cv=pass; d=google.com; s=arc-20160816; b=PaUVyqKsC3HJ4HkvyzMgy6yeGpLGTFUXkLxP4W971Sywja4avAa1/coKVYB5LmbJUV 8B5MG8S8degloHzI2P0zcwYkn3Il69DukZGcXTIW+MC66zwpOfUTkspHlj0cPu1OsQGc oQggP0Aqk21kRZvAqSy1upyAE2o/scIHHosyM5kohU7x2qf1RGiHQeXCR3m1Er/rVJ8b XwXTBn9q2+PILiVDVVG5gIK/nOmFs8gxwTe4VLngslQrjF9AH7e4nO7rTZ/bGp5R60i5 VZxXL8qPMzg16hZ1wCS2wDXw0Gq4KcInjBhcpkn3IlflljFygsZzKuDmd4/01vWO4ZbS TjKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=NU1KOUvcmFNcmmSQaGXwe7JtZDkq7ucg19frndE6tYA=; fh=g0WdHHenuBPCTc4DsYIqfbKTGl7a0ZiDP6oQTJaiTg4=; b=EwwEAZqbF6+ujRZDYpvxVzljGVVehB38Udcl8gDID2Y5E1MNVDMLGVj+Br9KNWPzqE sqgRjcwx6ALs6bhiWAwJ88dwY+Os+WczDubJ885o7crnmzzT13PWmf2Fn4F4mMDX9bmw NkQfp1WpYG0gN1QIFBgHML8PMl8ClV9s+ezN0ahoiHHnCDYF/2DvvqLcdpme0bE5Tzp5 xkCM0YMjaTjL8BAjla7xgTYoxMBqN7Q4X3Xr+RtZOYHnSEKOgX8ZfdNtz8IJSs99Nphd 4JOKPfBuYdNXa19H+UNU7BCDpvfy7hJWMQQS2v4ahD87ORHBrFvc5h9PW0O9CqkRbZpW widQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QMdP17QW; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-160627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160627-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lc1-20020a170906f90100b00a4666ecd61bsi11266918ejb.217.2024.04.26.12.47.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 12:47:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QMdP17QW; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-160627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160627-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 67F291F210E2 for ; Fri, 26 Apr 2024 19:47:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C31C5241E7; Fri, 26 Apr 2024 19:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QMdP17QW" Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8F201CAA4; Fri, 26 Apr 2024 19:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714160818; cv=none; b=pbMRx7vJVTl/OqO/SvzuYQQw4gwBbSIwj8hFQntoWcCYCis75RIpoqRV+eWtKqv3PgKVTkBv5KzrB2aPcYnP9Q5sGaqVimMT2iA1pj7N7fLecGaVWd0S9TreLMaejwpN42mMKtz5r0A6E4qbMoimcuQSqjQZxq6tIrlR/L6Goqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714160818; c=relaxed/simple; bh=nCSonnRajlX4+T7mFxC0msM5n38BW5/60VTp4xsIYfE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=nvjA2c2tn0p/APeKgy9HSzNVmgOP4YgWeHiqF8d58TUG+jz38/eyYELp8hF52mwOcenz2Wo3gUBAeRj298PEtZkgC0WRaNLT+OQEsggwBuATOtjnseepDrkBuScd2JpGLteToStazAianWMtKWsqkpNRzrNHE0UOjqvWHRqRA9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QMdP17QW; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5aa362cc2ccso1619963eaf.3; Fri, 26 Apr 2024 12:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714160816; x=1714765616; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=NU1KOUvcmFNcmmSQaGXwe7JtZDkq7ucg19frndE6tYA=; b=QMdP17QWodBD7wZAuFIXgrImUlmuCYOwDjDFh6Z1ujqf2gN/NlchkQ35U62W2vF+85 aMG2NJzLQmWZrdYbELjVsI/nr49BhaU6gQKa1ICwi3r/RfnAF8L980+yMH0LgfHZ5Nln Irf3TJOgHLpIhYGRue3ocMS0usQ94nhM4sSYOnp/m7Mxgh2sfnGXo5Sytp/kQIJV7BUQ e3j/H3oRZ8I3vZBJIP7VElcD5Ej3O0+HPHZn1rLManwZkdklW1NcuC9QO9ZF+iG5sDze cukodYxy0sv3jx/olz9z9O7XxMkwcRXXzrRznYf/QNS2kuoUj52u2RFgZXR6c4jKsASB iXtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714160816; x=1714765616; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NU1KOUvcmFNcmmSQaGXwe7JtZDkq7ucg19frndE6tYA=; b=NtqfQ2iJgW3T5Qucx8FMfFyngnzvsRG1lsOZx7CvJrSasDUVWWlwvJp27dQyrrQpT6 6SwKcB6kRYmI+Cg3GzMel8RFlbKMdZc8iMH9VYD+BoO26tesNYtMfFriCophA1ByNI9X kUFqXljRmUnvNxRqg+YcuMXWbE+OOuM9rpqkOxMWM+DN56QMd8h5wV87hZpDv/pJLgeW NMOWZPN6/mVtRoJkn6EugS4z45z23S7yxSIJ12NzEPVsfVrtx7Aif3oCznXIP8eT6Nmz T99kaKcPAKendb0s6dTJcHYyBG92qqRSfUsUpva0i+dzs+lSJSMjPici9zI3GE7M5AkT 18uA== X-Forwarded-Encrypted: i=1; AJvYcCXMpSlDgiD+Kg76UvQw5JfZSjah2fI6P5FEhPWimIidf8gKn/n0qpnZWb5wdkZv8LXCIKf3CuR9iFR+0mXWYf6hdZvep1ZuCo21ey7qg3+mSxD4Q6m6MKjB5k4AVNmQkG+fObn7uJ7D2ZYEBDS54krJRdk89Oyw0hBOmR90 X-Gm-Message-State: AOJu0YwWRxTRJel6Ippp32QQrh3PcdgU8khJEjC+feUmB5xr79tBN4Af nfdZlFUVsVVrLzX/CUkfC4aMPiDg18JiLjxVrWbICNo/FAEPEOqO X-Received: by 2002:a05:6358:d08b:b0:17f:89f2:5c18 with SMTP id jc11-20020a056358d08b00b0017f89f25c18mr3747152rwb.6.1714160815675; Fri, 26 Apr 2024 12:46:55 -0700 (PDT) Received: from [10.69.55.76] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id df25-20020a05622a0ed900b0043a5c00b59asm1437250qtb.36.2024.04.26.12.46.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 12:46:55 -0700 (PDT) Message-ID: <87cc6b80-3e8e-4c24-8007-4357f7180c28@gmail.com> Date: Fri, 26 Apr 2024 12:46:52 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 3/3] net: bcmgenet: synchronize UMAC_CMD access From: Doug Berger To: Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240425222721.2148899-1-opendmb@gmail.com> <20240425222721.2148899-4-opendmb@gmail.com> <07b4cb83-08db-449d-9d73-88e84fa570bd@broadcom.com> <50522abe-57d0-47df-9917-e0cd6848650f@gmail.com> Content-Language: en-US In-Reply-To: <50522abe-57d0-47df-9917-e0cd6848650f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/26/2024 12:43 PM, Doug Berger wrote: > At least a couple of callers could benefit from it. Thanks! Yes, adding unimac_rmw_locked() as a helper for some cases probably does make sense for net-next. -Doug