Received-SPF: pass (google.com: domain of linux-kernel+bounces-160625-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 26 Apr 2024 21:43:42 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Josua Mayer <josua@solid-run.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131
 solidwan board
Message-ID: <053fff95-4a7d-4d00-ad38-17ffe76a4525@lunn.ch>
References: <20240414-cn9130-som-v3-0-350a67d44e0a@solid-run.com>
 <20240414-cn9130-som-v3-4-350a67d44e0a@solid-run.com>
 <3958052d-fc09-4c4c-a9e3-4923871cff44@solid-run.com>
 <fd466583-3221-4b94-b66b-18840615fb71@lunn.ch>
 <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com>
 <d0426bb3-1f40-48ed-9032-6ffdce455cd4@lunn.ch>
 <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com>

On Fri, Apr 26, 2024 at 06:51:02PM +0000, Josua Mayer wrote:
> Am 26.04.24 um 20:18 schrieb Andrew Lunn:
> >>>> Colours are similar to RJ45 connectors (yellow, green),
> >>>> and are intended for the same purpose: link, activity.
> >>> For the switch LEDs you used label = "LED10"; Does the silk screen
> >>> have similar numbers for these LEDs?
> >> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled
> >> individually on the silk screen.
> >>
> >> The SolidWAN SFP leds are dual-colour leds with 3 terminals:
> >> anode to 3.3V, 2x cathode to gpio-controlled transistors.
> >> They are labeled on the silk-screen as "LED9", "LED10".
> >>
> >> Duplicate labels are not great, is there a better way?
> >> old style "LED9:green" e.g. ...?
> > So you have copper LEDs and SFP LEDs, each with the same silk screen
> > label? Maybe put 'copper' and 'sfp' as a prefix into the label?
> 
> No, not quite.
> 
> We have 2x SFP Connectors.
> On the bottom side of PCB immediately below each connector is
> a single LED (as in physical component), each with a silk-screen label.
> 
> "J28"/"SFP 0": "LED10"
> "J42"/"SFP 1": "LED9"
> 
> The problem is that these leds are each two leds in single-package,

Ah! Sorry, you clearly said they were dual-colour.

> which is why I put 4 led nodes in dts, two labeled "sfp-0",
> other two "sfp-1".
> But I don't think this duplication of label in dts is a good idea.

Agreed. Then i would use the colour as a postfix.

	Andrew