Received-SPF: pass (google.com: domain of linux-kernel+bounces-160364-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <13fe0f7c7da2cb6ce52ec34d4648e90e40f2fbc0.camel@linux.intel.com>
Subject: Re: [PATCH] platform/x86: dell-laptop: Implement platform_profile
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Lyndon Sanche <lsanche@lyndeno.ca>, Mario Limonciello
	 <mario.limonciello@amd.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>, Pali =?ISO-8859-1?Q?Roh=E1r?=
 <pali@kernel.org>, Hans de Goede <hdegoede@redhat.com>, Ilpo
 =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, 
 Dell.Client.Kernel@dell.com
Date: Fri, 26 Apr 2024 09:14:07 -0700
In-Reply-To: <24c7a9ea-7755-4270-a338-4701c8e262e2@app.fastmail.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
	 <a6009bed-aa34-4a3f-91f5-23937e915132@amd.com>
	 <24c7a9ea-7755-4270-a338-4701c8e262e2@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-04-25 at 14:24 -0600, Lyndon Sanche wrote:
> On Thu, Apr 25, 2024, at 2:07 PM, Mario Limonciello wrote:
> > + Srinivas
> >=20
> > On 4/25/2024 12:27, Lyndon Sanche wrote:
> > > Some Dell laptops support configuration of preset
> > > fan modes through smbios tables.
> > >=20
> > > If the platform supports these fan modes, set up
> > > platform_profile to change these modes. If not
> > > supported, skip enabling platform_profile.
> > >=20
> > > Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
> > > ---
> >=20
> > When you developed this was it using a Dell Intel or Dell AMD
> > system?
> >=20
> > If it was an Intel system, did you test it with thermald installed
> > and=20
> > active?
> >=20
> > I'm wondering how all this stuff jives with the stuff that thermald
> > does.=C2=A0 I don't know if they fight for any of the same "resources".
>=20
> Thank you for your response.
>=20
> I did my development and testing on a Dell Intel system. Specifically
> the XPS 15 9560 with i7-7700HQ.
>=20
> I do have thermald running, though I admit I am not really aware of
> what exactly it does, besides being related to thermals in some way.
>=20
> I normally set the thermal mode with Dell's smbios-thermal-ctl
> program. I am not too sure all the values that the bios configures on
> it's own depending on the provided mode, so I am not sure if thermald
> conflicts. But my understanding is that would be out of scope of this
> driver, since we are only telling the bios what we want at a high
> level.
>=20
> Lyndon
Can you share output of acpidump tool to me? I want to make sure if
there is some way the platform will bypass thermal table if you changed
to some profile.

Thanks,
Srinivas