Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp32005lqa; Fri, 26 Apr 2024 13:19:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWJIKscEEYb0yXEpxC4P93prutPLRFSIilsxwh29r4Y0aJdftvtcC0rS+d7XngoYwgtSuGDQn0va/OIIVNm+rXR1g573VJEj5TVvjgUDA== X-Google-Smtp-Source: AGHT+IGU9TTmXXTy8O5KpdO32wTUt0xhCs5BgeaRv6+QNmGlB9HXT/zEImE3UlZaNTgxIJ9cSvAA X-Received: by 2002:aa7:983c:0:b0:6f3:8aa5:829f with SMTP id q28-20020aa7983c000000b006f38aa5829fmr3774675pfl.33.1714162764955; Fri, 26 Apr 2024 13:19:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714162764; cv=pass; d=google.com; s=arc-20160816; b=JRiFR/VqkGjuZG+EVnC+gd5wEphqubGtD3m5TEm2TZlOALw/chaJRacCIIixQSUEYJ 3+iMgRIg3ChNOQXFeZooOOu1sngp/LIeeQoutHOxaw/eSt7c53X2o1ACUn46VQ8Npgrp pHfmG+gyMy+RatfwDbrkoiQnLCH5ZfZO51sGfMf0KsFfi08NV6ePZiMCmSV5s2gB9yMW Ia1UW+WINVwvSETQV1PxI3cJ5I7CnNfpXL5WSZpTQPpN3o9rfwxU5/k+peo4k5htBiyh 49sJsdjvg7WgrTYHFiNq/pdmnXsF7GdQOC3RoVZCtlsknYomAIea5Iq3HIxijSH6w9Qr pHzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=N90b3/SSxbLK/a2YSgJGW777fnEwBjaan+amMbxn+pM=; fh=DiDHl/F5SNH6UOSTJ8YrbrLP2foABQo/HGu0BSosMk8=; b=TO6oAQvUet5JTG5BOwuwkRbbyY+hF17r9/DolIRaVn1L/oLN3hpgtb/7ZLWjPw+0yT LZh24/eFsehFW3bCq9fHMxZn0C6MaWJOQUW4d1hEXSaeQMPtDCWoFzbIxMVSkAtr9mY3 lf2PSZXgfnsIfETngp2qHRajl1FAIj0aYgBWiflvTRgl/jtGHMICm2S/pvG7sprLjk1/ WLSRuMbtjq1K/Jd6dNa9Tjdyn84O1fEVpv3Dk4N0VwAFgHQzlE7/QRF5g0vGjO34qkGZ KnCD/B0HVK/E4BBAi1H69amyKuGyDG47hygXr0GpjCFP+GIOuJnuF8kJLzVn8Kaqyw8V hDoQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b="Wp0H7bO/"; arc=pass (i=1 dkim=pass dkdomain=linux.org.uk dmarc=pass fromdomain=zeniv.linux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-160662-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160662-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d30-20020a634f1e000000b005dc41265c15si16232815pgb.658.2024.04.26.13.19.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 13:19:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160662-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b="Wp0H7bO/"; arc=pass (i=1 dkim=pass dkdomain=linux.org.uk dmarc=pass fromdomain=zeniv.linux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-160662-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160662-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 51E262838A9 for ; Fri, 26 Apr 2024 20:19:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD42E241E1; Fri, 26 Apr 2024 20:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="Wp0H7bO/" Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0160208AF; Fri, 26 Apr 2024 20:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714162753; cv=none; b=T1LO8f9bFLiTB5bdQRBkQa18+uiUvLTnMN+mMNWQsvK1y9fVOWRzD3WfRbP6+STcMvWHGOVVDi6VKD/LAlQN0Xm8kD3KXW2qyU20hcPy8a9kOnOSFNrBwi6T1+RSEJNSW/ZjvtCo9WfinagS6vZKEdQ206FppzRWP+W41xO8X/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714162753; c=relaxed/simple; bh=6VdUJV20l4I0zrwsUBPpqBuj20IIVfh/k/cJj3StQ00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RH6NV9wR2h1k6SQc/lf9iEP8+Gy/aCq5F+EOjrmmDv10oTFMhWwwwpyqqtQBE6e7chgcMwBZh/Mted3N5ySwJlBQDPJPsgyLNng6GbMO3VWtG+h25oOiwvlVz9DRiglFOx9kHlmTSr76Xg1WZ4k0Q/AdqVIy3kGQ0F/7M7jfZec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=Wp0H7bO/; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N90b3/SSxbLK/a2YSgJGW777fnEwBjaan+amMbxn+pM=; b=Wp0H7bO/DEtI8f43tFDIxMMax3 wXthZokbrCCYVe2Sgom7cGaHFGTpfFDIDiWNvs3QsrRbJHyVuiHUrFHymToW3eIuRpGYJkX41SULU SDxRUHfroNxbfysEJqySWQvmh51CG3yEBG5qy+OZktOG4FETduammudLfKTJ4+WL2rN7+yvQlhcB0 XIXHk/VcBXihUdNnvc5ZSLChwK24CV0gE12Ckbwu595jh3YW6KxEsi4y5I39QtpG/D/6tsEcUJLIB OVkcWkEIXxUEzy1nPSy1SFxBYoGqASVywCyIYq6F4mPvY7jrIG1o9CQ7MsbivSljLnP1HRbtscsPS d7NSruqg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1s0S2A-005PJi-1D; Fri, 26 Apr 2024 20:19:02 +0000 Date: Fri, 26 Apr 2024 21:19:02 +0100 From: Al Viro To: I Hsin Cheng Cc: Eric Dumazet , davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH] tcp_bbr: replace lambda expression with bitwise operation for bit flip Message-ID: <20240426201902.GQ2118490@ZenIV> References: <20240426152011.37069-1-richard120310@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro On Sat, Apr 27, 2024 at 01:01:21AM +0800, I Hsin Cheng wrote: > I see, thanks for your explanation. > I thought the compilers behavior might alters due to different > architecture or different compilers. > So would you recommend on the proposed changes or we should stick to > the original implementation? > Personally I think my version or your proposed change are both more > understandable and elegant than the lambda expression. Out of curiosity, where do you see any lambda expressions in the entire thing?