Received-SPF: pass (google.com: domain of linux-kernel+bounces-160672-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 26 Apr 2024 17:34:59 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V3] perf scripts python: Add a script to run instances of
 perf script in parallel
Message-ID: <ZiwP85A_ROwL_xJN@x1>
References: <20240423133248.10206-1-adrian.hunter@intel.com>
 <ZihFYbdrnarNFWOd@tassilo>
 <ZikT69GIsijZajoI@x1>
 <ZiuiiFdPhJIrjI7k@x1>
 <1e2bee89-0a4a-42e3-9f81-bd7296cfb351@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1e2bee89-0a4a-42e3-9f81-bd7296cfb351@intel.com>

On Fri, Apr 26, 2024 at 06:24:12PM +0300, Adrian Hunter wrote:
> On 26/04/24 15:48, Arnaldo Carvalho de Melo wrote:
> >   +       python3 "${pp}" -o "${output2_dir}" --jobs 4 --verbose --per-cpu -- perf script -i "${perf_data}"
 
> Sorry, didn't have shellcheck installed!

Its a life saver, when I saw what it found I slapped myself in the face
for having applied that patch ;-(
 
> Looks good. The shellcheck page refers to bash for "${var:?}"
> but it is POSIX too.

Thanks for checking! We really need more build checks like that.

- Arnaldo