Received-SPF: pass (google.com: domain of linux-kernel+bounces-160719-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f128feb6-4be2-2f14-b4cb-8bf1d0908892@quicinc.com>
Date: Fri, 26 Apr 2024 14:55:09 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v20 09/41] ASoC: Add SOC USB APIs for adding an USB
 backend
Content-Language: en-US
To: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?=
	<amadeuszx.slawinski@linux.intel.com>,
        <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
        <perex@perex.cz>, <conor+dt@kernel.org>, <corbet@lwn.net>,
        <lgirdwood@gmail.com>, <andersson@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>,
        <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>,
        <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh@kernel.org>,
        <konrad.dybcio@linaro.org>
CC: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-sound@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <alsa-devel@alsa-project.org>
References: <20240425215125.29761-1-quic_wcheng@quicinc.com>
 <20240425215125.29761-10-quic_wcheng@quicinc.com>
 <b8ff8777-6bcb-4fd7-9480-231536d23759@linux.intel.com>
From: Wesley Cheng <quic_wcheng@quicinc.com>
In-Reply-To: <b8ff8777-6bcb-4fd7-9480-231536d23759@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi Amadeusz,

On 4/26/2024 6:25 AM, Amadeusz Sławiński wrote:
> On 4/25/2024 11:50 PM, Wesley Cheng wrote:
>> Some platforms may have support for offloading USB audio devices to a
>> dedicated audio DSP.  Introduce a set of APIs that allow for 
>> management of
>> USB sound card and PCM devices enumerated by the USB SND class driver.
>> This allows for the ASoC components to be aware of what USB devices are
>> available for offloading.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>> ---
> 
> (...)
> 
>> +const char *snd_soc_usb_get_components_tag(bool playback)
>> +{
>> +    if (playback)
>> +        return "usbplybkoffld: 1";
>> +    else
>> +        return "usbcapoffld: 1";
>> +}
>> +EXPORT_SYMBOL_GPL(snd_soc_usb_get_components_tag);
> 
> Is this used to expose some information to userspace?
> Can those be some more readable strings if so, like:
> usbplaybackoffload, usbcaptureoffload
> 

Sure we can make it a bit more complete.  Was trying to keep it short, 
but if the intention isn't clear on the tag, then we can keep the full form.

> (...)
> 
>> +
>> +    node = snd_soc_find_phandle(usbdev);
>> +    if (IS_ERR(node))
>> +        return -ENODEV;
>> +
>> +    ctx = snd_soc_find_usb_ctx(node);
>> +    of_node_put(node);
>> +    if (!ctx)
>> +        return -ENODEV;
> 
> Perhaps introduce some helper function, you do this 
> snd_soc_find_phandle() followed by snd_soc_find_usb_ctx() in few places...
> 

Will do.  Will make a helper and replace instances with this.

Thanks
Wesley Cheng