Received-SPF: pass (google.com: domain of linux-kernel+bounces-160722-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 26 Apr 2024 14:58:46 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, <linux-kernel@vger.kernel.org>,
	<x86@kernel.org>, <linux-coco@lists.linux.dev>, <svsm-devel@coconut-svsm.dev>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, Dan Williams <dan.j.williams@intel.com>,
	Michael Roth <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
Subject: Re: [PATCH v4 13/15] x86/sev: Take advantage of configfs visibility
 support in TSM
Message-ID: <662c239680842_b6e02944b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.1713974291.git.thomas.lendacky@amd.com>
 <e3143c1f3d0b26fcd8884c6f75644b634a7138e8.1713974291.git.thomas.lendacky@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e3143c1f3d0b26fcd8884c6f75644b634a7138e8.1713974291.git.thomas.lendacky@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OZbSC18IFJbRpOW+JVZZOf4nFlYAHbc15+0DhJxR1HeTYyCrjqGa9SixeTgm?=
 =?us-ascii?Q?RJffpjYttd34HmtAMzzZsuNWIeTgTcGKiVnnbmMDFnKLx5TVeCFiFPlKFf8c?=
 =?us-ascii?Q?RRKhNswnXEIoNDmuo+RR6y1nJndDfwt5ASf30Dbj1rzsShaS8Dn3k8sO8kUi?=
 =?us-ascii?Q?TMUZlIy3xhXsB3tLsqYNH/t2qoW2o7QMfgoSOUxMhftDPB6ICV3A/ucPzfXz?=
 =?us-ascii?Q?zn/aM+IqaYR5TPguppaz9vdQCNiYiO/GjtpA2FWED12HSffhkWzJG60PofSX?=
 =?us-ascii?Q?sAeyhyvPsQ3acn+rh/a9GqwVeTP+KYmd+ZOG+XNeiZcy9n57plXsCX7KFVdw?=
 =?us-ascii?Q?AgyMlzfwMW/2PUl+llYqQqkhI062bCJcURYhmsFdSeDS4rkLjHUKDZ8igeV7?=
 =?us-ascii?Q?RQlyz5ytf8h8XinTb8JWyc1c9ixj0WvXGiQe72xgLBO2iW9n/P/Rq30Gh/IF?=
 =?us-ascii?Q?6RUPJ73IvQu2oQZevkMX7Ijzz3pdTxCKbq/mijYMe+0/RGKVhcdI6mxou7Ek?=
 =?us-ascii?Q?h8SVvkMzrS6LATuRUoc49Mkh3JbPSAzThv13qVLgr4ZujCdRY+/XM1qOkfLs?=
 =?us-ascii?Q?iy3XMh/P8XkAbb0IuppdUHFuieNd6ShzRM9wKuXidtVfzxuuH2/WpEvcnn+d?=
 =?us-ascii?Q?6AvvUpO7cc08iLPjoNlJiKJ6bMpWSlF+3lx7RjRUUj/wP+HFdVVAdDy4TXcI?=
 =?us-ascii?Q?s4RfdEH32h1CVKdGRAiX4WyrRvLL9+VB9VwSkqhRCh5x6Z9b63hB6Muv0iup?=
 =?us-ascii?Q?hSeijzFsc6wj9ZMC887wfPYGIJBD4Ye1RZYiHuWoDGc3Dnmrmrl17PNiP4sw?=
 =?us-ascii?Q?GrCiSVeddmUTElC1RGgJzsHfMTDLawpRLuFcpMD5xUB9kL5UatcjVnU7S+dL?=
 =?us-ascii?Q?xoQswcMZLUiUyFEynCD5kyS6HgxU1+FqibrnaJqZtQ/rAmSrpgXqiM6A8x++?=
 =?us-ascii?Q?UNGjoGg8+gPVl5P+IsizqFIBEoOSImUcpUuoj6URJiiukF2B6g+zELCIZmPp?=
 =?us-ascii?Q?S5nvjvBY4+2Q1nmFVjr2yrSS/cIR6M/jUxMF0lF8k7C/pJdoAgcGnVSYBvV3?=
 =?us-ascii?Q?CXvwkJopEZX0yyrjXYqe0WobpM6tuhqvvJVt1y96gmSwGQizxAdZ65iHvkxx?=
 =?us-ascii?Q?zC3Masv0XEnapZP+cudR8zFPHslodliRngDPAZqvdtEcZqf6MsHZGkGsaz/G?=
 =?us-ascii?Q?YZp4UbLBT+BWKBOCDF0dD7ESqHIkvSei3kZxmMz1r4wkWqTlHA/xKcAEjW1U?=
 =?us-ascii?Q?i5FTcsHemgkjF0LcrtAUe5xLgLX5MaTgj12TJ1ErA7pyhWkBiD6UCwCW1Gl/?=
 =?us-ascii?Q?a5QJ/0QRV+bYeOnKdGir5Ye8I2JPhiARZzLhxEshJ5zXlaDpsjuawwGn+YFX?=
 =?us-ascii?Q?u/6hNiPZzaOvdI7WVPjdYw6QaC4QR/jdjmHZOnBkBVOe/RQb5eSOHms1glvG?=
 =?us-ascii?Q?54pQtnloFSl/5pJ97XodSpIzvtDNRLuVG293g9FpoCerTEmW3/HZwzr+xJdz?=
 =?us-ascii?Q?1D3LfXKFG1mjt+F/yoqMfDzB5nNdbRpBD5FZZO7yfvy6tAs11ayEkUbobSeh?=
 =?us-ascii?Q?miDWgmnLaPgdx4lbHWdG3XtAqERtEnxjTiVd/xRL54WyibkAxH8Wn5yuoXKZ?=
 =?us-ascii?Q?bg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 033ce2a1-b6e5-4207-8fd9-08dc663c0dc0
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 21:58:49.6511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ug64GT8UG5i2WX2E501+aDuwozCE7dZ3W+8+LbcfjKQ2Yjyu6OIDpiPqcMpKjqgmYSZ13rQGtOba6Q/QCraSqyxetmiFYCnkLfrgwacuTew=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5795
X-OriginatorOrg: intel.com

Tom Lendacky wrote:
> The TSM attestation report support provides multiple configfs attribute
> types (both for standard and binary attributes) to allow for additional
> attributes to be displayed for SNP as compared to TDX. With the ability
> to hide attributes via configfs, consoldate the multiple attribute groups
> into a single standard attribute group and a single binary attribute
> group. Modify the TDX support to hide the attributes that were previously
> "hidden" as a result of registering the selective attribute groups.
> 
> Co-developed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  drivers/virt/coco/sev-guest/sev-guest.c |  3 +-
>  drivers/virt/coco/tdx-guest/tdx-guest.c | 29 ++++++++-
>  drivers/virt/coco/tsm.c                 | 82 ++++++++++++-------------
>  include/linux/tsm.h                     | 41 ++++++++++---
>  4 files changed, 102 insertions(+), 53 deletions(-)
[..]
> diff --git a/drivers/virt/coco/tdx-guest/tdx-guest.c b/drivers/virt/coco/tdx-guest/tdx-guest.c
> index 1253bf76b570..964af57f345c 100644
> --- a/drivers/virt/coco/tdx-guest/tdx-guest.c
> +++ b/drivers/virt/coco/tdx-guest/tdx-guest.c
[..]
> @@ -249,6 +250,30 @@ static int tdx_report_new(struct tsm_report *report, void *data)
>  	return ret;
>  }
>  
> +static bool tdx_report_attr_visible(struct config_item *item,
> +				    struct configfs_attribute *attr, int n)
> +{
> +	switch (n) {
> +	case TSM_REPORT_GENERATION:
> +	case TSM_REPORT_PROVIDER:
> +		return true;
> +	}
> +
> +	return false;
> +}
> +
> +static bool tdx_report_bin_attr_visible(struct config_item *item,
> +					struct configfs_bin_attribute *attr, int n)
> +{
> +	switch (n) {
> +	case TSM_REPORT_INBLOB:
> +	case TSM_REPORT_OUTBLOB:
> +		return true;
> +	}
> +
> +	return false;
> +}

Why do these callbacks need @item and @attr?

[..]
> +static bool tsm_report_is_visible(struct config_item *item,
> +				  struct configfs_attribute *attr, int n)

Per the comment on where to find the is_visible() callbacks for a given
item type, I expect the need to pass @item here goes away when this can
assume that there is only one way to have is_visible() invoked for
@attr, right?

Other than that, this conversion looks good to me.