Received-SPF: pass (google.com: domain of linux-kernel+bounces-160728-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240424155309.1719454-11-ardb+git@google.com>
 <20240424155309.1719454-13-ardb+git@google.com> <20240424182659.GA2126602@dev-arch.thelio-3990X>
 <pgsqflimo7d2ozhpmdrmscx25mxs5lypcvwq6mgjs7uixsxvsl@5papnq46mwbs> <20240426215351.GA3278657@dev-arch.thelio-3990X>
In-Reply-To: <20240426215351.GA3278657@dev-arch.thelio-3990X>
From: Justin Stitt <justinstitt@google.com>
Date: Fri, 26 Apr 2024 15:01:56 -0700
Message-ID: <CAFhGd8pasnTTv87V3LYpzCz=DdS8dXGA8Z9qGEqw=K+C_Xvf=A@mail.gmail.com>
Subject: Re: [RFC PATCH 2/9] x86/purgatory: Simplify stack handling
To: Nathan Chancellor <nathan@kernel.org>
Cc: Ard Biesheuvel <ardb+git@google.com>, linux-kernel@vger.kernel.org, x86@kernel.org, 
	Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Eric Biederman <ebiederm@xmission.com>, 
	kexec@lists.infradead.org, Nick Desaulniers <ndesaulniers@google.com>, 
	Kees Cook <keescook@chromium.org>, Bill Wendling <morbo@google.com>, 
	Masahiro Yamada <masahiroy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 2:53=E2=80=AFPM Nathan Chancellor <nathan@kernel.or=
g> wrote:
>
> On Fri, Apr 26, 2024 at 09:32:52PM +0000, Justin Stitt wrote:
> > Hi,
> >
> > On Wed, Apr 24, 2024 at 11:26:59AM -0700, Nathan Chancellor wrote:
> > > On Wed, Apr 24, 2024 at 05:53:12PM +0200, Ard Biesheuvel wrote:
> > > >  arch/x86/purgatory/stack.S        | 18 ------------------
> > >
> > > This needs a small fix up to build.
> > >
> > >   make[6]: *** No rule to make target 'arch/x86/purgatory/stack.o', n=
eeded by 'arch/x86/purgatory/purgatory.ro'.
> > >
> >
> > I was trying to reproduce this build failure, but to no avail. I am
> > curious what your build target / build command was.
> >
> > It is clear that stack.S has been removed so your change makes sense, I
> > don't doubt that -- I just cannot get that specific error message you
>
> Odd, I was using my distribution configuration for the test but it is
> easily reproducible with allmodconfig:
>
>   $ make -skj"$(nproc)" ARCH=3Dx86_64 LLVM=3D1 allmodconfig arch/x86/purg=
atory/
>   make[6]: *** No rule to make target 'arch/x86/purgatory/stack.o', neede=
d by 'arch/x86/purgatory/purgatory.ro'.
>   ...

Agh, I was just doing a defconfig followed by a menuconfig to manually
enable all the kexec and purgatory stuff. I wonder which one I missed.

allyes/allmodconfig is what I needed here :thumbs_up:

>
> > encountered (what is a .ro file supposed to be, anyway?).
>
> Read only? Relocatable object? *shrug*
>
> Cheers,
> Nathan