Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp82197lqa; Fri, 26 Apr 2024 15:21:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUcjmUu0Vrd/gVSpd9QT8hDjxux4zMvQKVWvtMMElSkngJNHtfUQMmM+B8nYr2WcI84F3osgylU5+p+Dngv7U+Cg3wK5XsKy7eKxzjn8Q== X-Google-Smtp-Source: AGHT+IFTK1bCrSDxzuMbo3hu6LZxx6Tuutm05lRHd/ZjO1FL/KkHgSDujY9ieS5NULpirGae2v3x X-Received: by 2002:a05:6358:5d81:b0:186:431:d9be with SMTP id s1-20020a0563585d8100b001860431d9bemr5094088rwm.19.1714170088783; Fri, 26 Apr 2024 15:21:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714170088; cv=pass; d=google.com; s=arc-20160816; b=lL5J6RISOczFOkZ4bhO3uJ2tW/404KnjfqQYdlAC8wIed6lP6uDGwi1GG4bUxCeoc6 YF7CRfWdOjNUwTjHSLdQmdXDakZKs7hs/VZGGHFZOoJZ+sDp6Zu3yB/xQAGdlTU8CnvF 6mq3/wR4YcsIto1E+ssEvCf2jaLyJ4Cz6EgQnVZDyy2lVtH0fFFQjgcv7gRZQ4CphKSc cHCz6EsZP3/OAsykmW5Yn6DnxtWthwRXNxM9tlGpTvqtsNvmaZ4DrBpkFLaLfwBhDkZl MX2mwKRShp0c7Aqy9hDQENcf5cYX+/2FnFvTR2cpA2mlbVs+A1igda+1YpaeF53B9uKz /tTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BMXP4QZNQ05xhxi1ioEEoKbUgZFGoJ2UMN7lYCFxZkI=; fh=fnFlVD2jLgeK8ZUAaSUpBm22UM8CRWGTuQeft9fddAk=; b=jTVt3wrzdwHnpg+3pGuQVQahZZqBkYbmTIEPW5eDWrtxKHrexg3xhFdtVcmCHqV75Q oTsYixuTuo6XT3UM5+94xwCk6rDAz/Z/iLEo1z48b4dZUtCqcN5BshT74tpL8lfZtuiA Q+i09GOeQxYWKxFzFcpZkIj58d8rGiHp3nueOvn+C+GzyzT6Hf5eqnpwbueBx7Mi/GJ4 dFJALpA+FmJ9U1t6DoG0pLD3u+VWi4iYviWfuk4OGSSC/cGuWr6przHwhRzJ8R4C+sVr z19Ek34dGzl6kjvTTe0SId6H7401+XFA5xTdXRhCY+foRpBvkBOpYIsIOav1IQrC91ez bZDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="YsT4k/Bi"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-160733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ed4-20020ad44ea4000000b006a0998f4fe0si6533453qvb.512.2024.04.26.15.21.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 15:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="YsT4k/Bi"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-160733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7AAED1C22544 for ; Fri, 26 Apr 2024 22:21:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ABF1C38DE8; Fri, 26 Apr 2024 22:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="YsT4k/Bi" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646F54A3F; Fri, 26 Apr 2024 22:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714170079; cv=none; b=XjUBtm6aC/j/dqhpQfNyZF8s6oQFvt6UnDEr5Ex/TWqVxVcAXjj5rcDXGw3EF8nlYcQDIHDSNgZ7kZtXjP6LV8gv4dVdGiMDUTgQf4bgMncS0nOXkOPLKkl3M0cntLv2a0lhfTyNUYrcTRzKcwd2TqgKimSzonWbVcq7V5q8NEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714170079; c=relaxed/simple; bh=EUlizgcxso2aTQ6uS+9xKMyAIGjtTlvv0YMID19KswU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pnvl9JkJAuGMkdSdNTNZUhE8cIyk1dDh6zy9EF98ZpYTw6FHHEjWct9hzcUFX80olR2kGbaL409Azgr/dhBu8HKNW7v+3zCPT35eObcc43XOPy39qJfammwt7hqX/+rnSTJZOlKmSBlY0f137A9bEqX1w/XySVl7GOoojW3J1Iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=YsT4k/Bi; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BMXP4QZNQ05xhxi1ioEEoKbUgZFGoJ2UMN7lYCFxZkI=; b=YsT4k/BiBL+2lnyXGBxnG8mQmY RHJLNhdQf4eExpNidikEjhlocI1JUa3v+DNy1DezPkLnUzA9b+2dupSLcChNOXfXmfFzwuaKkJ0mI uH5pvNtBSGCcS58wt9slKCH3DoEC1ovycFJAfelcW/smKfxgrvo0BOeM2drDMEVc9ujY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s0TwF-00E70Q-9F; Sat, 27 Apr 2024 00:21:03 +0200 Date: Sat, 27 Apr 2024 00:21:03 +0200 From: Andrew Lunn To: Slark Xiao Cc: loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: wwan: Add net device name for error message print Message-ID: <6f7c4b67-a6bd-4fc2-a7da-e4bb0c2b6f50@lunn.ch> References: <20240426080733.819633-1-slark_xiao@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240426080733.819633-1-slark_xiao@163.com> > if (skb->len < sizeof(struct usb_cdc_ncm_nth16) + > sizeof(struct usb_cdc_ncm_ndp16)) { > - net_err_ratelimited("frame too short\n"); > + net_err_ratelimited("mbim: frame too short\n"); I don't know this code at all, but i think you can do dev_err_ratelimited(&mbim->mdev->dev, "frame too short\n"); That way, it tells you which of the 42 mhi devices has received too short a frame. Andrew