Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp99720lqa; Fri, 26 Apr 2024 16:07:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUtdZKtHSgKC+UpOwHGmsr2HiUjCwRmfkElGEFyzADZZEacN9ZXdauIzEqS/WblNauSEtfBCO0bFHxM0pPRLxmq1pB/uNa/QeK0699L4Q== X-Google-Smtp-Source: AGHT+IHxoZZe2mc4eeVTnqyTP88tasdPC6Yos/pPSh+NNvd5BoJcjT6JKV4xUyfzV2RCLqOU8Jgw X-Received: by 2002:a05:622a:613:b0:437:b3e1:8b2d with SMTP id z19-20020a05622a061300b00437b3e18b2dmr4904724qta.36.1714172844390; Fri, 26 Apr 2024 16:07:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714172844; cv=pass; d=google.com; s=arc-20160816; b=eUEKNsUPAgh8U/kYaReT4rR5ZW6EHbz6aQu1YSBCSsaw6mFM1Pypq4jzWJGjIu15RS 5OK557DXCvNTWAd5jeJBZ9uNTtILLocqDHU5YZ0isR5E2E0OpjJF/+zUicoNoS1stzQb 8MrLX7im0v45Q8VKSCdLJwH/hLsv+BKWCL/+T2FLeTi50qdzVZMq/Amq7JVPuEgh0mFZ fgdrGDG0lpNlrBJIUoQ2XFnlKXup49m8e6LH6LDwqZrbGpGMALuDhKWdKcT9vRtsLTbt +2/WYZesjOkWPZb4roD8fjEejPPkWekMj8rUVxip7ztc0ITcLH3/32t4/JoQ909i+Hv1 wrDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=crL3ZVpLnyfR96PHzb6m2cWgYKDojGvXBG+O6n1NruA=; fh=wxrOZ/wTdfqOHYv/+JtjOeiLkVqyHD11VhqoIhVv0t8=; b=zD5Avb0Q91r4CIqD3rRUavSLS+z+j6KFhWH4R0Nduv6jpL8447q7S0TRUOf0xREoxX hmA4apHUxouNd4cfEi4Iy6xRqnzO7OLLWeHwNQ5AhQ9wJzUmqHIvYuPG1hr/HM2JyUCW YvICZIRlbgaSHdoQAVOAR74h1VupTiZJNs+eqDNGZFP6pw+FMmhUAiff/nni59FkIx/D tGrPt2VKhUq5o5+BGTFEXSgzvBtq9iM4ZxcvIHpQ2k+3+s64YPT5MIOTeljhCNuyn67q nA0f3ERGnJS55Pfj6sGQCN/mfM8dqeMPzdBEyZOJWAKf1FfwrEPWiB9ixtAkvZ4oFTD7 Q8LA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HSP+Ao3T; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-160764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160764-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id er14-20020a05622a5e8e00b00434ee91f709si19261223qtb.537.2024.04.26.16.07.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 16:07:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HSP+Ao3T; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-160764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160764-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D4C0C1C21A44 for ; Fri, 26 Apr 2024 23:07:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D7E433B79C; Fri, 26 Apr 2024 23:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HSP+Ao3T" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB0863A9; Fri, 26 Apr 2024 23:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714172833; cv=none; b=ko8vPqrpU5h3Sv2Wv30tcH0kZoTVxKWQTs6Y7K0+4f2xWIXr3xwlOlEDJOQNyLuGnCKQs3KqJ2jPR7R4JoxmzL0niojpYayp3gvGITu/9iqLnXHN0F3wDFXELZJvK4ErwABL3vfyOnITF0ZuNy0QQg83UqN63hT0D1/owVqXG04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714172833; c=relaxed/simple; bh=KoojGFy+JrtPKQmbUwRNQIrM8CnY7+bm7FaKHPZkLic=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UCaOlGg8XEZUuBZ8gK3+tQ4L4Jp57TJE3r3WslY9HDA9o3ykZOx/le6XP8GH7qUTYwL5uJg7CrARMrXHO7c9pKyJ2dEn8KpV+DssvHGyBRrFwTMB2Tan/xBI5Et2Bx5FL3mUOrSFiXTONaSMseY/9BEqFYixlxkG/iQNqS9cc0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HSP+Ao3T; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C36CC113CD; Fri, 26 Apr 2024 23:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714172832; bh=KoojGFy+JrtPKQmbUwRNQIrM8CnY7+bm7FaKHPZkLic=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HSP+Ao3TUzFiOIcogruEQEp1VoHwB1B1oSeW2CSPQRZux5Pf6zBOrMWyEtJbGoNVr 0pG264mwOAt5cqY2ssYYwIB1pB9rpCw4Li/wTXceKapR/ErebKFxhiVsYFfiWmRGr+ 5J1iC/o6aqYk8TuDo4H/1co6wXwGRJTvfkpkJut9owS9YXST6DqjHZxcmCj1hHGZio 1J5n2hdxFXY8VLjlBrxDDfXY1g5Aw4XyoZAea6VvvT7870O5olKHAqYXXZz9m5WmxM PHcdJWUSn0wsoPwWMS625/qmidcxVvLschMAE64oNey5173I9GUJ+WPSKeisEvGniZ AdY0uvWxo75JQ== Date: Fri, 26 Apr 2024 16:07:11 -0700 From: Jakub Kicinski To: Mina Almasry Cc: Dragos Tatulea , "jacob.e.keller@intel.com" , "edumazet@google.com" , "davem@davemloft.net" , "pabeni@redhat.com" , "ilias.apalodimas@linaro.org" , Jianbo Liu , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH] net: Fix one page_pool page leak from skb_frag_unref Message-ID: <20240426160711.4fd99586@kernel.org> In-Reply-To: References: <20240424165646.1625690-2-dtatulea@nvidia.com> <4ba023709249e11d97c78a98ac7db3b37f419960.camel@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Apr 2024 15:08:42 -0700 Mina Almasry wrote: > I'm unable to repro this issue. Do you need to do anything special? Or > is 1 flow that hits skb_segment() good enough? At some point we may want to start writing unit tests to make sure we don't regress the 5 corner cases we found previously.. ;) Should be easy to operate on skbs under kunit.