Received-SPF: pass (google.com: domain of linux-kernel+bounces-160773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <f97f2dfc-38d0-47be-aef2-6d3baf481a5e@gmail.com>
Date: Sat, 27 Apr 2024 00:22:28 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH][next] ALSA: kunit: make read-only array buf_samples
 static const
To: Takashi Iwai <tiwai@suse.de>
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
 Colin Ian King <colin.i.king@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, linux-sound@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240425160754.114716-1-colin.i.king@gmail.com>
 <20240425232250.GA205425@workstation.local>
 <81a9e3c2-2c44-406e-af19-90d9dcfe4a92@gmail.com>
 <87il042mbn.wl-tiwai@suse.de>
Content-Language: en-US
From: Ivan Orlov <ivan.orlov0322@gmail.com>
In-Reply-To: <87il042mbn.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/26/24 16:08, Takashi Iwai wrote:
> On Fri, 26 Apr 2024 14:05:34 +0200,
> Ivan Orlov wrote:
>>
>> On 4/26/24 00:22, Takashi Sakamoto wrote:
>>> Hi,
>>>
>>> On Thu, Apr 25, 2024 at 05:07:54PM +0100, Colin Ian King wrote:
>>>> Don't populate the read-only array buf_samples on the stack at
>>>> run time, instead make it static const.
>>>>
>>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>>> ---
>>>>    sound/core/sound_kunit.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/sound/core/sound_kunit.c b/sound/core/sound_kunit.c
>>>> index eb90f62228c0..e34c4317f5eb 100644
>>>> --- a/sound/core/sound_kunit.c
>>>> +++ b/sound/core/sound_kunit.c
>>>> @@ -167,7 +167,7 @@ static void _test_fill_silence(struct kunit *test, struct snd_format_test_data *
>>>>      static void test_format_fill_silence(struct kunit *test)
>>>>    {
>>>> -	u32 buf_samples[] = { 10, 20, 32, 64, 129, SILENCE_BUFFER_MAX_FRAMES };
>>>> +	static const u32 buf_samples[] = { 10, 20, 32, 64, 129, SILENCE_BUFFER_MAX_FRAMES };
>>>>    	u8 *buffer;
>>>>    	u32 i, j;
>>>
>>> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
>>>
>>> We can see the other similar cases in the kunit file. I'll post the fix
>>> later.
>>>
>>
>> Hi Takashi,
>>
>> Hmm, correct me if I'm wrong, but I don't see any other significant
>> allocations on the stack in the test.
> 
> I guess he meant slightly different ones
>    https://lore.kernel.org/r/20240425233653.218434-1-o-takashi@sakamocchi.jp
> 

Ah, alright, found it. Thank you!

-- 
Kind regards,
Ivan Orlov