Received-SPF: pass (google.com: domain of linux-kernel+bounces-160775-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <12445519-efd9-42e9-a226-60cfa9d2a880@intel.com>
Date: Fri, 26 Apr 2024 16:26:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency
To: "Chen, Zide" <zide.chen@intel.com>, <isaku.yamahata@intel.com>,
	<pbonzini@redhat.com>, <erdemaktas@google.com>, <vkuznets@redhat.com>,
	<seanjc@google.com>, <vannapurve@google.com>, <jmattson@google.com>,
	<mlevitsk@redhat.com>, <xiaoyao.li@intel.com>, <chao.gao@intel.com>,
	<rick.p.edgecombe@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <cover.1714081725.git.reinette.chatre@intel.com>
 <eac8c5e0431529282e7887aad0ba66506df28e9e.1714081726.git.reinette.chatre@intel.com>
 <f5a80896-e1aa-4f23-a739-5835f7430f78@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <f5a80896-e1aa-4f23-a739-5835f7430f78@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjVjZHV3aldqYXJtYk43d0wrdFMwOUFrdWtEem80STBEaEJhMU5WMkVNRVVZ?=
 =?utf-8?B?cThFTFB3SC9OcGJyeFp2ZTJjdmRTR3dsNFFkbklJYnQrSU4xTHk1N1FmRjVC?=
 =?utf-8?B?c3Vma0lTbnI3am82YTdmc1VkTW5GRmVhWHhEanc0b0xaYzNlZ1BYZ1docHNE?=
 =?utf-8?B?VG9sRURZOFRkNloybEw1bW5Mc2RKMjh5L3pNbm1xdHMra0hlRGdtU3QyZ0kr?=
 =?utf-8?B?bng3aW9UKzdhYnFra0I2MjFDYTExWTZXMktMS0dCUHBqcW0yelQzcXNDNFZL?=
 =?utf-8?B?VnRrT0M4MFE4N3E0dUJVWWJhT1g4bCtYcC9aSWJUaXlJMHlxODljNUFYaDRU?=
 =?utf-8?B?NTFQZmNEdTVDVVR6TGJlaHdSR1MxWjZSTWQxVXNrNW5LWnBlS3duN1FZbWF6?=
 =?utf-8?B?enI1b0U4YWhoWVk3OTdVRGdXMFZ0d2tXRnBxSGlCQS9Hc0VVYWdBM2hMcTV6?=
 =?utf-8?B?RzkrRG1nazRKU3YvdFNkajI0Mmw1UlIxS1M0SG5EMnQyQzdLYmdnQnBwM1hF?=
 =?utf-8?B?MDN0SWJRNmh6Zm1SeTU1S1lXY0hxVVB2aklGN3k0TFZSL2JRMXIyU2dVaVNR?=
 =?utf-8?B?UlRRSFkzOU1lVGJXcXJicVRRbnhkUjArNkVNYks3RDQvSVRRR3FMemsyZDRZ?=
 =?utf-8?B?Q1BwbHQ1VW1kS1VyUTIyTXdtdFRNeU1qS2E5L1AyTDE2NHR5aFFPL0tjUkdu?=
 =?utf-8?B?TTVybU83eThPcGRxVGJ1L29PaVJFT3JSNjVlNGwzNm9udmxUVlpDcEVzZ3ht?=
 =?utf-8?B?Qll5NVFNNHFXazNXYjMrWTJCY1dKbUpTZ04wRU13Qi85MG9wb2NSQXhXWHdD?=
 =?utf-8?B?SDljaGRQVFIvMmllQld2OUZCRjJ2clpFK2RhZXlWUlVPbmNVY3YvSUM0dC9Y?=
 =?utf-8?B?L2JGYXVWV1FGMCtBWldJQ1FKc1YrZm1uQXlldnpPaXhjTndneVVmdkFDVm5r?=
 =?utf-8?B?eWkxbkMzcG1HaG5LV2xmSDE0S3dEQUMzckt3RU5zcm1vQm5nN1JNanVBSDFL?=
 =?utf-8?B?MnlYWGpOWFlpOXF4TUNaUS83QXUxMjE5NHhaOXJmcExKeFFoUncvcFdmYVg0?=
 =?utf-8?B?L1ZacHpockZ6VW5JY3lOb25rWVhmQ2FRS1NSVXRSV3dhY2pIbmtLWVlua1gx?=
 =?utf-8?B?YUhMNTNtaWZ2WEdEdzVXRUpkZXBkenM2RTFZcXk5NTdKNVcxek9xUWRCRVkv?=
 =?utf-8?B?ekhUL283VkpCSEgwajVnODJCejJTZDcvRTJDRUtuOWJFYUFWejYvMTQ1eXZa?=
 =?utf-8?B?QnE4WXRNT1BTcE0zRFdXV0lFbUlGS1pkTERCMGowcG5kVTBQd2dCWEt4d1JG?=
 =?utf-8?B?V3ovVDBkM1pkWlV0UnAvOHRscVhXVDZHTTFCZ05IQzF0dFZDZ2J6b2dLT28w?=
 =?utf-8?B?ajRORnJ4dm5vQ0tEREdVR2QvQWJtNnE1aFcxUzVka09qSWthWnN1YkVqZUUr?=
 =?utf-8?B?UTJYRE1ZS3lFNXpWUzJNSnVPT0ZQZ2pQTFM0Qlhzc2xNRmxid3pic1VhSWpr?=
 =?utf-8?B?bDI1RUcrRi9ZWDZUSlFSbXpVYVJod1VGMCtDbmU3U1pJZ3huL1FrUWN4TFpS?=
 =?utf-8?B?Z1A4U3N6YTcwWUlzUGlFYytvNWcxdWVMb1kreVdzakR1VWl4YVZOY0RTcUU2?=
 =?utf-8?B?OWd3L0pGd2VTVzhrUXhPZ1NreG44K1hKVlRETm1IVU54K202aEw1Tysza2p3?=
 =?utf-8?B?LzQzRUdOZWw1QmR6ZWZqZ2xHSHBwT0pNbHZJa2IvaC9LN2pvb1A2QzNlSS9I?=
 =?utf-8?B?S25URVdNdW1ua3lmNzNtVnhVb2d0ZDZaVnJJWmFnYytjQWdadUdZUnByWlpS?=
 =?utf-8?B?WWV3MzBuYzhxYnFoT0RjUEROVC8vOTJpcEFwek4xTWd2LzhoNFpSam1EN2N0?=
 =?utf-8?B?dldwTEVHWUVlOUNQNWZ3UXlJcEFkMktlT3J2T0V1TFZoTnFkcXMxRll2dVpu?=
 =?utf-8?B?TE8xU0F2SWhMUFpwMXhNcExLWGRGbHN6MzFYWDJJNzlDWU0zZHRrdmRmTHNt?=
 =?utf-8?B?TWtRWFNrdnNvNUtuWkI2dzJWYWd2UTNjQzFTUWREa2xRUUNVUk1QRGs5TWhD?=
 =?utf-8?B?ZCtMVFNpQm9zNzF4aXpvTDBxNVVwbTZnRW5scGpwaFZEbUhmRmRWUVR6bkRP?=
 =?utf-8?B?bFI4SWJ6dEw2YmFRT1ZqcW9Oc0prSWdCWS9SNDFnSG81WEVOTVNVVCsyUHI2?=
 =?utf-8?B?QXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8b5889b-ba5f-41db-2eef-08dc66484b33
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 23:26:26.6324
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FVKBk5MlM/rSx3pktmbOt8TGHcf/6lGpB/sRci+jv1r8u0Zny7SyXIMWzN/nDbnMH82k5gpf8Mb8GOeLk4IulMiGdjCfoOkq59818SM7RHE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7908
X-OriginatorOrg: intel.com

Hi Zide,

On 4/26/2024 4:06 PM, Chen, Zide wrote:
> 
> 
> On 4/25/2024 3:07 PM, Reinette Chatre wrote:
>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>> new file mode 100644
>> index 000000000000..5100b28228af
>> --- /dev/null
>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>> @@ -0,0 +1,166 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Test configure of APIC bus frequency.
>> + *
>> + * Copyright (c) 2024 Intel Corporation
>> + *
>> + * To verify if the APIC bus frequency can be configured this test starts
> 
> Nit: some typos here?

Apologies but this is not obvious to me. Could you please help
by pointing out all those typos to me?

> 
>> +int main(int argc, char *argv[])
>> +{
>> +	struct kvm_vcpu *vcpu;
>> +	struct kvm_vm *vm;
>> +
>> +	TEST_REQUIRE(kvm_has_cap(KVM_CAP_X86_APIC_BUS_CYCLES_NS));
>> +
>> +	vm = __vm_create(VM_SHAPE_DEFAULT, 1, 0);
> 
> Use vm_create() instead?

Sure. This is easier on the eye while generating exactly the same code.

diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
index 5100b28228af..6ed253875971 100644
--- a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
+++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
@@ -149,7 +149,7 @@ int main(int argc, char *argv[])
 
 	TEST_REQUIRE(kvm_has_cap(KVM_CAP_X86_APIC_BUS_CYCLES_NS));
 
-	vm = __vm_create(VM_SHAPE_DEFAULT, 1, 0);
+	vm = vm_create(1);
 	vm_ioctl(vm, KVM_SET_TSC_KHZ, (void *)(TSC_HZ / 1000));
 	/*
 	 * KVM_CAP_X86_APIC_BUS_CYCLES_NS expects APIC bus clock rate in


Reinette