Received-SPF: pass (google.com: domain of linux-kernel+bounces-160782-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 26 Apr 2024 16:50:09 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Dave Jiang <dave.jiang@intel.com>, "Dan
 Williams" <dan.j.williams@intel.com>, Jonathan Cameron
	<jonathan.cameron@huawei.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>
CC: Dan Carpenter <dan.carpenter@linaro.org>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>, "Alison
 Schofield" <alison.schofield@intel.com>, Vishal Verma
	<vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>, "Rafael J.
 Wysocki" <rafael@kernel.org>, Tony Luck <tony.luck@intel.com>, "Borislav
 Petkov" <bp@alien8.de>
Subject: Re: [PATCH v3 1/2] acpi/ghes: Process CXL Component Events
Message-ID: <662c3db180909_b6e02942e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240426-cxl-cper3-v3-0-6ade7dfc849e@intel.com>
 <20240426-cxl-cper3-v3-1-6ade7dfc849e@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240426-cxl-cper3-v3-1-6ade7dfc849e@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5rsahuVLIPZJCbIwiiL1nl/BVY17FjEUA7YQ9fMIe1JZlvS1UXrFwt6g4M3i?=
 =?us-ascii?Q?/2ev6z4IMqM1ZfZ/9tM7KT3gQaK/TsnV89aNPWYmFKVVGGHGRKTlN0vBNx+0?=
 =?us-ascii?Q?lHbyM8xEiUM+26M0KDNp7drAMNZYOyVe8Ziq70T9F8nMdHFtD7H89iQUHjWt?=
 =?us-ascii?Q?t4Bog1fnTnbVdQEHax4Gle7ug/0w0srXTmbuHTANBr2VrqhNVtHZQeamWksz?=
 =?us-ascii?Q?R+1J1hoAGYAjlPNQJThRViXo0T3FKgP1xunvomrqYLQ96PPTHjqQPfNZfP6b?=
 =?us-ascii?Q?NWSKKx9p27XauWEDSkZb7M4/wBwUTHwiSIeHNue7t5MVR8/zccH1LfTnZ2ux?=
 =?us-ascii?Q?wG//heXRFUMs+ZcCoTHMZ9EMkD1Lz+TEtp0adi39oFzEPA/9x9r5E+aho+4B?=
 =?us-ascii?Q?yg8Zl7bbwoMvmY/PsqqoqiqKl1zZiai1ChD4Lhd0S+UUrPggW71zZ9h2NW9H?=
 =?us-ascii?Q?WFNz8kyjqP8uiPFyPVHNrT8uZoD4fKHYt7FgvNtguyvONxeaSnl2//t8GC0N?=
 =?us-ascii?Q?Fh5UErQ0P0Tz5ssTgvJaStv6k7vudady54nB0CS4YVxEVVYbJ8LUAykS+nST?=
 =?us-ascii?Q?dFHDRA5rTfotsWpCvu8pRrXgmGv1I4dk09nGU46NESsDIC6rsXqKZuLmqWcg?=
 =?us-ascii?Q?km2JfcdKlvsSLJ/ojv65/SWpmjM11y5nGjCzfLL79FohY1buqmJTRxoH7Rvk?=
 =?us-ascii?Q?c7uhm8Co/3foHblQLxxI40ssZQCk9Jn8M6Lp5G3dv1+29wM7/QclmNgEXAjJ?=
 =?us-ascii?Q?jiGl3i7DeFkP4xe65v8u71/pXp72jO+SB+K+nXilm0TPBDbU4/r17b8P7Hlv?=
 =?us-ascii?Q?yf/9PoRU1pmxP46EJjhmJGzcaN5meTsB+4Orn2bZX1e1o1vVRCyxX1Ll5inY?=
 =?us-ascii?Q?ynfjWSGammKKdbgWJwVStL4ueszx4KkNmdeKtHBZNUq7s2rn23rm+X1QrFmL?=
 =?us-ascii?Q?EdSFvF/yxv1Z0IReyzu3UNzubkmGywAaISUJSatvqEe2TWsWIgsPj5wvFJQs?=
 =?us-ascii?Q?gpJ/BxJYPnQtR97GgR3amaoEmiaZvA5ByYooCj2nmFWnx9mci46rcGPEL9+p?=
 =?us-ascii?Q?ihzjYn8mkkfIpfzIY2RPy6prFyKp4fcb+VfBLh11Oys26aWMU4OYZ8Amt69v?=
 =?us-ascii?Q?0g2tV5pSYqu5m73pvMinc7R++iy4E+vNKeM1lFZHBK4L3MsRQeoqgMyXHRJj?=
 =?us-ascii?Q?MQiO/s737BYF1v2B/tB0kIw3kj2GMCzc/I6m+ZYWGPkaXYALaSldgIAxPVYi?=
 =?us-ascii?Q?7VrLxEsg/kSzRltwcUbz/jRwxeiiJbDEIXf7sXBqnCzM9lIKc4ynO5ag1QEp?=
 =?us-ascii?Q?BI/gwkYbgFitzCdPAowBx4VIZ6ncoki+90cQtnFrmNU1V73JW4ArHPQxNvhC?=
 =?us-ascii?Q?OBcC1U9Xhv2BXoFwuYw3pHCmOMQsItK+IJmHb1FaD8YhmoCz3bP0DSWMJ+/B?=
 =?us-ascii?Q?3LLrZQK9qnVxyQ4XZHMFzrvzbGOoBL1LunsF1dmmfkSxiQ0G6s0fYhjnaYZI?=
 =?us-ascii?Q?7dOu5LKFLyGKtRlkFXSdlHqPmDdrYyQbYJl1VRcisIS+9U4K/+krEXBuprS6?=
 =?us-ascii?Q?9DSr9jB5l7udBTt/D/5RB+VDy/V040JEEY07udTF0Kn7kA6ZzntTmox7PZVj?=
 =?us-ascii?Q?JA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b4310b7-48dc-469b-ab22-08dc664b9d65
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 23:50:13.0742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rsnx7/DX6n17KipRUL2poRrgj1yYMrSGTMbn5eeku+VWkpuZ6j7JfkS7ImVt95A104cYl1sWG5RE1GIdBAzCSN0isBd22TH0JxKdSBjgAFA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4573
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> BIOS can configure memory devices as firmware first.  This will send CXL
> events to the firmware instead of the OS.  The firmware can then inform
> the OS of these events via UEFI.
> 
> UEFI v2.10 section N.2.14 defines a Common Platform Error Record (CPER)
> format for CXL Component Events.  The format is mostly the same as the
> CXL Common Event Record Format.  The difference lies in the use of a
> GUID as the CPER Section Type which matches the UUID defined in CXL 3.1
> Table 8-43.
> 
> Currently a configuration such as this will trace a non standard event
> in the log omitting useful details of the event.  In addition the CXL
> sub-system contains additional region and HPA information useful to the
> user.[0]
> 
> The CXL code is required to be called from process context as it needs
> to take a device lock.  The GHES code may be in interrupt context.  This
> complicated the use of a callback.  Dan Williams suggested the use of
> work items as an atomic way of switching between the callback execution
> and a default handler.[1]
> 
> The use of a kfifo simplifies queue processing by providing lock free
> fifo operations.  cxl_cper_kfifo_get() allows easier management of the
> kfifo between the ghes and cxl modules.
> 
> CXL 3.1 Table 8-127 requires a device to have a queue depth of 1 for
> each of the four event logs.  A combined queue depth of 32 is chosen to
> provide room for 8 entries of each log type.
> 
> Add GHES support to detect CXL CPER records.  Add the ability for the
> CXL sub-system to register a work queue to process the events.
> 
> This patch adds back the functionality which was removed to fix the
> report by Dan Carpenter[2].
> 
> [0]
> Link: https://lore.kernel.org/all/cover.1711598777.git.alison.schofield@intel.com/
> [1]
> Link: https://lore.kernel.org/all/65d111eb87115_6c745294ac@dwillia2-xfh.jf.intel.com.notmuch/
> [2]
> Link: https://lore.kernel.org/all/b963c490-2c13-4b79-bbe7-34c6568423c7@moroto.mountain/

Like I mentioned last time, perhaps Dave can reformat these lines on
applying to:

Link: http://lore.kernel.org/r/cover.1711598777.git.alison.schofield@intel.com [0]
Link: http://lore.kernel.org/r/65d111eb87115_6c745294ac@dwillia2-xfh.jf.intel.com.notmuch [1]
Link: http://lore.kernel.org/r/b963c490-2c13-4b79-bbe7-34c6568423c7@moroto.mountain [2]

Other than that, this looks good to me:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>