Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp121114lqa; Fri, 26 Apr 2024 17:07:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWoqsGfglbYraO3UG3iHo9n7rkviqF08VUIJ25/2qBVNiBfh9Hw9PaZmKWsx74X6B4J3WZg+eiSe67xvbpDOJMbwz2HrzfztGOJDQdJlQ== X-Google-Smtp-Source: AGHT+IFERBdkdbrfIGGSATKxr7Tvq1zWecha8LlP9FKlZmt9V8mxU9NKfd+mC2XHKgAyymglDj8Q X-Received: by 2002:a17:906:68c6:b0:a52:6e66:dca4 with SMTP id y6-20020a17090668c600b00a526e66dca4mr3561778ejr.32.1714176447313; Fri, 26 Apr 2024 17:07:27 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id r11-20020a170906c28b00b00a58d633a13csi983470ejz.572.2024.04.26.17.07.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 17:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=XNLK0MSs; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-160796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160796-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E55BD1F25D15 for ; Sat, 27 Apr 2024 00:00:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AFF964AEE6; Fri, 26 Apr 2024 23:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XNLK0MSs" Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C8847F65 for ; Fri, 26 Apr 2024 23:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714175967; cv=none; b=Wpn1FCZfPqcDyrXDGjIvTAMSLDg9Y5Fq/KtyTVutqa/BBbF54L7julMpmLiGHncqn7GqSGIAen/UF0dKVv6eFkq5b0MttrDFaOIAz0x57AOxle5eEqJf59bHu7EXJIboOA3X4V+m+UT7+Z6KJ4kf0wFP4CdT6qcMMJ5HFxSQ0MQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714175967; c=relaxed/simple; bh=Ymkg2Y4zLkJQYeRI3xYMLeWRXgn8akx60R2PPSsy7GE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TZXcWYXPNb/fLJcDHM8awNslisqgS2fs9Zgiy7xWGowQfhl9dtYfyNIPA4OqYY+S2dewdMaBCfAGYYd9VaiZYG7uz9TyvPdmT5br9NZ+ksNoNX24KHIK6ZrVl3wlK1nVHqSzXrp6lLW9l9is8RjRdOmXT6gSgxF2jMLQzmc2nJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=XNLK0MSs; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5c6bd3100fcso1860985a12.3 for ; Fri, 26 Apr 2024 16:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714175962; x=1714780762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6dlue2iwDfflC7NvkUReEv0gDm2tpEeiUAwYd6UUu6I=; b=XNLK0MSsi4bi8Me43W9/EYlQsRNfYgRH4aUUa58z+dr4BDwdJAFE0pb2NbqggxoS+j h4+4uAW/aFWbrCJXMcifSV2XsdXEQfD7qeaXUljvzXRDPuH27X78Hip6zq3mhvMbKgdz CZSY+sYTRMTgpczkhJIACjH6O9qLf24+7GiNw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714175962; x=1714780762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6dlue2iwDfflC7NvkUReEv0gDm2tpEeiUAwYd6UUu6I=; b=MqVYYSqYqOcL298CRhEng0a+cTLTdCTN0Uh8JyVVqyiDnjRvYS733Hr0JUEzC1+mi3 LfABmXMsr7JXTaLxk25aAyy1l/IkeJmdyXbee2/G4YNcywkrnwj8AdJHzaCGBP2uW7X5 PC0fQhMB7NPg3DOrBYiAd9IDvTy2egS/zRqytkyq+vesU1+OTsBs7StyAfQF834SQwmE rLPbK00GCqsDi1GzwsiOtPBtJhjlF+vt3QkMYBQsJ5tZaIQ5vs8vp52IYljIW+vFz5lJ 14gZcGGZxykPdfUCqYh/iRW5FmjKFrYTWWPR3wQK7zTMZ6a2N9yBmFowUZvihJ9lTkk/ 11cg== X-Forwarded-Encrypted: i=1; AJvYcCW0GWPN8hku87oRCOnu9DDqwQLZ7MRUg2Z2kVqjOQcP6ouWfCtuNU89Dxu8PXtruIP+nSnOTr04PCQiYjcXIRfcB978Gp0mvUcnhS28 X-Gm-Message-State: AOJu0Yz5sD1cAr0D8ZeKCS7/3Z/35bbdwcCMngjoc3PAdvMM+oFhMmMH NFIRcmLb4OGYBIWdvQ38zc1FLUggxGb83L2aY7/p69pGDdycmI2nBB9/0I3v9Q== X-Received: by 2002:a17:90b:4ac8:b0:2a2:dd53:828b with SMTP id mh8-20020a17090b4ac800b002a2dd53828bmr3989707pjb.43.1714175960467; Fri, 26 Apr 2024 16:59:20 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:fca:3ae2:20e6:82bb]) by smtp.gmail.com with ESMTPSA id n4-20020a17090aab8400b002af41bd563esm5111939pjq.33.2024.04.26.16.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 16:59:19 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org Cc: Linus Walleij , lvzhaoxiong@huaqin.corp-partner.google.com, Jani Nikula , Hsin-Yi Wang , Javier Martinez Canillas , Neil Armstrong , Joel Selvaraj , Dmitry Baryshkov , Cong Yang , Sam Ravnborg , Douglas Anderson , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: [PATCH v2 7/8] drm/panel: boe-tv101wum-nl6: Don't use a table for initting commands Date: Fri, 26 Apr 2024 16:58:40 -0700 Message-ID: <20240426165839.v2.7.Ib5030ab5cd41b4e08b1958bd7e51571725723008@changeid> X-Mailer: git-send-email 2.44.0.769.g3c40516874-goog In-Reply-To: <20240426235857.3870424-1-dianders@chromium.org> References: <20240426235857.3870424-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Consensus on the mailing lists is that panels shouldn't use a table of init commands but should instead use init functions. With the recently introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy but also saves space. Measuring before/after this change: $ scripts/bloat-o-meter \ .../before/panel-boe-tv101wum-nl6.ko \ .../after/panel-boe-tv101wum-nl6.ko add/remove: 14/8 grow/shrink: 0/1 up/down: 27062/-31433 (-4371) Function old new delta inx_hj110iz_init - 7040 +7040 boe_tv110c9m_init - 6440 +6440 boe_init - 5916 +5916 starry_qfh032011_53g_init - 1944 +1944 starry_himax83102_j02_init - 1228 +1228 inx_hj110iz_init.d - 1040 +1040 boe_tv110c9m_init.d - 982 +982 auo_b101uan08_3_init - 944 +944 boe_init.d - 580 +580 starry_himax83102_j02_init.d - 512 +512 starry_qfh032011_53g_init.d - 180 +180 auo_kd101n80_45na_init - 172 +172 auo_b101uan08_3_init.d - 82 +82 auo_kd101n80_45na_init.d - 2 +2 auo_kd101n80_45na_init_cmd 144 - -144 boe_panel_prepare 592 440 -152 auo_b101uan08_3_init_cmd 1056 - -1056 starry_himax83102_j02_init_cmd 1392 - -1392 starry_qfh032011_53g_init_cmd 2256 - -2256 compoundliteral 3393 - -3393 boe_init_cmd 7008 - -7008 boe_tv110c9m_init_cmd 7656 - -7656 inx_hj110iz_init_cmd 8376 - -8376 Total: Before=37297, After=32926, chg -11.72% Let's do the conversion. Signed-off-by: Douglas Anderson --- Changes in v2: - New .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2712 +++++++++-------- 1 file changed, 1365 insertions(+), 1347 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 0ffe8f8c01de..a3ed33f660cb 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -17,6 +17,8 @@ #include