Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp200056lqa; Fri, 26 Apr 2024 21:32:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXIT7oASljzA/zhnGxhMYatl42cxnEU3wBSDUWnBFg2+n3Z4ebMyJ2nhvwzODr60qbJ17N7Q5SPtiFj9ivWFo2RdGJLgRzGjLn0koW0jQ== X-Google-Smtp-Source: AGHT+IFM/XIt87O1vlN77o6+Z73i7kv++0t5Lbn7tBHPJyvooIhLFOquMnjPKYrZGsD2uMWZsciZ X-Received: by 2002:a05:6358:2802:b0:183:a0ac:b638 with SMTP id k2-20020a056358280200b00183a0acb638mr1755491rwb.11.1714192364529; Fri, 26 Apr 2024 21:32:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714192364; cv=pass; d=google.com; s=arc-20160816; b=pwWlYOxCp80/q9bWVSLbaoZ43sHS5CFVYvtna8LJGGdR3lioXWFL++/etQ+uBHGgCN tUqvqn9QES/Lv+CbIGOtPnBlwe0P1vm1E1W42V6KD2i7kXW81dE8viZzTnDy/SqtEkZi Smko1fXJkcNuDATZ714UoMBwJuPEH5uryo6b3AEXtv9JP5+fKgnLYLv6RAtVGhU7Wp9r aUmmNEp2RK4I/afZUfCqnoD0e3ctEjzx5Qj9qSzizZWe2mPevYq/k05gV6jhs9U3j/79 htZkxZryARb7BOe8Xms1VrmZmeqFYWrU8YNDxBlxiSHzA5QxLqp3CjQMyD+crPhDOtwN Eh7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=oEICw/YBQkHFydzURongpQCI84RNVUsQ3AXdXR1HsB8=; fh=Eq4mxwWnjnDm3gVVqcqT4mVtNNGUOaYhYC6Cc6dQiag=; b=j1658mcnbXXt/hYwH27KGBtp6ag21CrQNpAwcDpzWV6jdL6EcBMrSUsXYuHuzMoc93 EmDhdq7YBRhWA95yc/nqTky3A4RrnB+6CGtaQKIH5B0BL3k6U6ZhQ6ykXDrW1rIdE7sn BCKsoBjmRyLaWwrpjZoYBl6W5JLAkZg7bZCBjiQDqM1G0F/XX6QbxLzoXZHovNh7kWz7 1b2xD1wGC1QWbaefw3yGyTrrhuPvYRu6z8MomudXHSF7l/9sGoGCGVI9rXB2qQY7TV6d wr5BZ4+cn82maYqyoytjSEf/QHzWM/ZYZ8MwOs4SCrEvsQU3mm2G6o6X1LMZWLKBMHha tXFQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=xRE0wDIs; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-160780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160780-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id bw3-20020a056a02048300b005fd895c875bsi11849055pgb.856.2024.04.26.21.32.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 21:32:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-160780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=xRE0wDIs; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-160780-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-160780-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5B43C28356C for ; Fri, 26 Apr 2024 23:46:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8F5B13C488; Fri, 26 Apr 2024 23:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="xRE0wDIs" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08DAF25774; Fri, 26 Apr 2024 23:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714175177; cv=none; b=PqSsUJevJ/eo9X3CEeOKe2Wqi2gHMeTDnDqp1BMYBMsEfh74LW6OwGipu0+GdBBHqdhmmq3npgINqP8IP/xymGHq2cdIYnHQvlfMGnMoM3sbjD8bb4zS0ScXWthbttFVwDcF++ctUj1VdlinAYuPxm5amRuOWWSz3nUqmKsF8nQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714175177; c=relaxed/simple; bh=shcFPaG02bDB4GVRHw+7yeBUIeLQfnWcPP4M6dkAQO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gbXzjsBjvzT5KYAyJWpDZkCTg/rkMqqVycTH1k2zwuhRjFg+D2ry/uC2JucH6n6sTZDDYjaEYLIoUhuTUEVD2xPkRTl0mFTKZx+b4ZCaSftSk/3sxGmvUD3XL7xhS9jCg8Q3z721OqQIXLSW1G9mDQjuHcMSlBfa1COa8x1bfeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=xRE0wDIs; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oEICw/YBQkHFydzURongpQCI84RNVUsQ3AXdXR1HsB8=; b=xRE0wDIs5SY5sV0mNmw7sdP037 4tOO5LC8H0SVowqjZeSy9lYEmZJYVFvcjBVXyNnehBzVqXcRwDjohOENq26j/98PrZkhAQP8qNrJk yCEbmT7DXmmwydHutCZPtO8vBDheohXL91jYHolL5nYoy4K3FU6Yga6nYPJDS7xoxVmzZ+toNricm rbnAabsp0fEd8cxbBi5hivc2rBXSDUMrSCkjDWPqh995LL41quiI2FQlmVNsIN+/4sJ2MbjmxH/84 5V3qxlcw9ou7VzvTUNMijxpdELciJt92Q3k7USXxzcUqmtDSBiRLbbpsTcdUxolacCAGcNUZzPxlj ZeWjDZyg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0VGd-0000000EOAk-0VYk; Fri, 26 Apr 2024 23:46:11 +0000 Date: Fri, 26 Apr 2024 16:46:11 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: "Pankaj Raghav (Samsung)" , djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 05/11] mm: do not split a folio if it has minimum folio order requirement Message-ID: References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-6-kernel@pankajraghav.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain On Thu, Apr 25, 2024 at 05:47:28PM -0700, Luis Chamberlain wrote: > On Thu, Apr 25, 2024 at 09:10:16PM +0100, Matthew Wilcox wrote: > > On Thu, Apr 25, 2024 at 01:37:40PM +0200, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav > > > > > > using that API for LBS is resulting in an NULL ptr dereference > > > error in the writeback path [1]. > > > > > > [1] https://gist.github.com/mcgrof/d12f586ec6ebe32b2472b5d634c397df > > > > How would I go about reproducing this? > > Using kdevops this is easy: > > make defconfig-lbs-xfs-small -j $(nproc) > make -j $(nproc) I forgot after the above: make bringup > make fstests > make linux > make fstests-baseline TESTS=generic/447 COUNT=10 > tail -f guestfs/*-xfs-reflink-16k-4ks/console.log The above tail command needs sudo prefix for now too. > or > sudo virsh list > sudo virsh console ${foo}-xfs-reflink-16k-4ks > > Where $foo is the value of CONFIG_KDEVOPS_HOSTS_PREFIX in .config for > your kdevops run. > > I didn't have time to verify if the above commands for kdevops worked I did now, I forgot to git push commits to kdevops yesterday but I confirm the above steps can be used to repdroduce this issue now. Luis