Received-SPF: pass (google.com: domain of linux-kernel+bounces-160911-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <002340b7-86e2-4be3-8468-71d59233c32e@intel.com>
Date: Fri, 26 Apr 2024 22:38:49 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency
To: Reinette Chatre <reinette.chatre@intel.com>, isaku.yamahata@intel.com,
 pbonzini@redhat.com, erdemaktas@google.com, vkuznets@redhat.com,
 seanjc@google.com, vannapurve@google.com, jmattson@google.com,
 mlevitsk@redhat.com, xiaoyao.li@intel.com, chao.gao@intel.com,
 rick.p.edgecombe@intel.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1714081725.git.reinette.chatre@intel.com>
 <eac8c5e0431529282e7887aad0ba66506df28e9e.1714081726.git.reinette.chatre@intel.com>
 <f5a80896-e1aa-4f23-a739-5835f7430f78@intel.com>
 <12445519-efd9-42e9-a226-60cfa9d2a880@intel.com>
Content-Language: en-US
From: "Chen, Zide" <zide.chen@intel.com>
In-Reply-To: <12445519-efd9-42e9-a226-60cfa9d2a880@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/26/2024 4:26 PM, Reinette Chatre wrote:
> Hi Zide,
> 
> On 4/26/2024 4:06 PM, Chen, Zide wrote:
>>
>>
>> On 4/25/2024 3:07 PM, Reinette Chatre wrote:
>>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>> new file mode 100644
>>> index 000000000000..5100b28228af
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>> @@ -0,0 +1,166 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Test configure of APIC bus frequency.
>>> + *
>>> + * Copyright (c) 2024 Intel Corporation
>>> + *
>>> + * To verify if the APIC bus frequency can be configured this test starts
>>
>> Nit: some typos here?
> 
> Apologies but this is not obvious to me. Could you please help
> by pointing out all those typos to me?

Do you think it's more readable to add a ","?

- * To verify if the APIC bus frequency can be configured this test starts
+ * To verify if the APIC bus frequency can be configured, this test starts
  * by setting the TSC frequency in KVM, and then: