Received-SPF: pass (google.com: domain of linux-kernel+bounces-161044-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 27 Apr 2024 17:20:14 +0530
From: Manivannan Sadhasivam <mani@kernel.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
	Qiang Yu <quic_qianyu@quicinc.com>, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	quic_cang@quicinc.com, quic_mrana@quicinc.com
Subject: Re: [PATCH v5 1/3] bus: mhi: host: Add sysfs entry to force device
 to enter EDL
Message-ID: <20240427115014.GP1981@thinkpad>
References: <1713928915-18229-1-git-send-email-quic_qianyu@quicinc.com>
 <1713928915-18229-2-git-send-email-quic_qianyu@quicinc.com>
 <20240425145450.GH3449@thinkpad>
 <e0fb41f3-3080-c1b5-ab7c-bcff8bbbe754@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e0fb41f3-3080-c1b5-ab7c-bcff8bbbe754@quicinc.com>

On Thu, Apr 25, 2024 at 09:07:37AM -0600, Jeffrey Hugo wrote:
> On 4/25/2024 8:54 AM, Manivannan Sadhasivam wrote:
> > On Wed, Apr 24, 2024 at 11:21:53AM +0800, Qiang Yu wrote:
> > > Add sysfs entry to allow users of MHI bus force device to enter EDL.
> > > Considering that the way to enter EDL mode varies from device to device and
> > > some devices even do not support EDL. Hence, add a callback edl_trigger in
> > > mhi controller as part of the sysfs entry to be invoked and MHI core will
> > > only create EDL sysfs entry for mhi controller that provides edl_trigger
> > > callback. All of the process a specific device required to enter EDL mode
> > > can be placed in this callback.
> > > 
> > > Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> > > Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> > 
> > All 3 patches are applied to mhi-next with my reported changes! Since you are
> > doing upstreaming for some time, you should know that the changelog _must_ be
> > present in the patches itself or in the cover letter.
> 
> It is/was in the cover letter.  Was the format not to your liking?
> 

Hmm, it didn't land in my inbox. Maybe my filter did something. Apologies for
the false statement.

- Mani

-- 
மணிவண்ணன் சதாசிவம்