Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758712AbYA1JQP (ORCPT ); Mon, 28 Jan 2008 04:16:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752799AbYA1JP7 (ORCPT ); Mon, 28 Jan 2008 04:15:59 -0500 Received: from nat-132.atmel.no ([80.232.32.132]:60670 "EHLO relay.atmel.no" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750776AbYA1JP5 convert rfc822-to-8bit (ORCPT ); Mon, 28 Jan 2008 04:15:57 -0500 Date: Mon, 28 Jan 2008 10:15:51 +0100 From: Haavard Skinnemoen To: Andrew Morton Cc: David Brownell , Andrew Victor , Nicolas Ferre , Patrice Vilchez , Richard Purdie , linux-kernel@vger.kernel.org, kernel@avr32linux.org, David Brownell Subject: Re: [PATCH -mm 2/2] PWM LED driver Message-ID: <20080128101551.7cbc7af5@dhcp-252-066.norway.atmel.com> In-Reply-To: <20080127213232.ade044d5.akpm@linux-foundation.org> References: <1201185225-15789-1-git-send-email-hskinnemoen@atmel.com> <1201185225-15789-2-git-send-email-hskinnemoen@atmel.com> <1201185225-15789-3-git-send-email-hskinnemoen@atmel.com> <20080127213232.ade044d5.akpm@linux-foundation.org> Organization: Atmel Norway X-Mailer: Claws Mail 3.2.0 (GTK+ 2.12.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1871 Lines: 66 On Sun, 27 Jan 2008 21:32:32 -0800 Andrew Morton wrote: > On Thu, 24 Jan 2008 15:33:45 +0100 Haavard Skinnemoen wrote: > > > + if (i > 0) { > > + for (i = i - 1; i >= 0; i--) { > > + led_classdev_unregister(&leds[i].cdev); > > + pwm_channel_free(&leds[i].pwmc); > > + } > > + } > > Could be: > > while (--i > 0) { > led_classdev_unregister(&leds[i].cdev); > pwm_channel_free(&leds[i].pwmc); > } > > or thereabouts. Almost...we need to clean up for leds[0] too. Using a postfix decrement should take care of that. How about the patch below? Haavard >From de5002ad71a1000f81817410f02a7d9fbd5d4ecd Mon Sep 17 00:00:00 2001 From: Haavard Skinnemoen Date: Mon, 28 Jan 2008 10:14:14 +0100 Subject: [PATCH] PWM led driver: Simplify cleanup loop Why use a for loop inside an if() when we can get away with a simple while() loop? Signed-off-by: Haavard Skinnemoen --- drivers/leds/leds-atmel-pwm.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-atmel-pwm.c b/drivers/leds/leds-atmel-pwm.c index af61f55..187031c 100644 --- a/drivers/leds/leds-atmel-pwm.c +++ b/drivers/leds/leds-atmel-pwm.c @@ -100,11 +100,9 @@ static int __init pwmled_probe(struct platform_device *pdev) return 0; err: - if (i > 0) { - for (i = i - 1; i >= 0; i--) { - led_classdev_unregister(&leds[i].cdev); - pwm_channel_free(&leds[i].pwmc); - } + while (i-- > 0) { + led_classdev_unregister(&leds[i].cdev); + pwm_channel_free(&leds[i].pwmc); } kfree(leds); -- 1.5.3.8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/