Received-SPF: pass (google.com: domain of linux-kernel+bounces-161050-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 27 Apr 2024 15:22:25 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Slark Xiao <slark_xiao@163.com>
Cc: loic.poulain@linaro.org, ryazanov.s.a@gmail.com,
	johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH net] net: wwan: Add net device name for error message
 print
Message-ID: <56b839fb-6a69-4dff-b412-1960e98fcbf2@lunn.ch>
References: <20240426080733.819633-1-slark_xiao@163.com>
 <6f7c4b67-a6bd-4fc2-a7da-e4bb0c2b6f50@lunn.ch>
 <c5a7151.250c.18f1e4425f4.Coremail.slark_xiao@163.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c5a7151.250c.18f1e4425f4.Coremail.slark_xiao@163.com>

> At 2024-04-27 06:21:03, "Andrew Lunn" <andrew@lunn.ch> wrote:
> >>  	if (skb->len < sizeof(struct usb_cdc_ncm_nth16) +
> >>  			sizeof(struct usb_cdc_ncm_ndp16)) {
> >> -		net_err_ratelimited("frame too short\n");
> >> +		net_err_ratelimited("mbim: frame too short\n");
> >
> >I don't know this code at all, but i think you can do
> >
> >dev_err_ratelimited(&mbim->mdev->dev, "frame too short\n");
> >
> >That way, it tells you which of the 42 mhi devices has received too
> >short a frame.
> >
> >      Andrew
> I tried in my case, and it will print:
> mhi_wwan_mbim mhio_IP_HW0_MBIM: frame too short
> 
> I think it's much more complicated, isn't it?

As i said, this is about making it clear which device has problems.
mhio_IP_HW0_MBI is not a particularly good name, but it should be
unique. The question is, is this built into the silicon, and can there
only be one? The name is them pointless.

It is also not too unusual to see drivers define macros

mbim_err_ratelimited(mbin, "frame too short")

	Andrew