Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp428883lqa; Sat, 27 Apr 2024 07:58:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU7qQGxx5mRHK1eV058c0WHNSa3/u95iKQ8X0FEn4fVgK3TtYBt6I6gH7hjALtFtr77vVHDiEGfwojwu7E6l0rM/9lDxHtYep7GlQ72Vw== X-Google-Smtp-Source: AGHT+IE7NXVTXNUolScInoZbyGf8JaFmrFYZBC6Pq2gu4L3Z9Mpb1N4mQjflggY5UATXxJwzSEfh X-Received: by 2002:a25:ac5d:0:b0:de5:549b:dca3 with SMTP id r29-20020a25ac5d000000b00de5549bdca3mr6274598ybd.12.1714229893833; Sat, 27 Apr 2024 07:58:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714229893; cv=pass; d=google.com; s=arc-20160816; b=Nu5tDmE8kg335qgfRCd8SGmMHSFb3htxqWSSMCOkSzB7U9m72y9go4KH7JpVMvg/fa 7brIo51OIiwc5MU7YXg3lX/Etff8TOsHUlmxYg4gVVcKVGkdi0wtVAEZAi0UjpBdLO5V bY2MrxVBhAE9Z41E8ok/ZfsAqnetXC63OSiKqaygTMQXTx8hFUDOae4g+jmxdtXAjyH1 /VlNBW7GYjOpIBPxZVYypyEfkhIarx4o6Ux6YHRZFoi6Mb9M98H3c5YiklsCsJTYFl5O Bm9T7vNP37lOToN9tzfKt3A5wMHbzuL0bkdUZFlbfu7CANSeL0zRtvVywAL3rWsSL/59 Vwhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SAvWi28tS9Fzn0xXe26WIQie+hHDCS4rBZm/RVjXBGw=; fh=a4I7Ys5oE3okdNDX3WfuehWNsB6aWtsAVn5VOr7PoNs=; b=owpMgMDbBpfiEZOsZ6gLUBRyLVQMIjasCfOkIVlA1W6rBCoW5j+53ifjhgr7ltkphW xGe+Wk6boCJH3CsT0+UrL5JRHyPNS15tqU+pS23lgpJ0cAMPe8I+06xoeuRxrVmn2muw 9I5fkp3ZM9GiwBgr1nSLsb+kmFIhE2UVW6Gi/7uHyw7AHC+gOd+42l8rLC7TW5PmzM1D xtQxMUcfwkXp2MUSq4xbVIOevAs0AoDyS8j4bK+gl8/flWhctzS4YQcmBz3LCWlskDAm 9yfSuXeX9cSC2ebmYvT/Anjb9zc19ZDCnjUGP2qDVr2s7xhsP2/z1fbxN3ALq8h1QEdw YHzg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cv6mmH0F; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-161075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e9-20020ac85dc9000000b004398122b4b2si17437425qtx.480.2024.04.27.07.58.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 07:58:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-161075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cv6mmH0F; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-161075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F93C1C21597 for ; Sat, 27 Apr 2024 14:57:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6EE4263D5; Sat, 27 Apr 2024 14:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cv6mmH0F" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93E1C5660; Sat, 27 Apr 2024 14:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714229810; cv=none; b=r4ufM4R23cKD3b1h6MBXqM3C5Bx2FV5J+ZD0rFm+jFosZkYvkTv5vP2K7/ZHdeCTdQVIK1GgfrIgFlsmVlwqFDPXNcZxXIPiv6NyFKqeV31dd22EV7EFn49W3ogDX6H0OHXArVADLXnqv1l/q64yvOYmBjTQJKgRMUf4pNmM/k8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714229810; c=relaxed/simple; bh=f75jXn+JImVzW04XSBfpbAqM9Xc3DVOREU6CXnC59uY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Eey0OAQlzfGvAO75m1tr+KQ/mnkPYaiXZv52k9CioWBRZPnowqN339n19gIu/4cH1kOoirYekGOsfDdhKVWuojuFA9dQuzHbTqqUVUOjpdiHDPJoMtakc0XR7uUeeT6S6P5g2cvuq7XIfmpjWkoAJH6myAciktPN9L0ShBbTcS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cv6mmH0F; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DF92C2BD10; Sat, 27 Apr 2024 14:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714229810; bh=f75jXn+JImVzW04XSBfpbAqM9Xc3DVOREU6CXnC59uY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cv6mmH0FaySGo8/F3+Qfou1j8kxBPCoudQ1Xqj6l1pidEVhFDbr/Zgl8NBaJbUlCh uBMbKw3l/dtFsX9tgChPvU/l2vy1pnr0WbY1HY2uGaZ082qWYeKbUDQg5lkZdUcugq 0uCPJGoe3JbRAVm4KNBb5UjdkdCq7L/9mrxTJqK3n4gzjIAqqAa1V8AelfmkwJFsQS Q5bk4nw8RaTiz3vUK7cPD85qs2/OmYUAMVSGNJAHrqqLnHGdZferHqu3sjCkZDhStd TvvQ4vpuDJAo7MhIDgkO+3xzQVkIwDnVD+yWIoGTKL8Qq2wm03SLfIeXwvMkJ75mMx ispyGRaEb03/Q== Date: Sat, 27 Apr 2024 15:56:45 +0100 From: Simon Horman To: Ivan Vecera Cc: netdev@vger.kernel.org, Michal Schmidt , Tony Nguyen , Pucha Himasekhar Reddy , Jesse Brandeburg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: Re: [PATCH net-next v4 5/7] i40e: Consolidate checks whether given VSI is main Message-ID: <20240427145645.GQ516117@kernel.org> References: <20240427072615.226151-1-ivecera@redhat.com> <20240427072615.226151-6-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427072615.226151-6-ivecera@redhat.com> On Sat, Apr 27, 2024 at 09:26:06AM +0200, Ivan Vecera wrote: > In the driver code there are 3 types of checks whether given > VSI is main or not: > 1. vsi->type ==/!= I40E_VSI_MAIN > 2. vsi ==/!= pf->vsi[pf->lan_vsi] > 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid > > All of them are equivalent and can be consolidated. Convert cases > 2 and 3 to case 1. > > Reviewed-by: Michal Schmidt > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman