Received-SPF: pass (google.com: domain of linux-kernel+bounces-161105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 27 Apr 2024 09:49:41 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Lukas Wunner <lukas@wunner.de>, Dan Williams <dan.j.williams@intel.com>
CC: <gregkh@linuxfoundation.org>, Pierre-Louis Bossart
	<pierre-louis.bossart@linux.intel.com>, Marc Herbert
	<marc.herbert@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-coco@lists.linux.dev>, <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/3] sysfs: Fix crash on empty group attributes array
Message-ID: <662d2ca522cc6_b6e02942d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <170863444851.1479840.10249410842428140526.stgit@dwillia2-xfh.jf.intel.com>
 <170863445442.1479840.1818801787239831650.stgit@dwillia2-xfh.jf.intel.com>
 <ZiYrzzk9Me1aksmE@wunner.de>
 <662beb6ad280f_db82d29458@dwillia2-xfh.jf.intel.com.notmuch>
 <Ziv9984CJeQ4muZy@wunner.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Ziv9984CJeQ4muZy@wunner.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NIiBvEnRjxXqu9NrEbW0Sn5V19Q5Dg3zDGeMg9I7n4GyMNmsK0q0NYK+IeKC?=
 =?us-ascii?Q?ijVCMiuuAuvW6LQ4t8f2gcgmjBi5X2/wlNr/vd2a2taFvP+Q0OuAiGl4bw2s?=
 =?us-ascii?Q?LNCYWmEUtiPlhri/xdiOdT2nGm8lURFRL8RyteagxH6Go1UGMrmDNULBhKSg?=
 =?us-ascii?Q?8Ui1rmF5r718nWKEadzhFlCCRpU67FyGgPTUflCmRltsHBjC4Oq2MxXgSt5Q?=
 =?us-ascii?Q?HQen9hFnomXHWkjzA/M4wy5UP2ihizIaXvPe+xRka2hiVWDjFvmVaimYGXwR?=
 =?us-ascii?Q?c6Eo1COt9W+WhEVXEHjaKFXuPhuQIYkRFwzZCNu+BNyVcQRD9/YaitHR/rWw?=
 =?us-ascii?Q?4DDUk60NXidhNrMbIZXhDqA+fJx4ey17wpHulOTPIW0wZunBtfgnT5CBgo/2?=
 =?us-ascii?Q?J5a8vtjrcAMnbNRilMaNQLzlnNr7E2FIaXBbI15jcQb8VHtu8JNqr2WAh1CF?=
 =?us-ascii?Q?MRTwHqvXvh5X9NDiaT5GF+tB/vR2Oyr6tSCpnpNvggOvTJEEsP6c5iqeI8F1?=
 =?us-ascii?Q?yW6BFTKzmM3rAeGw7F9xRTZ8A0iZZ5RfupxJIevQKRaH5BMMUhbhEayjt+ZN?=
 =?us-ascii?Q?BIpx8hSQIWG5t6Hb9SPPz/UVjf5FGhLKYp4GwFsSGKiV5D2mt1bGsTMLvryh?=
 =?us-ascii?Q?t0snbPDtRzvWynwrEP3rgd30SFpvXn+iLpfpTcbkmXTQW6WJ8fTpwf4NG/u1?=
 =?us-ascii?Q?tMXcJGq1qoKUIvxXbpEqPvMWyE/+1NQMSMtX692PdCwT6jiZ049Yi36gYzq5?=
 =?us-ascii?Q?QWlM4JFv7hX06wP76og6zrk7TMcE7k1qTo9fTX7t9dJNLBIrlQWcU252zGsV?=
 =?us-ascii?Q?EOAwzOyytSy3vvausJxdCKwb7hwpxPy3a8M+8+P9/7m5WORmgrxISJCE7tc+?=
 =?us-ascii?Q?uxtWQJZfAiDJKc5mqHqiHwjoP45I1nUh0jh8YvKr7gJEeFU/BOQl3ixR4bUU?=
 =?us-ascii?Q?rxmWGNmmYt/6twOwh46Hdb/C0nZX/JJC7B0NDi9ehT1rC1xv83/dG1pvANx0?=
 =?us-ascii?Q?6Ug0afpWOmsuszoxjDZUeXptF9DbJ8qw3IPprSR4Ug4Y9cHrWqQtz3GDS4yj?=
 =?us-ascii?Q?+hcu1DwfZaPb0Pw1956sLu9jehidAE1+hYJGWTpQtC4owHyNau3tovLAK10k?=
 =?us-ascii?Q?lsMRvVl+X3r2pUnu0qJtcHMmRYn3HQE3c6quE1wl+RhnAfHzSw/ZlukJL7y9?=
 =?us-ascii?Q?G1QGUMEVT4GPG2xD3JH20ddWgTm4VJAO8BVVLXo4jsZvWjcEhZ4uHWc2P/ON?=
 =?us-ascii?Q?hZsgoMJMfEEgjS5z0T5PMihFftfhwhjjV4S+n6h3pH+g5qyif1o8ui7JVB8S?=
 =?us-ascii?Q?/zRgzuc2iZlTsEdpsQ4fCeDpeSdMb22lzgROATytlO5jE6DkQliDD7IBoKlp?=
 =?us-ascii?Q?RP8vIuayRUPbJewOPBEeqDgwHK6y0hVCKDx9Dy+JAxze4G9RX/uve45gCEWU?=
 =?us-ascii?Q?e+IzpJ4Lv2b/o61yM9aP4yhds40H98EfF0u3xd/edPXencOZfq7Q5ko/gYpe?=
 =?us-ascii?Q?7Ds4EQPU5VeAISR+nNekpcDjO/tN2i4J0xPi1bhpgNw/PKif8DjgoOeganjE?=
 =?us-ascii?Q?P8MqQENf3hgUJL4QOR1+h7/oqN6muRG62MYll4T+oFVk1vLS18CN8xwI4V0q?=
 =?us-ascii?Q?1A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 20afa590-d5a5-409c-0028-08dc66da0a2b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2024 16:49:44.0303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M4gc1KuvIyeMMmOfg9zGelFsHcyKt6SEJe7qQhBTj9GXAMckBoEdVjLeslacrpD2bo58D2BtviBoKb9df7zPy27y7suhH/rB+LqJX6HmRFY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8758
X-OriginatorOrg: intel.com

Lukas Wunner wrote:
[..]
> So in this case I'm able to dodge the bullet because the empty
> signatures/ directory for CMA-incapable devices is only briefly
> visible in the series.  Nobody will notice unless they apply
> only a subset of the series.
> 
> But I want to raise awareness that the inability to hide
> empty attribute groups feels awkward.

That is fair, it was definitely some gymnastics to only change user
visible behavior for new "invisible aware" attribute groups that opt-in
while leaving all the legacy cases alone.

The concern is knowing when it is ok to call an is_visible() callback
with a NULL @attr argument, or knowing when an empty array actually
means "hide the group directory".

We could add a sentinel value to indicate "I am an empty attribute list
*AND* I want my directory hidden by default". However, that's almost
identical to requiring a placeholder attribute in the list just to make
__first_visible() happy.

Other ideas? I expect this issue to come up again because dynamically
populated attribute arrays of a statically defined group is a useful
mechanism. I might need this in the PCI TSM enabling... but having at
least one attribute there is likely not a problem.