Received-SPF: pass (google.com: domain of linux-kernel+bounces-161134-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Sat, 27 Apr 2024 12:09:45 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: implement filesystem specific alloc_inode in unit
 test
Message-ID: <cdeaa9ac-b3aa-4951-9c34-4b4ae71df89d@roeck-us.net>
References: <20240322165518.8147-1-shikemeng@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322165518.8147-1-shikemeng@huaweicloud.com>

Hi,

On Sat, Mar 23, 2024 at 12:55:18AM +0800, Kemeng Shi wrote:
> We expect inode with ext4_info_info type as following:
> mbt_kunit_init
>   mbt_mb_init
>     ext4_mb_init
>       ext4_mb_init_backend
>         sbi->s_buddy_cache = new_inode(sb);
>         EXT4_I(sbi->s_buddy_cache)->i_disksize = 0;
> 
> Implement alloc_inode ionde with ext4_inode_info type to avoid
> out-of-bounds write.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> ---

Ths problem fixed by this patch still affects the mainline kernel,
and is often fatal there if CONFIG_EXT4_KUNIT_TESTS is enabled
due to memory corruptions. Is there a chance to get it applied soon,
or should I just disable CONFIG_EXT4_KUNIT_TESTS for good ?

Thanks,
Guenter