Received-SPF: pass (google.com: domain of linux-kernel+bounces-161152-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240426103528.406063-1-chao@kernel.org> <CACOAw_xiC08JTanBSLaBED8_zveCEhoaDWeJ3YVU0h9+dNkQUg@mail.gmail.com>
 <a08a091b-78d1-4fb1-982c-c51d9dff8f06@kernel.org>
In-Reply-To: <a08a091b-78d1-4fb1-982c-c51d9dff8f06@kernel.org>
From: Daeho Jeong <daeho43@gmail.com>
Date: Sat, 27 Apr 2024 12:50:48 -0700
Message-ID: <CACOAw_xuX-J=J5zYwK5kVxPGZWPa+KXBxQA2i-taPwzS2ds-aQ@mail.gmail.com>
Subject: Re: [PATCH] f2fs: zone: fix to don't trigger OPU on pinfile for
 direct IO
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 6:49=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/4/26 22:14, Daeho Jeong wrote:
> > On Fri, Apr 26, 2024 at 3:35=E2=80=AFAM Chao Yu <chao@kernel.org> wrote=
:
> >>
> >> Otherwise, it breaks pinfile's sematics.
> >>
> >> Cc: Daeho Jeong <daeho43@gmail.com>
> >> Signed-off-by: Chao Yu <chao@kernel.org>
> >> ---
> >>   fs/f2fs/data.c | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> >> index bee1e45f76b8..e29000d83d52 100644
> >> --- a/fs/f2fs/data.c
> >> +++ b/fs/f2fs/data.c
> >> @@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct =
f2fs_map_blocks *map, int flag)
> >>
> >>          /* use out-place-update for direct IO under LFS mode */
> >>          if (map->m_may_create &&
> >> -           (is_hole || (f2fs_lfs_mode(sbi) && flag =3D=3D F2FS_GET_BL=
OCK_DIO))) {
> >> +           (is_hole || (flag =3D=3D F2FS_GET_BLOCK_DIO && (f2fs_lfs_m=
ode(sbi) &&
> >> +           (!f2fs_sb_has_blkzoned(sbi) || !f2fs_is_pinned_file(inode)=
))))) {
> >>                  if (unlikely(f2fs_cp_error(sbi))) {
> >>                          err =3D -EIO;
> >>                          goto sync_out;
> >> --
> >> 2.40.1
> >
> > So, we block overwrite io for the pinfile here.
>
> I guess you mean we blocked append write for pinfile, right?
>
> >
> > static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter=
 *from)
> >
> > {
> > ...
> >          if (f2fs_is_pinned_file(inode) &&
> >              !f2fs_overwrite_io(inode, pos, count)) {
>
> If !f2fs_overwrite_io() is true, it means it may trigger append write on
> pinfile?

Yes, I missed it. Thanks~

>
> Thanks,
>
> >                  ret =3D -EIO;
> >                  goto out_unlock;
> >          }
> >
> >
> >>