Received-SPF: pass (google.com: domain of linux-kernel+bounces-161161-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 27 Apr 2024 21:22:23 +0100
From: Conor Dooley <conor@kernel.org>
To: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez <ramon.nordin.rodriguez@ferroamp.se>
Cc: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com,
	anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, andrew@lunn.ch, corbet@lwn.net,
	linux-doc@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, horatiu.vultur@microchip.com,
	ruanjinjie@huawei.com, steen.hegelund@microchip.com,
	vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com,
	Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com,
	Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com,
	benjamin.bigler@bernformulastudent.ch
Subject: Re: [PATCH net-next v4 11/12] microchip: lan865x: add driver support
 for Microchip's LAN865X MAC-PHY
Message-ID: <20240427-attention-negate-a3b6ede708d7@spud>
References: <20240418125648.372526-1-Parthiban.Veerasooran@microchip.com>
 <20240418125648.372526-12-Parthiban.Veerasooran@microchip.com>
 <Zi1PxgANUWh1S0sO@builder>
 <20240427-vaporizer-pencil-be6a25030f08@spud>
 <Zi1cbScrKzFN3PNT@builder>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Ht22igVR9zkqfURh"
Content-Disposition: inline
In-Reply-To: <Zi1cbScrKzFN3PNT@builder>


--Ht22igVR9zkqfURh
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 27, 2024 at 10:13:33PM +0200, Ram=F3n Nordin Rodriguez wrote:
> On Sat, Apr 27, 2024 at 08:57:43PM +0100, Conor Dooley wrote:
> > >  static const struct of_device_id lan865x_dt_ids[] =3D {
> > > -       { .compatible =3D "microchip,lan8651", "microchip,lan8650" },
> >=20
> > Huh, that's very strange. I don't see a single instance in the tree of a
> > of_device_id struct like this with two compatibles like this (at least
> > with a search of `rg "\.compatible.*\", \"" drivers/`.
> >=20
> > Given the fallbacks in the binding, only "microchip,lan8650" actually
> > needs to be here.
> >=20
> > > +       { .compatible =3D "microchip,lan865x", "microchip,lan8650" },
> > >         { /* Sentinel */ }
> > >  };
> > >  MODULE_DEVICE_TABLE(of, lan865x_dt_ids);
> > >=20
> > > Along with compatible =3D "microchip,lan865x" in the dts
> >=20
> > Just to be clear, the compatible w/ an x is unacceptable due to the
> > wildcard and the binding should stay as-is. Whatever probing bugs
> > the code has need to be resolved instead :)
> >=20
>=20
> All right, so when I change to
>=20
> @@ -364,7 +364,7 @@ static void lan865x_remove(struct spi_device *spi)
>  }
>=20
>  static const struct of_device_id lan865x_dt_ids[] =3D {
> -       { .compatible =3D "microchip,lan8651", "microchip,lan8650" },
> +       { .compatible =3D "microchip,lan8650" },
>         { /* Sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, lan865x_dt_ids);
>=20
> I still get the output
> [    0.124266] SPI driver lan865x has no spi_device_id for microchip,lan8=
650
> But the driver does probe and I get a network interface.
>=20
> If no one beats me to it I'll single step the probe tomorrow.

I think the error pretty much is what it says it is, the driver doesn't
appear to have a spi_device_id table containing lan8650. The name of
the driver is lan685x which is used in the fallback clause in
__spi_register_driver(), so it complains as it does not find lan8650 in
either. If my understanding is correct, either a spi_device_id table is
required or the driver needs a rename with s/x/0/.

Cheers,
Conor.

--Ht22igVR9zkqfURh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZi1efwAKCRB4tDGHoIJi
0jDsAP0cItUc6sedwNS3eRcU7KmYLY9HiiA9Ch9O5PlNtGXuWQEArfmeqLOOooG1
PK0PZHRsFJKKp9IKbHS+rjwURy4eFgg=
=s9NR
-----END PGP SIGNATURE-----

--Ht22igVR9zkqfURh--