Received-SPF: pass (google.com: domain of linux-kernel+bounces-161216-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Peng Fan <peng.fan@nxp.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
CC: Aisheng Dong <aisheng.dong@nxp.com>, Andi Shyti <andi.shyti@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam
	<festevam@gmail.com>, "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 05/15] i2c: imx-lpi2c: use 'time_left' variable with
 wait_for_completion_timeout()
Thread-Topic: [PATCH 05/15] i2c: imx-lpi2c: use 'time_left' variable with
 wait_for_completion_timeout()
Thread-Index: AQHamOLBM1HAo2q+mUaE1E5f9ItMOLF86Y3Q
Date: Sun, 28 Apr 2024 01:45:12 +0000
Message-ID:
 <DU0PR04MB941778B81FB5524CF943E96888142@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240427203611.3750-1-wsa+renesas@sang-engineering.com>
 <20240427203611.3750-6-wsa+renesas@sang-engineering.com>
In-Reply-To: <20240427203611.3750-6-wsa+renesas@sang-engineering.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?xbMq4gw417YiGd4TQEZn7m4387pyhLGYwbJUpvfK5iERBeirXm2tHQiICtZb?=
 =?us-ascii?Q?Z58x7r5BDBB/q6/INx1M+DnfFm7OLWL9bjGQvpQ/rYqDSMisG+ZoQGNovAdl?=
 =?us-ascii?Q?6nEKogCX3X5iq0DCYjOiX+U3baqvUKl29MC1LWcx9x0bxmFKw7w6PVMcUmqq?=
 =?us-ascii?Q?1aKaxNfpGna9wNeWqo6q6k6nV2j9Tj30fTKGuvpub/Ae0j0b/M7IFME8Rxcx?=
 =?us-ascii?Q?7YpZF1rSUYTnb44WqnwRcHL9dfp8r4YaCQr4ZCWI+tFK3W9JXbyDMgFGP9JO?=
 =?us-ascii?Q?SoWLm4Hdh7eTwSu6SpMsRG5pUinQHQUldkHHHzv26iirEMu9FdMe7PPSvnaW?=
 =?us-ascii?Q?b28DOPtJGaF4hNqG1GwvZhZ+jMlfFSp3VI4asZ0GcPBr2VngBCrtBG4Vceba?=
 =?us-ascii?Q?CvzuKnIPRI4OBLldslXw3w7iDe1Q+AGx4mkF/c0TLA2iWV/htlPvziFGUXz6?=
 =?us-ascii?Q?bZG2MqLrspD8ZPmV83soqL0bpMN1ZMMBofNDxYmL5sQuobzN5KQcviUgsBNR?=
 =?us-ascii?Q?p43ZPxXM+UebSk22DOJTkg64ZdenoneU7uwshIqa52jsS5i1OLzw2BnMSrPj?=
 =?us-ascii?Q?5A/RHFy6vSJRrQAyeMnNaxteOG1bAUqkGG8TsSsf5f7PM+NvHJj/XYY1Ys9h?=
 =?us-ascii?Q?L/oZUGu1a5V5rPAeDFA7fUtTZI+tfJmiM2ypBOnkKwa+ndABQSUuxMmJs5ko?=
 =?us-ascii?Q?lFKij5AMci8HY/G/I6Nnnrk4FWYpbIXoLz1rInWj/uCN4JQpoJw+nWWGPji7?=
 =?us-ascii?Q?eZeRSN67YM/DXRu4KH1T/nzTa8Lc+LP+Ub9CNzwP/yzoLheU/hf+VCfHD4U7?=
 =?us-ascii?Q?28kOhsfOmxMtquXmIFv8fxNQKoatcloQ+CgaHBwqd91G67ZxM+511uaZ3F9+?=
 =?us-ascii?Q?0Tq+fd5/g/SuDtYBDY62xiY7LoVGmQjuYy+LV62+nUUjR6I1S7My1UDhvVqm?=
 =?us-ascii?Q?iLkrDemnmjpBydrFH/e32ZiSt+EV3+U412rJ3D8QUSqsv+YhX3mg/XneR7v4?=
 =?us-ascii?Q?9tU7c2iwkZGgZmqz5G5oiOMWvJh+wGwpetWTVBkXxNfpQSCA64JlY+PGTrbr?=
 =?us-ascii?Q?jWRw6amWzYR6MW5CBir6dq6To6aDqNx9/Ba27SdyfHBwbIn6VQho9gd6k+TW?=
 =?us-ascii?Q?NgryHaHe9fIEQVXFRcjTJh/Vz4FXEIbud7Y54zcJyegk3+gvM/vbkP6t/8TQ?=
 =?us-ascii?Q?4ORx10AwdeCio2I21AHE383nCJ1OoO5LoAnHrQZYwayngttjqh8OFrGyZPKT?=
 =?us-ascii?Q?PMX57jn25etVDz0zAfDNVS4qzWOVbxMsaPEbjvOL7Gjqd0OChUOLFlJDtBcy?=
 =?us-ascii?Q?KwGW7BBUiR2C5ZECjojgC28hlBQHiJihAQkksE54WWdpBuOeaWz7VRY1/jB8?=
 =?us-ascii?Q?lIZizQXr2I/UR275H/Zup9b7fJD5NSU5zXWlRVI0ymZDvBm89mtwLZi9kDtd?=
 =?us-ascii?Q?dFzpGoGr7oE0tq5EpiXE9AxNoF0MAdh4Wf5Eia8hleqJaJBPPZL+5pzIJVKJ?=
 =?us-ascii?Q?ZvZaV461zWmVawqGDE2WIIIdzDCt/nV+ZtImzn+s9TXl5bTJU6wVppVi3oZA?=
 =?us-ascii?Q?G5G0mHNxl48ApVSbHwo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c88ca1a6-8ed5-476c-91a7-08dc6724d895
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2024 01:45:12.9650
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: en6A4ptLhQNe2QSqY4UszmizeY2pn9E6oO0W2t/rLe2G4b2vVGIEdVrg9D8ENKKKcJgfMd1QBKunA6FVaG0lAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9502

> Subject: [PATCH 05/15] i2c: imx-lpi2c: use 'time_left' variable with
> wait_for_completion_timeout()
>=20
> There is a confusing pattern in the kernel to use a variable named 'timeo=
ut' to
> store the result of wait_for_completion_timeout() causing patterns like:
>=20
> 	timeout =3D wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
>=20
> with all kinds of permutations. Use 'time_left' as a variable to make the=
 code
> self explaining.
>=20
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/i2c/busses/i2c-imx-lpi2c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-=
imx-
> lpi2c.c
> index 36e8f6196a87..0197786892a2 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -307,11 +307,11 @@ static int lpi2c_imx_master_disable(struct
> lpi2c_imx_struct *lpi2c_imx)
>=20
>  static int lpi2c_imx_msg_complete(struct lpi2c_imx_struct *lpi2c_imx)  {
> -	unsigned long timeout;
> +	unsigned long time_left;
>=20
> -	timeout =3D wait_for_completion_timeout(&lpi2c_imx->complete, HZ);
> +	time_left =3D wait_for_completion_timeout(&lpi2c_imx->complete, HZ);
>=20
> -	return timeout ? 0 : -ETIMEDOUT;
> +	return time_left ? 0 : -ETIMEDOUT;
>  }
>=20
>  static int lpi2c_imx_txfifo_empty(struct lpi2c_imx_struct *lpi2c_imx)
> --
> 2.43.0
>=20