Received-SPF: pass (google.com: domain of linux-kernel+bounces-161310-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sudeep.holla@arm.com,
	cristian.marussi@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2] firmware: arm_scmi: power_control: support suspend command
Date: Sun, 28 Apr 2024 15:51:05 +0800
Message-Id: <20240428075105.2187837-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DB9PR04MB8188:EE_
X-MS-Office365-Filtering-Correlation-Id: a11f623f-4afe-4752-819e-08dc6756d8e8
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam:
	BCL:0;ARA:13230031|376005|52116005|1800799015|366007|38350700005;
X-Microsoft-Antispam-Message-Info:
	=?us-ascii?Q?n8kc+TvS9lyJyhh7I4qv5+PhaypVo0MCU0NtAyg0AP9H+OUhn/XsCHKbM1hO?=
 =?us-ascii?Q?llmfHf8aSVlEorWwMfDm6UjtxgPPZEf3KjEJCqNWquhi8gd+lWrCTb2xrX0U?=
 =?us-ascii?Q?nOvL7G2xDShoWuVzW5IKsRpqfufXkOX+jnXpUBiRld+spMQtXkPq0posdZ8b?=
 =?us-ascii?Q?xaYzSOmfrjj042gOXt5RGtEUwja347YcrE4B4ZP98GpEGg0G6wV1mnNr04BQ?=
 =?us-ascii?Q?dD5D1B6lAjWRVAWCjMr2vYMph4ma7HcgkCMRq/LjA9UNnRfcpF/Adwtj84E4?=
 =?us-ascii?Q?9uBEfvXRHLDFfyUj7F/FOkExXh3DJlcgGG5KYS91xl1ehXj8ml6Nwo48CE7A?=
 =?us-ascii?Q?WilyGwxaOtQp99HS09ncqw1gtBrs9gTdy2zKXj6NCE4jOvJVltPr657Oyiab?=
 =?us-ascii?Q?k2iTQQlKsxx/UabEO3nt13Ov8L0SSG5bMCWR+BgxmcY+KaHhDJMJosZJNEGl?=
 =?us-ascii?Q?+oXXNyNWXJfAbikv9Y2eceLtWtOtn4fmmdkMfUGGuPILoGfHcb7SW94x9nGe?=
 =?us-ascii?Q?ByqVAj8ZcA2iMAcU8y3SSA2+J2tZYwknklQADCkIc7e6CRBTPlVkvE+Bzlr8?=
 =?us-ascii?Q?UG4d+j4h+TFAawWXoPu4Q9z8JZ9AMb40VlALBwRAagE3wsC5YVv9oAmDerQF?=
 =?us-ascii?Q?Is61z/a+E7X30N6JYfjOLFFVwSJwckHqP5ZT29/nbrofqEPGpODSMT+he995?=
 =?us-ascii?Q?yudCwbnEfgBEfYla705wZKOHVxsY36EYpEs8A66D1LNzVpxZJEvEvZz7DdfH?=
 =?us-ascii?Q?lRp77NN5f88+TTWv0kZkhUbHVcSrct7WTRCeIDduf/fN98nBSejxfrMnlWU3?=
 =?us-ascii?Q?cB27txGEApxoehkpPXgWe71xcbzuk+APkGjLivNHkAI1jj5HSqVY4zSIUpLW?=
 =?us-ascii?Q?BbbOSP2HZuFA1Kk+XR91NioGNhpbZ7a28naHMIZ10aQEhSrE8cqgNw2Okf0R?=
 =?us-ascii?Q?l368zNPGIZ5edFCE26e2D+T0Rt6OVjb+QheBpfp93HMO5g18MEM8awTYdTh5?=
 =?us-ascii?Q?SwvkfEWnxMA+X7Xyiqak+/HSuLBXhy7VlUFFgy5HedXYERj6cphaMXGrya5p?=
 =?us-ascii?Q?WiM4ofE/+mo9z8aZbZRS2C2NFwn4sso0XwN+D+Fm71gP2MHuj3cxnl0oWJb+?=
 =?us-ascii?Q?nn7tH/N3hTu+djHmvughU+y2nCBQQhS3Ru/SBpf1v5e3Q+PjsOZ97Quu9Ump?=
 =?us-ascii?Q?xanqnYxWkQf06+SJMEOHLTB49r1DnJA170YI0GAAJ1YJlSGC7U4jiWyUgb1X?=
 =?us-ascii?Q?AyjPS+AXXa/2PqqqPxX+UfB3mapBHbuIbBxCX9lfyvWICeSzH0LZgUHHPb5M?=
 =?us-ascii?Q?NiSeQZrDlb2IdClrrZ3GMzPL/T/k0hcmuPdc88hJza7E5g=3D=3D?=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(366007)(38350700005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?d+svzKmmGp5yl8B7/O5DEcV4YshFPJ6/yjys+PRDQeChgLscAnVJp2t0RxB+?=
 =?us-ascii?Q?mf3VWnFBKbyk11NyMhs/0Yf3jkqcoAF3/eRHnEctrXE3PM5u9YhWGkpdGIxf?=
 =?us-ascii?Q?JWZPIZg4Ttr2Wh1WQ1Z7SkFZGq7hfLP0LWCy6Fu5npqoya29bInSouZFELzO?=
 =?us-ascii?Q?RFSBKm89ZiedLEgPrkUwC8dXk3GckqzV9hRfY7H9OsBwLA5Y1jeeimLUsaej?=
 =?us-ascii?Q?S27B6daQ3ZY3UPADam9GpYd2c241d7CbgImGE24da0C+AvOjJf9P0raZsDuf?=
 =?us-ascii?Q?Qd5s6sN8ov3B1CEyVXVG+cqvOaI9flwllfo+/eCnmbJVXshiOi82xM8kEE7/?=
 =?us-ascii?Q?CioznRhZ9PZUdKcvJBpIaNDvUXdiOj8Phv9yre4dT4QOlcgQXBmsZX0+oey1?=
 =?us-ascii?Q?1uLc9h6V373Sd5QKdC+Ewn+YkZ+4p7N5N1KBVYKB2lEJW7pzGH593aYQHZXf?=
 =?us-ascii?Q?zhMvscCJZnlUM5FILiRyjur6CCXUC05U82WXDW7Z9Qzada+eoaxuK2ccXn+c?=
 =?us-ascii?Q?MDI7LoCqE3OdJSQ56sX+SEudfou6SGtvoVO9yvrQVxVJEy52+D27+I5E3vfj?=
 =?us-ascii?Q?7LDIcBMllQuki+P30h8bpV7C/N9lIoEYtPxHnZR836OKg0AIh5pgejSAYFd9?=
 =?us-ascii?Q?AG02W9A5IXtrDj2G6kdOCs8anrvHTIv5z6IZB2ZRu8fNC7PkE6L9aa61nyqO?=
 =?us-ascii?Q?QAx7X/3e5ELFpthC/0WF9lItfEN2EcuhFPvAVwhpnqjo3MdekWjnIYRxwBzk?=
 =?us-ascii?Q?mhmhqyBtbTRH0WM9IkQggOIs0TBAaBCIFDgonBdKleV/CzvHjw9846Zvt5us?=
 =?us-ascii?Q?x4/XucLx7qV3843CXIsilpmQgp5NESXWmTAnqd4QKKM4nMU/zTFQP5GOe03W?=
 =?us-ascii?Q?Zx/G2EEdgsv0Ka+hdxGTlmUqkHXB/A21qLZdhQ7nN6pBN9bJpkRjdti3lJtD?=
 =?us-ascii?Q?UnXXitFYkXc/8wHQzkTRt+c7yXtpMhJC0gLk1vBhJRb+yKoHfBj/X+VK7Ael?=
 =?us-ascii?Q?h0Wh/1n95k/p4eK6WqpLZVuXogXCWf9ChaRdZAmRxbQou1EWTkAxCIDW69kp?=
 =?us-ascii?Q?L0UDI0gJaONF+l6vjhJU3lb5H5yIsFWl+kgCpED97mwu79Z5luUi7fsE00Tl?=
 =?us-ascii?Q?FXpG9H2q5RLkw2pnPaOhDq8KkbULt362m9moWRNij80PL/RyOeqWt4VBZ0R0?=
 =?us-ascii?Q?7dCh1/vNu+kQ25I+ZlqtQkId7s9QoZGNYvLN2fC5iT37uMgOSfv9jX1DOlGP?=
 =?us-ascii?Q?z+JFgsDTsA1tI3mYCy0sSkJEO8lv0Wdaf5tha11FnVRAKQd9Ve/sqE6oeRcs?=
 =?us-ascii?Q?IhW+X9L1S6apdmiXMWxrOOAs1d9OhmNsbN08NjtFrz7PiTbc71JywJzcl1ac?=
 =?us-ascii?Q?TLvjss02uhkoj07F3Q6wEI0weSBjsksooWZzRMbDOEK9hYLuN1Zel/yDVNih?=
 =?us-ascii?Q?Duv9Be3TzdxDRGCcHDzUGQF6W3kD9q2/fPZ0Vy8AsbQYRf+tU9we8Zix1xl0?=
 =?us-ascii?Q?9/ui03+yBp8JHT6NyBNApNfoicfE7Mux0BCG+7xWNPtsaHBgJBa4j8fvj1f2?=
 =?us-ascii?Q?GL85k3t16GazgQbWnTjNZD1xd2rXq5o8tz9VxsDc?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a11f623f-4afe-4752-819e-08dc6756d8e8
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2024 07:43:08.6514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X1HHs5CReBKjlSGSpXkP3qpgE7HWjf+v+fRl8/T/B2NNRZm+SAhGWDjmVpHE1GT4ZfxyT5vEP5GSIrqJvNCLXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8188

From: Peng Fan <peng.fan@nxp.com>

Support System suspend notification. Using a work struct to call
pm_suspend. There is no way to pass suspend level to pm_suspend,
so use MEM as of now.

- The choice of S2R(MEM) by default. The userspace can configure whatever
  default behaviour expected as S2R, if issuing suspend from userspace.

- The userspace needs to keep the wakeup source enabled, otherwise the
  system may never resume back.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Update commit log
 Add comment for suspend_work

 .../firmware/arm_scmi/scmi_power_control.c    | 21 ++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/scmi_power_control.c b/drivers/firmware/arm_scmi/scmi_power_control.c
index 6eb7d2a4b6b1..21f467a92942 100644
--- a/drivers/firmware/arm_scmi/scmi_power_control.c
+++ b/drivers/firmware/arm_scmi/scmi_power_control.c
@@ -50,6 +50,7 @@
 #include <linux/reboot.h>
 #include <linux/scmi_protocol.h>
 #include <linux/slab.h>
+#include <linux/suspend.h>
 #include <linux/time64.h>
 #include <linux/timer.h>
 #include <linux/types.h>
@@ -78,6 +79,7 @@ enum scmi_syspower_state {
  * @reboot_nb: A notifier_block optionally used to track reboot progress
  * @forceful_work: A worker used to trigger a forceful transition once a
  *		   graceful has timed out.
+ * @suspend_work: A worker used to trigger system suspend
  */
 struct scmi_syspower_conf {
 	struct device *dev;
@@ -90,6 +92,7 @@ struct scmi_syspower_conf {
 	struct notifier_block reboot_nb;
 
 	struct delayed_work forceful_work;
+	struct work_struct suspend_work;
 };
 
 #define userspace_nb_to_sconf(x)	\
@@ -249,6 +252,9 @@ static void scmi_request_graceful_transition(struct scmi_syspower_conf *sc,
 	case SCMI_SYSTEM_WARMRESET:
 		orderly_reboot();
 		break;
+	case SCMI_SYSTEM_SUSPEND:
+		schedule_work(&sc->suspend_work);
+		break;
 	default:
 		break;
 	}
@@ -277,7 +283,8 @@ static int scmi_userspace_notifier(struct notifier_block *nb,
 	struct scmi_system_power_state_notifier_report *er = data;
 	struct scmi_syspower_conf *sc = userspace_nb_to_sconf(nb);
 
-	if (er->system_state >= SCMI_SYSTEM_POWERUP) {
+	if (er->system_state >= SCMI_SYSTEM_MAX ||
+	    er->system_state == SCMI_SYSTEM_POWERUP) {
 		dev_err(sc->dev, "Ignoring unsupported system_state: 0x%X\n",
 			er->system_state);
 		return NOTIFY_DONE;
@@ -315,6 +322,16 @@ static int scmi_userspace_notifier(struct notifier_block *nb,
 	return NOTIFY_OK;
 }
 
+static void scmi_suspend_work_func(struct work_struct *work)
+{
+	struct scmi_syspower_conf *sc =
+		container_of(work, struct scmi_syspower_conf, suspend_work);
+
+	pm_suspend(PM_SUSPEND_MEM);
+
+	sc->state = SCMI_SYSPOWER_IDLE;
+}
+
 static int scmi_syspower_probe(struct scmi_device *sdev)
 {
 	int ret;
@@ -338,6 +355,8 @@ static int scmi_syspower_probe(struct scmi_device *sdev)
 	sc->userspace_nb.notifier_call = &scmi_userspace_notifier;
 	sc->dev = &sdev->dev;
 
+	INIT_WORK(&sc->suspend_work, scmi_suspend_work_func);
+
 	return handle->notify_ops->devm_event_notifier_register(sdev,
 							   SCMI_PROTOCOL_SYSTEM,
 					 SCMI_EVENT_SYSTEM_POWER_STATE_NOTIFIER,
-- 
2.37.1